📝 AgusR7 opened a pull request: "test: use context managers and add file existence checks in feature_fee_estimation.py"
(https://github.com/bitcoin/bitcoin/pull/31030)
update feature_fee_estimation.py test script to improve resource management and exception safety:

Use context managers for file operations: Replaced all instances of file handling using "open()" with "with open()" statements to ensure files are properly closed after their operations, even if exceptions occur.

Add file existence checks: Before performing file operations like os.utime() and os.remove(), added checks using os.path.exists() to prevent errors when files are missing.

📝 dollarparity opened a pull request: "doc: clarify 'filename' argument in 'loadwallet' RPC"
(https://github.com/bitcoin/bitcoin/pull/31031)
Update the 'loadwallet' RPC help text to specify that the 'filename' should be provided as a path relative to the wallets directory. Add examples showing how to load a wallet from a different directory.

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Ple
...

💬 achow101 commented on pull request "doc: clarify 'filename' argument in 'loadwallet' RPC":
(https://github.com/bitcoin/bitcoin/pull/31031#issuecomment-2392711034)
Duplicate of #30302

⚠️ pilab-gwon opened an issue: "[Testnet] Insufficient data or no feerate found"
(https://github.com/bitcoin/bitcoin/issues/31032)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

I encountered an error when attempting to use the estimatesmartfee method.
But node only return `Insufficient data or no feerate found`

Below is the request I sent:
```bash
curl --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "estimatesmartfee", "params": [1] }' -H 'content-type: text/plain;' http://localhost:80
```


### Expected behaviour

Expected output:
```
{"re
...

👍 Sjors approved a pull request: "qt6, test: Handle deprecated code"
(https://github.com/bitcoin-core/gui/pull/839#pullrequestreview-2347416833)
tACK 5625840c11db2065a1c8d8de3babb6466eda04d4

I only tested on Intel macOS 15.0 with Homebrew qt@5. Checked that the warnings still appear with `build/src/qt/test/test_bitcoin-qt`.

💬 Sjors commented on pull request "qt6, test: Handle deprecated code":
(https://github.com/bitcoin-core/gui/pull/839#discussion_r1787335639)
5625840c11db2065a1c8d8de3babb6466eda04d4: note to other reviewers: https://doc.qt.io/qt-6/qtest.html#QVERIFY_THROWS_EXCEPTION

👍 itornaza approved a pull request: "rpc: add getorphantxs"
(https://github.com/bitcoin/bitcoin/pull/30793#pullrequestreview-2347440969)
reACK 98c1536852d1de9a978b11046e7414e79ed40b46

💬 promag commented on pull request "qt6: Fix linking when configured with `-DENABLE_WALLET=OFF`":
(https://github.com/bitcoin-core/gui/pull/837#issuecomment-2393139603)
ACK 5be34bacf6d07fb73a0cedfb63a384968d538f3e, all other changes in 33657e1c958146312e4c68765a92871920401396 are not required, makes the code harder to read.

💬 hebasto commented on pull request "qt6: Fix linking when configured with `-DENABLE_WALLET=OFF`":
(https://github.com/bitcoin-core/gui/pull/837#discussion_r1787391324)
> Reworked.

Reverted back.

> How the `RPCExecutor::request` method compiles when this line doesn't exist?

Due to https://github.com/bitcoin-core/gui/blob/5be34bacf6d07fb73a0cedfb63a384968d538f3e/src/qt/rpcconsole.h#L24

🚀 hebasto merged a pull request: "qt6, test: Handle deprecated code"
(https://github.com/bitcoin-core/gui/pull/839)

💬 itornaza commented on issue "depends: llvm-ranlib (etc): "No such file or directory" on Intel macOS 15.0":
(https://github.com/bitcoin/bitcoin/issues/30978#issuecomment-2393255981)
Same error messages as @Sjors on a clean build as well.

```
ioannis@ergot_a depends % make
/bin/sh: command -v llvm-ranlib: No such file or directory
/bin/sh: command -v llvm-strip: No such file or directory
/bin/sh: command -v llvm-nm: No such file or directory
/bin/sh: command -v llvm-objdump: No such file or directory
/bin/sh: command -v dsymutil: No such file or directory
Fetching boost_1_81_0.tar.gz from https://archives.boost.io/release/1.81.0/source/
% Total % Received % X
...

💬 Sjors commented on pull request "refactor: Replace g_genesis_wait_cv with m_tip_block_cv":
(https://github.com/bitcoin/bitcoin/pull/30967#discussion_r1787471881)
> The code should just be able to call `waitTipChanged()` with the zero value, which will return as soon as node is started and it knows what the tip is.

That indeed seems like a better approach, will change that for the TP.

💬 Sjors commented on pull request "refactor: Replace g_genesis_wait_cv with m_tip_block_cv":
(https://github.com/bitcoin/bitcoin/pull/30967#issuecomment-2393327733)
ACK fa22e5c430acaef9713d9a4b4b97bb3f4876f816

Manually tested `-stopatheight`, a fatal indexer error (by breaking some code), calling `bitcoin-cli stop`, manually quitting qt, calling `stop` form the GUI console.

💬 hebasto commented on issue "Unable to cross compile on linux for macos (28.x branch)":
(https://github.com/bitcoin/bitcoin/issues/31027#issuecomment-2393328681)
> debian unstable (sid) runs on clang-20 doesn't need to downgrade it

Debian Sid's [default clang](https://packages.debian.org/sid/clang) is clang-16, which is enough to build every dependency except for the `qt` package.

Here is a full log of the commands on a fresh Debian Sid image:
```
# history
1 apt update
2 apt install git bison cmake curl make pkg-config xz-utils wget
3 apt install clang llvm lld
4 git clone https://github.com/bitcoin/bitcoin.git
5 w
...

👍 Sjors approved a pull request: "refactor: Replace g_genesis_wait_cv with m_tip_block_cv"
(https://github.com/bitcoin/bitcoin/pull/30967#pullrequestreview-2347659011)
ACK fa22e5c430acaef9713d9a4b4b97bb3f4876f816

Manually tested `-stopatheight`, a fatal indexer error (by breaking some code), calling `bitcoin-cli stop`, manually quitting qt, calling `stop` form the GUI console.

🤔 hebasto reviewed a pull request: "refactor: move util/pcp and util/netif to common/"
(https://github.com/bitcoin/bitcoin/pull/31011#pullrequestreview-2347681620)
Post-merge ACK fd38711217cafbd62e8abd22d2b43f85fede8cde.

🚀 hebasto merged a pull request: "qt6: Fix linking when configured with `-DENABLE_WALLET=OFF`"
(https://github.com/bitcoin-core/gui/pull/837)

💬 promag commented on pull request "cmake: Avoid hardcoding Qt's major version in Find module / variable names":
(https://github.com/bitcoin/bitcoin/pull/31010#issuecomment-2393380465)
Code review ACK deacf3c7cd68dd4ee973526740e45c7015b6433a.

💬 marcofleon commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#issuecomment-2393409008)
@instagibbs thanks, that makes sense. I did see the `fRejectedParents` is true case with an input that crashed on 3c1c9e766ad4fc6defdc9b4814c1e184f6603003 (before the last push).

Option 1 in your list seems most robust to me as well.

🤔 ismaelsadeeq reviewed a pull request: "Cluster linearization: separate tests from tests-of-tests"
(https://github.com/bitcoin/bitcoin/pull/30605#pullrequestreview-2347653035)
I reviewed the latest changes in the last push

Code review 8eb70e3ca467ac66bc1f43e3e0b3338d63806ee5

Changes since my last review were

1. Addressed my previous review comments.

2. An optimization was introduced in the `clusterlin_simple_linearize` fuzz test that skips to the last non-topological permutation.
For example, given transactions `[A, B, C, D, E]`.
if A-B-C are a valid topological ancestor set, and the first permutation results in [A, E, B, C, D], which is not topologica
...