💬 1440000bytes commented on pull request "net: Use GetAdaptersAddresses to get local addresses on Windows":
(https://github.com/bitcoin/bitcoin/pull/31014#issuecomment-2392275622)
> Instead of a gethostname hack, use the official way of calling GetAdaptersAddresses to get local network addresses on Windows.

Concept ACK

💬 tdb3 commented on issue "ci: `feature_settings.py` failed with `Invalid value detected for '-wallet' or '-nowallet'` in macOS 14 CI":
(https://github.com/bitcoin/bitcoin/issues/31019#issuecomment-2392329519)
> @tdb3 it might be helpful to share link to the full C.I logs?

Thanks. Link now included in the description.

💬 sr-gi commented on pull request "Fix tiebreak when loading blocks from disk (and add tests for comparing chain ties)":
(https://github.com/bitcoin/bitcoin/pull/29640#discussion_r1786845164)
I guess it may be worth crating an issue / opening a separate PR to fix this, given it is unrelated

💬 1440000bytes commented on pull request "net: option to disallow v1 connection on ipv4 and ipv6 peers":
(https://github.com/bitcoin/bitcoin/pull/30951#issuecomment-2392352182)
I think it's too early to add this option but it will remain unused by most and off by default. I don't see anything wrong with some users testing it.

This doesn't hide the fact that a user is running a bitcoin node (most IPv4 nodes use default port). It just ensures all peers are using v2 for P2P.

👍 1440000bytes approved a pull request: "netinfo: add peer services column and outbound-only peers list"
(https://github.com/bitcoin/bitcoin/pull/30930#pullrequestreview-2346741932)
ACK https://github.com/bitcoin/bitcoin/pull/30930/commits/683b558a020f1632b0a3cbdaa165adbd1423281c

💬 1440000bytes commented on pull request "rpc: Add support to populate PSBT input utxos via rpc":
(https://github.com/bitcoin/bitcoin/pull/30886#issuecomment-2392391647)
Concept ACK

💬 hebasto commented on issue "Unable to cross compile on linux for macos (28.x branch)":
(https://github.com/bitcoin/bitcoin/issues/31027#issuecomment-2392448801)
Here are the steps to build depends without Qt on Debian 12:
```
apt update
apt install git bison cmake curl make pkg-config xz-utils wget
# Install minimum required version of LLVM toolchain
apt install clang-16 llvm-16 lld-16
# Create non-versioned symlinks of the tools
ln -s /usr/bin/clang-16 /usr/bin/clang
ln -s /usr/bin/clang++-16 /usr/bin/clang++
ln -s /usr/bin/lld-16 /usr/bin/lld
ln -s /usr/bin/ld.lld-16 /usr/bin/ld.lld
ln -s /usr/bin/lld-link-16 /usr/bin/lld-link
ln -s /usr/b
...

💬 JayBitron commented on issue "Unable to cross compile on linux for macos (28.x branch)":
(https://github.com/bitcoin/bitcoin/issues/31027#issuecomment-2392474110)
`/usr/bin/ld: unrecognised emulation mode: llvm`

🤔 promag reviewed a pull request: "qt6, test: Handle deprecated code"
(https://github.com/bitcoin-core/gui/pull/839#pullrequestreview-2346817911)
Code review ACK 5625840c11db2065a1c8d8de3babb6466eda04d4.

💬 JayBitron commented on issue "Unable to cross compile on linux for macos (28.x branch)":
(https://github.com/bitcoin/bitcoin/issues/31027#issuecomment-2392482422)
I'm using version 20 it returns `/usr/bin/ld: unrecognised emulation mode: llvm`
when I create symbolic links to version 16 it returns `/usr/bin/ld: unrecognised emulation mode: acosx_version_min`
It's is different error on each version

💬 JayBitron commented on issue "Unable to cross compile on linux for macos (28.x branch)":
(https://github.com/bitcoin/bitcoin/issues/31027#issuecomment-2392503162)
debian unstable (sid) run on clang-20 doesn't need to downgrade it

💬 JayBitron commented on issue "Unable to cross compile on linux for macos (28.x branch)":
(https://github.com/bitcoin/bitcoin/issues/31027#issuecomment-2392513451)
I just freshly installed a linux and went the steps as you said still getting this error:
```
root@localhost:~/.build/bitcoin# make -C depends HOST=x86_64-apple-darwin -j32
make: Entering directory '/root/.build/bitcoin/depends'
Fetching boost_1_81_0.tar.gz from https://archives.boost.io/release/1.81.0/source/
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 133M 100 133M
...

💬 JayBitron commented on issue "Unable to cross compile on linux for macos (28.x branch)":
(https://github.com/bitcoin/bitcoin/issues/31027#issuecomment-2392515334)
I know now bitcoin 28.x macos builds are broken officially, in 27.x all tools were built in, about 800MB down was taken down.

👍 tdb3 approved a pull request: "ci: set a ctest test timeout of 1200 (20 minutes)"
(https://github.com/bitcoin/bitcoin/pull/31026#pullrequestreview-2346849054)
ACK 93dda4c70254750a5b5c0e7f7d2d89032519b999

Looks like a good way to cut off abnormally running unit tests.
As a sanity check, confirmed that `ctest` returns non-zero when the timeout is hit (e.g. `ctest --timeout 10 --test-dir build`).

💬 JayBitron commented on issue "Unable to cross compile on linux for macos (28.x branch)":
(https://github.com/bitcoin/bitcoin/issues/31027#issuecomment-2392519954)
Yes, I see `native_llvm.mk` was removed from 28.x

⚠️ glozow pinned an issue: "Release Schedule for 29.0"
(https://github.com/bitcoin/bitcoin/issues/31029)
Here is a proposed release schedule for `v29.0`, the next major release of Bitcoin Core. The dates are set to target a release in early April.

## 2025-02-06 :construction:
- Open Transifex translations for `v29.0`
- Soft translation string freeze (no large or non-critical string changes until release)
- Finalize and close translations for `v27.0`

## 2025-02-20 :construction:
- Feature freeze (bug fixes only until release)
- Translation string freeze (no more source language changes un
...

🤔 theStack reviewed a pull request: "refactor: TxDownloadManager + fuzzing"
(https://github.com/bitcoin/bitcoin/pull/30110#pullrequestreview-2342669240)
Left some more review comments below; these are mostly pedantic nits that can be done in a follow-up, but also one (minor?) behavior change.

💬 theStack commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1786893269)
never-used-nit
```suggestion
```

💬 theStack commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1784925614)
```suggestion
for (NodeId nodeid = 0; nodeid < NUM_PEERS; ++nodeid) {
```

💬 theStack commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1784927176)
```suggestion
for (NodeId nodeid = 0; nodeid < NUM_PEERS; ++nodeid) {
```