💬 Sjors commented on pull request "Add -pausebackgroundsync startup option":
(https://github.com/bitcoin/bitcoin/pull/31023#issuecomment-2391574034)
> disabling rather than pausing background validation
I think it's good to maintain the option to finish background validation. E.g. maybe because you want to enable an index.
(https://github.com/bitcoin/bitcoin/pull/31023#issuecomment-2391574034)
> disabling rather than pausing background validation
I think it's good to maintain the option to finish background validation. E.g. maybe because you want to enable an index.
💬 jonatack commented on pull request "doc: update IBD requirements in doc/README.md":
(https://github.com/bitcoin/bitcoin/pull/30992#discussion_r1786342327)
I think I prefer "several hundred or more", as given the current size required, it conveys the floor to expect a bit more, and when the requirement breaks past a terabyte, "or more" allows more time before updating again, whereas "hundreds" might be construed as or implies "not thousands."
(https://github.com/bitcoin/bitcoin/pull/30992#discussion_r1786342327)
I think I prefer "several hundred or more", as given the current size required, it conveys the floor to expect a bit more, and when the requirement breaks past a terabyte, "or more" allows more time before updating again, whereas "hundreds" might be construed as or implies "not thousands."
💬 mzumsande commented on issue "ci: macOS 14 CI failure `Invalid value detected for '-wallet' or '-nowallet'`":
(https://github.com/bitcoin/bitcoin/issues/31019#issuecomment-2391596799)
@tdb3: CI runs always rebase the PR with respect to master, so that is expected (it helps find conflicts). Also, after CI finished, there are re-runs scheduled every now and then that will rebase on new master again.
(https://github.com/bitcoin/bitcoin/issues/31019#issuecomment-2391596799)
@tdb3: CI runs always rebase the PR with respect to master, so that is expected (it helps find conflicts). Also, after CI finished, there are re-runs scheduled every now and then that will rebase on new master again.
💬 josibake commented on pull request "Add -pausebackgroundsync startup option":
(https://github.com/bitcoin/bitcoin/pull/31023#issuecomment-2391626041)
> Wait, how does pausing IDB help with benchmarking IBD?
I had a chat with @Sjors recently regarding a benchmarking use case I have, where I want to benchmark doing IBD on more recent blocks to test flush behaviour. AssumeUTXO seemed useful here in that I could start from, e.g., 800,000 and sync to tip. For this, background validation would likely interfere with the results so having a `-pausebackgroundvalidation` option seemed useful. Worth mentioning, this is not meant to be a representativ
...
(https://github.com/bitcoin/bitcoin/pull/31023#issuecomment-2391626041)
> Wait, how does pausing IDB help with benchmarking IBD?
I had a chat with @Sjors recently regarding a benchmarking use case I have, where I want to benchmark doing IBD on more recent blocks to test flush behaviour. AssumeUTXO seemed useful here in that I could start from, e.g., 800,000 and sync to tip. For this, background validation would likely interfere with the results so having a `-pausebackgroundvalidation` option seemed useful. Worth mentioning, this is not meant to be a representativ
...
✅ willcl-ark closed an issue: "bitcoin.service issue for a noob like me"
(https://github.com/bitcoin/bitcoin/issues/31021)
(https://github.com/bitcoin/bitcoin/issues/31021)
💬 willcl-ark commented on issue "bitcoin.service issue for a noob like me":
(https://github.com/bitcoin/bitcoin/issues/31021#issuecomment-2391637885)
I think we can close this now as it's resolved.
In the future please be aware that general bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com/) or the `#bitcoin` IRC channel on the [Libera Chat](https://libera.chat/) network.
(https://github.com/bitcoin/bitcoin/issues/31021#issuecomment-2391637885)
I think we can close this now as it's resolved.
In the future please be aware that general bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com/) or the `#bitcoin` IRC channel on the [Libera Chat](https://libera.chat/) network.
💬 andrewtoth commented on pull request "docs: Add instructions on how to self-sign bitcoin-core binaries for macOS":
(https://github.com/bitcoin/bitcoin/pull/30982#issuecomment-2391655144)
ACK 6c52d6ed8a5b3cdfff9b565c139e35b821647f6b
Downloaded 27.1 tar and ran `./bitcoin-cli` and got the broken popup.
Ran the command, ran `./bitcoin-cli` and got the help output.
Ran into this issue before with other apps on macOS, and just ran `xattr -cr <filename>`. This seems to be a better approach though.
(https://github.com/bitcoin/bitcoin/pull/30982#issuecomment-2391655144)
ACK 6c52d6ed8a5b3cdfff9b565c139e35b821647f6b
Downloaded 27.1 tar and ran `./bitcoin-cli` and got the broken popup.
Ran the command, ran `./bitcoin-cli` and got the help output.
Ran into this issue before with other apps on macOS, and just ran `xattr -cr <filename>`. This seems to be a better approach though.
💬 sipa commented on pull request "docs: Add instructions on how to self-sign bitcoin-core binaries for macOS":
(https://github.com/bitcoin/bitcoin/pull/30982#discussion_r1786408900)
Please capitalize the project name: Bitcoin Core.
(https://github.com/bitcoin/bitcoin/pull/30982#discussion_r1786408900)
Please capitalize the project name: Bitcoin Core.
🤔 danielabrozzoni reviewed a pull request: "[refactor] Cleanup BlockAssembler mempool usage"
(https://github.com/bitcoin/bitcoin/pull/28843#pullrequestreview-2345919799)
ACK 60a0f2ac88c57fdf4482dade2ce409ef2da65998
(https://github.com/bitcoin/bitcoin/pull/28843#pullrequestreview-2345919799)
ACK 60a0f2ac88c57fdf4482dade2ce409ef2da65998
💬 stickies-v commented on pull request "Add -pausebackgroundsync startup option":
(https://github.com/bitcoin/bitcoin/pull/31023#issuecomment-2391695605)
Thanks for explaining the intended use cases in more detail.
Benchmarking from a fixed height seems useful but also seems quite feasible without `-pausebackgroundsync` too (e.g. from an existing datadir which allows starting from any height instead of the hardcoded 840.000 blocks)? Worsening the code for test-only purposes is something I think we should only do if the alternatives are too much of a hassle.
Similarly, I don't see a proper use case for end users either. I think the discussi
...
(https://github.com/bitcoin/bitcoin/pull/31023#issuecomment-2391695605)
Thanks for explaining the intended use cases in more detail.
Benchmarking from a fixed height seems useful but also seems quite feasible without `-pausebackgroundsync` too (e.g. from an existing datadir which allows starting from any height instead of the hardcoded 840.000 blocks)? Worsening the code for test-only purposes is something I think we should only do if the alternatives are too much of a hassle.
Similarly, I don't see a proper use case for end users either. I think the discussi
...
💬 dergoegge commented on pull request "test: Add mockable steady clock, tests for PCP and NATPMP implementations":
(https://github.com/bitcoin/bitcoin/pull/31022#discussion_r1786428201)
> i wasn't sure which of the current usages should be mockable and didn't want to decide that here
fair enough!
`MockableSteadyClock` sgtm!
(https://github.com/bitcoin/bitcoin/pull/31022#discussion_r1786428201)
> i wasn't sure which of the current usages should be mockable and didn't want to decide that here
fair enough!
`MockableSteadyClock` sgtm!
💬 dergoegge commented on pull request "test: Add mockable steady clock, tests for PCP and NATPMP implementations":
(https://github.com/bitcoin/bitcoin/pull/31022#discussion_r1786431421)
> in my current tests i in fact reset it in every test case.
Right, this wouldn't work with my approach as this is a global.
(https://github.com/bitcoin/bitcoin/pull/31022#discussion_r1786431421)
> in my current tests i in fact reset it in every test case.
Right, this wouldn't work with my approach as this is a global.
💬 mzumsande commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1786435183)
I'd say it might be a good idea moving the removal until after validation - that should address both scenarios.
We are going to validate it anyway, so I don't really see any downsides to that.
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1786435183)
I'd say it might be a good idea moving the removal until after validation - that should address both scenarios.
We are going to validate it anyway, so I don't really see any downsides to that.
💬 ismaelsadeeq commented on pull request "doc: update IBD requirements in doc/README.md":
(https://github.com/bitcoin/bitcoin/pull/30992#discussion_r1786435782)
> whereas "hundreds" might be construed as or implies "not thousands."
I just wanted to be specific on the what is the requirement currently.
"several hundred or more" is not specific.
> it conveys the floor to expect a bit more, and when the requirement breaks past a terabyte, "or more" allows more time before updating again.
Fair enough, it is likely to break hundreds, so this comment can be ignored; it's a non-blocking nit.
(https://github.com/bitcoin/bitcoin/pull/30992#discussion_r1786435782)
> whereas "hundreds" might be construed as or implies "not thousands."
I just wanted to be specific on the what is the requirement currently.
"several hundred or more" is not specific.
> it conveys the floor to expect a bit more, and when the requirement breaks past a terabyte, "or more" allows more time before updating again.
Fair enough, it is likely to break hundreds, so this comment can be ignored; it's a non-blocking nit.
💬 Christewart commented on pull request "docs: Add instructions on how to self-sign bitcoin-core binaries for macOS":
(https://github.com/bitcoin/bitcoin/pull/30982#discussion_r1786441085)
Done in 27709f5
(https://github.com/bitcoin/bitcoin/pull/30982#discussion_r1786441085)
Done in 27709f5
💬 andrewtoth commented on pull request "docs: Add instructions on how to self-sign bitcoin-core binaries for macOS":
(https://github.com/bitcoin/bitcoin/pull/30982#discussion_r1786455459)
The path won't be `bitcoin-core`, but `bitcoin-28.0`.
```suggestion
cd /path/to/bitcoin-28.0/bin
```
(https://github.com/bitcoin/bitcoin/pull/30982#discussion_r1786455459)
The path won't be `bitcoin-core`, but `bitcoin-28.0`.
```suggestion
cd /path/to/bitcoin-28.0/bin
```
💬 hebasto commented on pull request "qt6: Fix linking when configured with `-DENABLE_WALLET=OFF`":
(https://github.com/bitcoin-core/gui/pull/837#discussion_r1786455836)
Reworked.
(https://github.com/bitcoin-core/gui/pull/837#discussion_r1786455836)
Reworked.
💬 andrewtoth commented on pull request "docs: Add instructions on how to self-sign bitcoin-core binaries for macOS":
(https://github.com/bitcoin/bitcoin/pull/30982#discussion_r1786457075)
Oh I see this is the template.
(https://github.com/bitcoin/bitcoin/pull/30982#discussion_r1786457075)
Oh I see this is the template.
✅ fanquake closed a pull request: "mempool_accept.py changes"
(https://github.com/bitcoin/bitcoin/pull/31025)
(https://github.com/bitcoin/bitcoin/pull/31025)
💬 andrewtoth commented on pull request "docs: Add instructions on how to self-sign bitcoin-core binaries for macOS":
(https://github.com/bitcoin/bitcoin/pull/30982#issuecomment-2391746594)
reACK 27709f51ee02ed4f8c9c7e1c25c6f16faa0ef08b
(https://github.com/bitcoin/bitcoin/pull/30982#issuecomment-2391746594)
reACK 27709f51ee02ed4f8c9c7e1c25c6f16faa0ef08b