💬 Sjors commented on pull request "Add multiprocess binaries to release build":
(https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2385476424)
MSAN says https://cirrus-ci.com/task/6248232848719872:

```
SUMMARY: MemorySanitizer: use-of-uninitialized-value /usr/src/mp/proxy.cpp:146:25 in mp::Connection::addAsyncCleanup(std::__1::function<void ()>)
[10:00:27.923] Exiting
```

💬 fanquake commented on pull request "refactor: add clang-tidy `modernize-use-starts-ends-with` check":
(https://github.com/bitcoin/bitcoin/pull/30868#issuecomment-2385506318)
Seems like newer Clang 19 has improved this check, and throws out more (historical) instances to change. i.e:
```bash
bitcoin/src/torcontrol.cpp:359:27: error: use starts_with instead of compare() == 0 [modernize-use-starts-ends-with,-warnings-as-errors]
359 | if (0 == line.compare(0, 20, "net/listeners/socks=")) {
| ~~~~ ^~~~~~~~~~~~~~ ~
| starts_with( )
bitcoin/src/torco
...

⚠️ toxictoskey opened an issue: "Trading Tool"
(https://github.com/bitcoin/bitcoin/issues/31006)
### Motivation

Hello, world. I created new bot, u can chek this in my profile. Thanks

### Possible solution

_No response_

### Useful Skills

* Compiling Bitcoin Core from source
* Running the C++ unit tests and the Python functional tests
* ...


### Guidance for new contributors

Want to work on this issue?

For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.

✅ fanquake closed an issue: "Trading Tool"
(https://github.com/bitcoin/bitcoin/issues/31006)

:lock: fanquake locked an issue: "Trading Tool"
(https://github.com/bitcoin/bitcoin/issues/31006)

💬 Sjors commented on pull request "Don't zero-after-free `DataStream`: ~25% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/30987#issuecomment-2385580772)
I tested this PR on an AMD Ryzen 7950x machine with Ubuntu 24.04, with one local network peer and a gigabit internet connection.

```
bitcoind -dbcache=30000 -stopatheight=863000 -blocksdir=/magnetic/.bitcoin -addnode=local-network
```

Before: 5 hours 10 minutes
After: 4 hours and 55 minutes

Time includes 20 minutes to flush chainstate to disk during shutdown.

That's nowhere near a 25% difference and probably not statistically significant. Some configurations might do better than o
...

💬 Sjors commented on pull request "Show transactions as not fully confirmed during background validation":
(https://github.com/bitcoin/bitcoin/pull/28616#issuecomment-2385586088)
Rebased and added release note.

@maflcko once the UI supports loading a snapshot, this PR should be in the same release (or earlier). But there's no PR implementing that yet, so no specific release to target.

I don't think there's any outstanding feedback (minor tweaks in iconography and wording can wait for a followup). Some people find it useful, others don't.

💬 epiccurious commented on pull request "docs: Add instructions on how to self-sign bitcoin-core binaries for macOS":
(https://github.com/bitcoin/bitcoin/pull/30982#issuecomment-2385589171)
Post-merge ACK.

For added context, I believe the `codesign` step is only required on arm64 machines. From my testing, the failure doesn't reproduce on amd64 / x86_64 machines.

📝 MarnixCroes opened a pull request: "doc: add testnet4 section header for config file"
(https://github.com/bitcoin/bitcoin/pull/31007)
This PR adds the missing `testnet4` config section header documentation for the config file.

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitco
...

💬 maflcko commented on pull request "Fix unsigned integer overflows in interpreter":
(https://github.com/bitcoin/bitcoin/pull/24214#issuecomment-2385598890)
Rebased once more due to conflict in `test/sanitizer_suppressions/ubsan`.

💬 epiccurious commented on pull request "docs: Add instructions on how to self-sign bitcoin-core binaries for macOS":
(https://github.com/bitcoin/bitcoin/pull/30982#issuecomment-2385603455)
Looks like there may be a workaround by building the macOS binaries on a macOS host machine.

> Due to the mandatory code signing requirement, before the executable is distributed to end users, it must be signed with the "codesign" utility of macOS, otherwise, it will be immediately killed by kernel on launch.

Source (can't find a direct source from Apple): https://github.com/vercel/pkg/issues/1243#issuecomment-873631365

📝 hebasto opened a pull request: "depends: Print ready-to-use `--toolchain` option for CMake invocation"
(https://github.com/bitcoin/bitcoin/pull/31008)
Requested in https://github.com/bitcoin/bitcoin/pull/30997#issuecomment-2385057317:
> P.S. it would be nice if `make` in `depends` provides the incantation needed for the configure stage.

An example of a build log with this PR:
```
$ make --no-print-directory -C depends -j16 NO_QT=1 NO_WALLET=1 NO_UPNP=1 NO_NATPMP=1 NO_ZMQ=1 NO_USDT=1 LOG=1
Extracting boost...
/home/hebasto/git/bitcoin/depends/sources/boost_1_81_0.tar.gz: OK
Preprocessing boost...
Configuring boost...
Building boost..
...

💬 hebasto commented on pull request "depends: Print ready-to-use `--toolchain` option for CMake invocation":
(https://github.com/bitcoin/bitcoin/pull/31008#issuecomment-2385615281)
Friendly ping @Sjors :)

✅ maflcko closed a pull request: "wallet: Add scan_utxo option to getbalances RPC"
(https://github.com/bitcoin/bitcoin/pull/28930)

💬 maflcko commented on pull request "wallet: Add scan_utxo option to getbalances RPC":
(https://github.com/bitcoin/bitcoin/pull/28930#issuecomment-2385637594)
Closing due to inactivity for almost a year

👍 ryanofsky approved a pull request: "refactor: Replace g_genesis_wait_cv with m_tip_block_cv"
(https://github.com/bitcoin/bitcoin/pull/30967#pullrequestreview-2340047317)
Code review ACK fa22e5c430acaef9713d9a4b4b97bb3f4876f816 (just rebased since last review)

💬 maflcko commented on pull request "rpc: add address_type field in getaddressinfo":
(https://github.com/bitcoin/bitcoin/pull/30727#issuecomment-2385644106)
Are you still working on this?

💬 darosior commented on pull request "refactor: Appropriate re-naming of MAX_OPCODE after tapscript":
(https://github.com/bitcoin/bitcoin/pull/30953#issuecomment-2385655466)
I understand your motivation. I'm not making a value judgement on whether this change is good or bad. It is just my personal opinion that the limited resources of the project are better allocated to something else than reviewing a bikeshed-prone (inbefore someone suggests renaming the variable to `MAX_OPCODE_BEFORE_WITNESS_V1` instead) refactoring of a complicated and consensus critical part of the software.

💬 maflcko commented on pull request "test: autogenerate bash completion":
(https://github.com/bitcoin/bitcoin/pull/30860#issuecomment-2385663727)
Are you still working on this? (It looks like this has been opened as draft, with failing CI, which is fine. However, without any progress, it seems better to close this for now.)

⚠️ Sjors opened an issue: "Qt build fails on macOS 15.0"
(https://github.com/bitcoin/bitcoin/issues/31009)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Building bitcoin-qt produces a flood of errors:

```
In file included from /Users/sjors/dev/bitcoin/src/qt/csvmodelwriter.cpp:5:
In file included from /Users/sjors/dev/bitcoin/src/qt/csvmodelwriter.h:8:
In file included from /usr/local/opt/qt@5/lib/QtCore.framework/Headers/QList:1:
In file included from /usr/local/opt/qt@5/lib/QtCore.framework/Headers/qlist.h:48:
/usr/local/include/
...