💬 fanquake commented on issue "Compiling a bitcoin core version that accepts transactions over 100vkb":
(https://github.com/bitcoin/bitcoin/issues/27490#issuecomment-1514490496)
> a guide on what code changes should be done to compile such version

💬 fanquake commented on pull request "refactor: Move chain constants to the util library":
(https://github.com/bitcoin/bitcoin/pull/27491#issuecomment-1514492185)
```bash
7ea09dd60 scripted-diff: Remove unused chainparamsbase includes
d99bd93e0 Add missing definitions in prep for scripted diff
5589a4b0d refactor: Replace string chain name constants with ChainTypes
bd6493bf3 refactor: Create chaintype files

Error: script block marker but no scripted-diff in title of commit 7ea09dd60cd43e943f9910c950b05dda89ef3725
Failed
```

💬 TheCharlatan commented on pull request "refactor: Move chain constants to the util library":
(https://github.com/bitcoin/bitcoin/pull/27491#issuecomment-1514503368)
Re https://github.com/bitcoin/bitcoin/pull/27491#issuecomment-1514492185

> 7ea09dd60 scripted-diff: Remove unused chainparamsbase includes

Seems like the trailing whitespace in the commit mesasge header was tripping it up?

💬 fanquake commented on pull request "depends: fix compiling bdb with clang-16 on aarch64":
(https://github.com/bitcoin/bitcoin/pull/27462#issuecomment-1514514571)
@theuni Thanks for following up. Hopefully we'll be able to avoid the route of having to do even more invasive patching.

💬 fanquake commented on pull request "p2p: update hardcoded mainnet seeds for 25.x":
(https://github.com/bitcoin/bitcoin/pull/27488#issuecomment-1514526711)
cc @wiz

🚀 fanquake merged a pull request: "depends: Remove `_LIBCPP_DEBUG` from depends DEBUG mode"
(https://github.com/bitcoin/bitcoin/pull/27447)

👋 fanquake's pull request is ready for review: "ci: build libc++ in DEBUG mode in MSAN jobs"
(https://github.com/bitcoin/bitcoin/pull/27448)

💬 fanquake commented on pull request "ci: build libc++ in DEBUG mode in MSAN jobs":
(https://github.com/bitcoin/bitcoin/pull/27448#issuecomment-1514531348)
Rebased post #27447.

💬 ryanofsky commented on pull request "refactor: Move chain constants to the util library":
(https://github.com/bitcoin/bitcoin/pull/27491#discussion_r1171175379)
In commit "refactor: Replace string chain name constants with ChainTypes" (5589a4b0dd5b25017299f666127b7537f5f7a4c1)

Maybe replace `const ChainType&` with `ChainType` everywhere since it's an enum and probably more efficient to pass by value instead of by reference

💬 MarcoFalke commented on pull request "ci: build libc++ in DEBUG mode in MSAN jobs":
(https://github.com/bitcoin/bitcoin/pull/27448#issuecomment-1514559389)
is DEBUG=1 enabled for them as well in depends?

💬 MarcoFalke commented on issue "Feature request: alert PR author in case of CI failure":
(https://github.com/bitcoin/bitcoin/issues/27178#issuecomment-1514674473)
Ok, I found a hacky way to implement this:

GitHub check_suite event -> list check runs via GitHub API -> call cirrus CI API to get the task's build's pullRequest :smiling_face_with_tear:


Let me know if there are any bugs, questions or feature requests. Other than that, I think this can be closed?

💬 jonatack commented on pull request "p2p: update hardcoded mainnet seeds for 25.x":
(https://github.com/bitcoin/bitcoin/pull/27488#issuecomment-1514683900)
Pushed an update that adds seeds from @Wiz and colleagues. I was having issues connecting to some of them yesterday, but infra is being updated, and I was able to connect to all of them now.

✅ stickies-v closed an issue: "Feature request: alert PR author in case of CI failure"
(https://github.com/bitcoin/bitcoin/issues/27178)

💬 stickies-v commented on issue "Feature request: alert PR author in case of CI failure":
(https://github.com/bitcoin/bitcoin/issues/27178#issuecomment-1514706017)
Nice! Thank you for adding this to Drahtbot. Looks good, just looked at a PR with a recent CI failure and seeing this:

<img width="329" alt="image" src="https://user-images.githubusercontent.com/69010457/233084088-76c05ac7-6e0a-4da1-b3ec-cb1efe82a945.png">

Don't think this needs anything more - closing.

⚠️ fanquake opened an issue: "ci: failure in Docker build step"
(https://github.com/bitcoin/bitcoin/issues/27492)
Failure here: https://cirrus-ci.com/task/4581145136857088 in #27479. Does this just need a rebase? cc @MarcoFalke
```bash
docker build --tag gcr.io/cirrus-ci-community/bitcoin/bitcoin/ci/test_imagefile:d050f5b1ebc8c0ebdf779e9eda85ea03bfd0fca46391a14e57fbe478652e6623 --file ci/test_imagefile --build-arg CI_IMAGE_NAME_TAG="ubuntu:focal" --build-arg FILE_ENV="./ci/test/00_setup_env_native_nowallet_libbitcoinkernel.sh" ${CIRRUS_DOCKER_CONTEXT:-$CIRRUS_WORKING_DIR}
Sending build context to Docker
...

💬 MarcoFalke commented on issue "ci: failure in Docker build step":
(https://github.com/bitcoin/bitcoin/issues/27492#issuecomment-1514723930)
I guess the `Prebuild` task needs to run after the `merge_base` step, or similar.

💬 MarcoFalke commented on issue "ci: failure in Docker build step":
(https://github.com/bitcoin/bitcoin/issues/27492#issuecomment-1514729331)
Not sure how to easily run a step before the build.

Ideally this is something fixed by upstream, see:

* https://github.com/cirruslabs/cirrus-ci-docs/issues/791
* https://github.com/cirruslabs/cirrus-ci-docs/discussions/1110
* ...

💬 hebasto commented on issue "Replace all of the RecursiveMutex instances with the Mutex ones":
(https://github.com/bitcoin/bitcoin/issues/19303#issuecomment-1514746298)
> You should be able to see it in the tsan CI task or with libc++ locally?

The TSan CI job is pretty stable @ 760651214cd205b91804bc1c40a31c614d3aa26c, and removing the `deadlock:Chainstate::ConnectTip` suppression does not cause any failure.

My guess is that this is a byproduct of clang upgrade.

💬 MarcoFalke commented on pull request "Allow configuring target block time for a signet":
(https://github.com/bitcoin/bitcoin/pull/27446#issuecomment-1514785618)
I guess one can pass all non-default consensus args to a hasher and use that as the network magic, and also use the network magic as the suffix for the signet folder name.

This would also allow to make more consensus args configurable as a non-breaking change in the future. Though, obviously it would be a breaking change now.

💬 pinheadmz commented on issue "Compiling a bitcoin core version that accepts transactions over 100vkb":
(https://github.com/bitcoin/bitcoin/issues/27490#issuecomment-1514785947)
The max standard tx size is defined in this line in `policy.h`:

https://github.com/bitcoin/bitcoin/blob/d908877c4774c2456eed09167a5f382758e4a8a6/src/policy/policy.h#L26-L27

Since there are no configuration options node operators can use to change this value, it's reasonable to assume that most if not all Bitcoin Core nodes on the network enforce it. Therefore, even if you were to alter your own software to accept heavier transactions, they would likely not get relayed to any of your peers.
...