📝 Christewart opened a pull request: "docs: Add instructions on how to self-sign bitcoin-core binaries for macOS"
(https://github.com/bitcoin/bitcoin/pull/30982)
Related to #15774

This PR adds instructions to the release notes to tell users how to self sign bitcoin core binaries so they are exectuable on macOS.

Tested on
```
Darwin Chriss-MacBook-Pro.local 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:46 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6031 arm64
```

These commands do not appear to require 'phoning home'. I tested these commands when disconnected from a network connection and things worked.

💬 marcofleon commented on pull request "fuzz: fix bug in p2p_headers_presync harness":
(https://github.com/bitcoin/bitcoin/pull/30980#issuecomment-2377309305)
Can be tested by running `FUZZ=p2p_headers_presync ./fuzzbuild/src/test/fuzz/fuzz chainwork_crash.txt`

Should fail on master:
```
Assertion failed: (total_work < chainman.MinimumChainWork()), function p2p_headers_presync_fuzz_target, file p2p_headers_presync.cpp, line 207.
```

and pass on this PR.

[chainwork_crash.txt](https://github.com/user-attachments/files/17151589/chainwork_crash.txt)

✅ fanquake closed an issue: "Intermittent failure in p2p_1p1c_network.py", line 58, in raise_network_minfee assert_greater_than(node.getmempoolinfo()['mempoolminfee'], FEERATE_1SAT_VB) ; AssertionError: 0.00001000 <= 0.00001000"
(https://github.com/bitcoin/bitcoin/issues/30922)

🚀 fanquake merged a pull request: "test: Add missing sync_mempools() to fill_mempool()"
(https://github.com/bitcoin/bitcoin/pull/30948)

👍 hebasto approved a pull request: "ci: add timestamps to cirrus jobs"
(https://github.com/bitcoin/bitcoin/pull/30981#pullrequestreview-2331694004)
ACK f951f1fab258f782a88bb006b5ae4ea486705388.

💬 Sjors commented on pull request "guix: add multiprocess binaries":
(https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2377322427)
I moved the Windows build skip workaround from Guix to depends. This made me excited about the prospect of moving that bit of Autotools stuff to CMake as well. :-)

Made some minimal documentation changes.

I didn't change the non-depends build (yet).

All CI instances that use depends now use multiprocess, the others don't (yet). Let's see if that breaks anything...

💬 maflcko commented on pull request "docs: Add instructions on how to self-sign bitcoin-core binaries for macOS":
(https://github.com/bitcoin/bitcoin/pull/30982#discussion_r1777335510)
I think you'd want to edit the template `doc/release-notes-empty-template.md`, because snippets are deleted.

Also, wasn't the point that this no longer works on macOS Sequoia? Would be nice to test it there.

💬 Christewart commented on pull request "docs: Add instructions on how to self-sign bitcoin-core binaries for macOS":
(https://github.com/bitcoin/bitcoin/pull/30982#discussion_r1777350229)
Moved to `releae-notes-empty-template.md`

Idk about Sequoia, that OS appears to have shipped 10 days ago. I think its safe to assume the majority of our macOS users will be encountering this issue when trying to use 28.0 (and older versions of bitcoin core).

🚀 fanquake merged a pull request: "ci: add timestamps to cirrus jobs"
(https://github.com/bitcoin/bitcoin/pull/30981)

💬 maflcko commented on pull request "refactor: Replace g_genesis_wait_cv with m_tip_block_cv":
(https://github.com/bitcoin/bitcoin/pull/30967#discussion_r1777377093)
> I think Cory's suggestion could be implemented here with:

Thanks, pushed the diff as a new commit on top, with added clang-threadsafety annotations.

👍 vasild approved a pull request: "net: Replace libnatpmp with built-in PCP+NATPMP implementation"
(https://github.com/bitcoin/bitcoin/pull/30043#pullrequestreview-2331760053)
ACK 6c89fab9fddb8952ed2ba13048cd87856a2f9397 (modulo squashing the fixup commit)

Thank you!

👍 vasild approved a pull request: "tracing: Only prepare tracepoint arguments when actually tracing"
(https://github.com/bitcoin/bitcoin/pull/26593#pullrequestreview-2331783391)
ACK 8a5b224fb11fdaa84265aa6d082d6f5e0ed97336

💬 willcl-ark commented on pull request "docs: Add instructions on how to self-sign bitcoin-core binaries for macOS":
(https://github.com/bitcoin/bitcoin/pull/30982#issuecomment-2377407901)
I think it might be good to also include instructions for signing a downloaded `Bitcoin-Qt.app`, as I would think that might be what a lot (majority?) of MacOS users are downloading.

💬 vasild commented on issue "V2 Only Option":
(https://github.com/bitcoin/bitcoin/issues/29618#issuecomment-2377409973)
> > Any v2only option should apply only to IPv4 and IPv6 peers, but not to Tor ...

> Tor entry and exit nodes would see v1 traffic in the clear

@tdb3, there are no exit nodes involved when accessing `*.onion` peers. This is what I mean by "Tor peers", not IPv4 peers accessed via the Tor network, involving exit nodes and part of the route is through clearnet.

The Tor entry node is usually on localhost.

💬 ffrediani commented on issue "Add IPv6 pinhole support using UPnP / NAT-PMP":
(https://github.com/bitcoin/bitcoin/issues/17012#issuecomment-2377417708)
Great to see this was catch up.

IPv6 is present on majority of big and medium size Broadband Providers, with some countries having over 50% of IPv6 connectivity and this can contribute significantly to network performance and robustness allowing more nodes to contribute back by accepting incoming connections from other nodes. Bitnodes.org reports over 7400 nodes with IPv6 connectivity and this can help to enhance that greatly.

Most users that run home nodes don't have more advanced technic
...

💬 Christewart commented on pull request "docs: Add instructions on how to self-sign bitcoin-core binaries for macOS":
(https://github.com/bitcoin/bitcoin/pull/30982#issuecomment-2377431582)
> I think it might be good to also include instructions for signing a downloaded `Bitcoin-Qt.app`, as I would think that might be what a lot (majority?) of MacOS users are downloading.

I presume this is the GUI? I'm not sure if assuming command line literacy makes sense for that.

💬 willcl-ark commented on pull request "docs: Add instructions on how to self-sign bitcoin-core binaries for macOS":
(https://github.com/bitcoin/bitcoin/pull/30982#issuecomment-2377438048)
> > I think it might be good to also include instructions for signing a downloaded `Bitcoin-Qt.app`, as I would think that might be what a lot (majority?) of MacOS users are downloading.
>
> I presume this is the GUI? I'm not sure if assuming command line literacy makes sense for that.

Well, as the app does not work at all on macOS without that it seems better to me to at least provide the required steps, rather than nothing at all?

💬 marcofleon commented on issue "Test p2p_headers_presync fuzz target on macOS/Windows":
(https://github.com/bitcoin/bitcoin/issues/30950#issuecomment-2377443531)
Is that better than adding `-x p2p_headers_presync` to the Windows and macOS test runner calls in the CI?

Using the exclude flag, as opposed to altering the harness, feels cleaner to me. Afaik they would both accomplish the same thing, so ultimately I'm okay with either.

💬 vasild commented on pull request "net: option to disallow v1 connection on ipv4 and ipv6 peers":
(https://github.com/bitcoin/bitcoin/pull/30951#issuecomment-2377448170)
In https://github.com/bitcoin/bitcoin/issues/29618 and here, I don't see the motivation to forbid v1 connections. In other words, what is the purpose of this?

In addition to the concerns expressed in https://github.com/bitcoin/bitcoin/issues/29618, there is one more - if V2-only is widespread, it may be hard to eclipse V2-only node, but then it becomes easy to eclipse a V1 node which has a problem of finding peers to connect to, so an attacker starts a lot of nodes that do accept V1 connectio
...

💬 TheCharlatan commented on pull request "kernel: Move block tree db open to block manager":
(https://github.com/bitcoin/bitcoin/pull/30965#discussion_r1777432701)
The previous loop this refers to is the initialization retry loop that I am getting rid of in #30968.