💬 maflcko commented on issue "win64-cross CI timeout after 2h in allocator_tests":
(https://github.com/bitcoin/bitcoin/issues/30969#issuecomment-2377098663)
https://cirrus-ci.com/task/4822998216081408?logs=ci#L2609

So I guess it is not allocator tests.

Maybe a wine issue?

📝 willcl-ark opened a pull request: "ci: add timestamps to cirrus jobs"
(https://github.com/bitcoin/bitcoin/pull/30981)
Currently, debugging where time is spent in the cirrus jobs feels annoying, e.g. trying to see where time may be spent in https://github.com/bitcoin/bitcoin/issues/30969

Enable timestamps in the logs for more information.

💬 willcl-ark commented on issue "win64-cross CI timeout after 2h ":
(https://github.com/bitcoin/bitcoin/issues/30969#issuecomment-2377147030)
I opened https://github.com/bitcoin/bitcoin/pull/30981 to enable cirrus log timestamps. They may help in shedding some more light on where these timeout jobs are spending time, although in this case it seems to be a deeper bug...

💬 maflcko commented on pull request "ci: add timestamps to cirrus jobs":
(https://github.com/bitcoin/bitcoin/pull/30981#issuecomment-2377165712)
review ACK f951f1fab258f782a88bb006b5ae4ea486705388

It may be a bit annoying when looking at functional test failures, which have a timestamp included and would then get a "wrong" timestamp, but this seems fine .

💬 sipa commented on pull request "Cluster linearization: separate tests from tests-of-tests":
(https://github.com/bitcoin/bitcoin/pull/30605#discussion_r1777269039)
I've improved the comments a bit.

👍 tdb3 approved a pull request: "ci: add timestamps to cirrus jobs"
(https://github.com/bitcoin/bitcoin/pull/30981#pullrequestreview-2331638443)
Code Review ACK f951f1fab258f782a88bb006b5ae4ea486705388
There are a few times I've wished these timestamps were present.

```
[14:35:19.384] 127/137 Test #132: wallet_crypto_tests .................. Passed 2.48 sec
[14:35:19.385] Start 137: db_tests
[14:35:19.572] 128/137 Test #137: db_tests ............................. Passed 0.19 sec
[14:35:19.993] 129/137 Test #131: spend_tests .......................... Passed 3.13 sec
[14:35:20.153] 130/137 Test #31: coins_
...

💬 marcofleon commented on pull request "test: Add missing sync_mempools() to fill_mempool()":
(https://github.com/bitcoin/bitcoin/pull/30948#issuecomment-2377284536)
Tested ACK faf801515f8fcd11a3454105cab66c38f6f240fe.

🤔 marcofleon reviewed a pull request: "test: Add missing sync_mempools() to fill_mempool()"
(https://github.com/bitcoin/bitcoin/pull/30948#pullrequestreview-2331663285)
Tested ACK faf801515f8fcd11a3454105cab66c38f6f240fe

Saw `AssertionError: 0.00001000 <= 0.00001000` on master.

On this branch:

```
TEST | STATUS | DURATION

mempool_limit.py | ✓ Passed | 6 s
mempool_package_rbf.py | ✓ Passed | 24 s
p2p_1p1c_network.py | ✓ Passed | 53 s
p2p_opportunistic_1p1c.py | ✓ Passed | 43 s
p2p_tx_download.py | ✓ Passed | 31 s
rpc_packages.py | ✓ Passed | 4 s

ALL | ✓ Pa
...

📝 Christewart opened a pull request: "docs: Add instructions on how to self-sign bitcoin-core binaries for macOS"
(https://github.com/bitcoin/bitcoin/pull/30982)
Related to #15774

This PR adds instructions to the release notes to tell users how to self sign bitcoin core binaries so they are exectuable on macOS.

Tested on
```
Darwin Chriss-MacBook-Pro.local 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:46 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6031 arm64
```

These commands do not appear to require 'phoning home'. I tested these commands when disconnected from a network connection and things worked.

💬 marcofleon commented on pull request "fuzz: fix bug in p2p_headers_presync harness":
(https://github.com/bitcoin/bitcoin/pull/30980#issuecomment-2377309305)
Can be tested by running `FUZZ=p2p_headers_presync ./fuzzbuild/src/test/fuzz/fuzz chainwork_crash.txt`

Should fail on master:
```
Assertion failed: (total_work < chainman.MinimumChainWork()), function p2p_headers_presync_fuzz_target, file p2p_headers_presync.cpp, line 207.
```

and pass on this PR.

[chainwork_crash.txt](https://github.com/user-attachments/files/17151589/chainwork_crash.txt)

✅ fanquake closed an issue: "Intermittent failure in p2p_1p1c_network.py", line 58, in raise_network_minfee assert_greater_than(node.getmempoolinfo()['mempoolminfee'], FEERATE_1SAT_VB) ; AssertionError: 0.00001000 <= 0.00001000"
(https://github.com/bitcoin/bitcoin/issues/30922)

🚀 fanquake merged a pull request: "test: Add missing sync_mempools() to fill_mempool()"
(https://github.com/bitcoin/bitcoin/pull/30948)

👍 hebasto approved a pull request: "ci: add timestamps to cirrus jobs"
(https://github.com/bitcoin/bitcoin/pull/30981#pullrequestreview-2331694004)
ACK f951f1fab258f782a88bb006b5ae4ea486705388.

💬 Sjors commented on pull request "guix: add multiprocess binaries":
(https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2377322427)
I moved the Windows build skip workaround from Guix to depends. This made me excited about the prospect of moving that bit of Autotools stuff to CMake as well. :-)

Made some minimal documentation changes.

I didn't change the non-depends build (yet).

All CI instances that use depends now use multiprocess, the others don't (yet). Let's see if that breaks anything...

💬 maflcko commented on pull request "docs: Add instructions on how to self-sign bitcoin-core binaries for macOS":
(https://github.com/bitcoin/bitcoin/pull/30982#discussion_r1777335510)
I think you'd want to edit the template `doc/release-notes-empty-template.md`, because snippets are deleted.

Also, wasn't the point that this no longer works on macOS Sequoia? Would be nice to test it there.

💬 Christewart commented on pull request "docs: Add instructions on how to self-sign bitcoin-core binaries for macOS":
(https://github.com/bitcoin/bitcoin/pull/30982#discussion_r1777350229)
Moved to `releae-notes-empty-template.md`

Idk about Sequoia, that OS appears to have shipped 10 days ago. I think its safe to assume the majority of our macOS users will be encountering this issue when trying to use 28.0 (and older versions of bitcoin core).

🚀 fanquake merged a pull request: "ci: add timestamps to cirrus jobs"
(https://github.com/bitcoin/bitcoin/pull/30981)

💬 maflcko commented on pull request "refactor: Replace g_genesis_wait_cv with m_tip_block_cv":
(https://github.com/bitcoin/bitcoin/pull/30967#discussion_r1777377093)
> I think Cory's suggestion could be implemented here with:

Thanks, pushed the diff as a new commit on top, with added clang-threadsafety annotations.

👍 vasild approved a pull request: "net: Replace libnatpmp with built-in PCP+NATPMP implementation"
(https://github.com/bitcoin/bitcoin/pull/30043#pullrequestreview-2331760053)
ACK 6c89fab9fddb8952ed2ba13048cd87856a2f9397 (modulo squashing the fixup commit)

Thank you!

👍 vasild approved a pull request: "tracing: Only prepare tracepoint arguments when actually tracing"
(https://github.com/bitcoin/bitcoin/pull/26593#pullrequestreview-2331783391)
ACK 8a5b224fb11fdaa84265aa6d082d6f5e0ed97336