💬 tdb3 commented on issue "Intermittent failure in p2p_1p1c_network.py", line 58, in raise_network_minfee assert_greater_than(node.getmempoolinfo()['mempoolminfee'], FEERATE_1SAT_VB) ; AssertionError: 0.00001000 <= 0.00001000":
(https://github.com/bitcoin/bitcoin/issues/30922#issuecomment-2366936790)
Encountered this in PR #30946 as well.

```
test 2024-09-22T19:16:03.915000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/Users/runner/work/bitcoin/bitcoin/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()
File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build-aarch64
...

💬 fjahr commented on pull request "doc: correct the zmq automatic build info":
(https://github.com/bitcoin/bitcoin/pull/30946#issuecomment-2366958861)
ACK 858bb0c5285cb713bb1de056135d1331c17c35a9

💬 beage666 commented on pull request "test: Remove dead code from interface_zmq test":
(https://github.com/bitcoin/bitcoin/pull/30942#discussion_r1770637021)
Next update

💬 instagibbs commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1770637906)
> I don't understand how 0 tests failed, though 😬 gotta look into that

yeah was a bit worrying to me too... glad we can add unit tests in this PR!

💬 kegdeg commented on issue "rpc auth fails 'Error parsing command line arguments: Invalid parameter -rpcpasssword=password":
(https://github.com/bitcoin/bitcoin/issues/30939#issuecomment-2366973982)
yes, that solved it, thanks!

✅ kegdeg closed an issue: "rpc auth fails 'Error parsing command line arguments: Invalid parameter -rpcpasssword=password"
(https://github.com/bitcoin/bitcoin/issues/30939)

💬 kegdeg commented on issue "rpc auth fails 'Error parsing command line arguments: Invalid parameter -rpcpasssword=password":
(https://github.com/bitcoin/bitcoin/issues/30939#issuecomment-2366974641)
-datadir specified, must use bitcoin.conf in datadir

💬 paulmaleauxney commented on issue "Improve description of the `filename` parameter of `loadwallet` RPC":
(https://github.com/bitcoin/bitcoin/issues/30269#issuecomment-2367076019)
@murchandamus if this is still open I can work in it. Please let me know.

💬 BenWestgate commented on pull request "Drop -dbcache limit":
(https://github.com/bitcoin/bitcoin/pull/28358#issuecomment-2367264753)
Didn’t #28280 resolve this?

On Fri, Sep 20, 2024 at 05:16, l0rinc ***@***.***(mailto:On Fri, Sep 20, 2024 at 05:16, l0rinc <<a href=)> wrote:

> Unsurprisingly (should we document this?), setting -prune makes the -dbcache value less important:
>
> benchmark
>
> // 6d7f24595b08b8d1eba53e648533bcf87c30b48f
> hyperfine \
> --runs 2 \
> --export-json /mnt/ibd_dbcache_prune.json \
> --parameter-list DBCACHE 10240,16384,20480,30720,40960 \
> --prepare
>
> '
>
> rm -rf /mnt/BitcoinData/*
>
> '
>
> \
>
...

⚠️ Sjors opened an issue: "Warn about / refuse unsupported clang version"
(https://github.com/bitcoin/bitcoin/issues/30947)
On an older Intel macOS 13.7 machine:

```
cmake -B build
-- The CXX compiler identification is AppleClang 14.0.3.14030022

...

cmake --build build -j7

...

In file included from /Users/sjors/dev/bitcoin/src/crypto/muhash.h:9:
/Users/sjors/dev/bitcoin/src/uint256.h:133:19: error: call to consteval function 'util::ConstevalHexDigit' is not a constant expression
auto lo = util::ConstevalHexDigit(*(str_it++));
^

(etc)
```

Our minimum required clang
...

💬 Sjors commented on issue "Warn about / refuse unsupported clang version":
(https://github.com/bitcoin/bitcoin/issues/30947#issuecomment-2367467444)
The documentation says "For macOS 11 (Big Sur) and 12 (Monterey) you need to install a more recent version of llvm". That should include macOS 13 and 14 now as well, see https://trac.macports.org/wiki/XcodeVersionInfo#macOS14

But I think as long as cmake warns about llvm being too old, anyone reading `build-osx.md` will probably figure out that they need to install a newer version via llvm.

📝 maflcko opened a pull request: "test: Add missing sync_mempools() to fill_mempool()"
(https://github.com/bitcoin/bitcoin/pull/30948)
Not doing the sync will lead to (intermittent) issues, as explained in https://github.com/bitcoin/bitcoin/issues/30922#issuecomment-2364529013.

Fix all issues by doing the sync by default.

However, the sync isn't needed in all places, or it could slow down the test. So disable it, or set `noban_tx_relay` to offset the added cost.

📝 Sjors opened a pull request: "doc: macOS 15 ships llvm 16"
(https://github.com/bitcoin/bitcoin/pull/30949)
#30263 bumped the minimum clang to 16

macOS versions before 15 ship older versions, see https://en.wikipedia.org/wiki/Xcode#Xcode_15.0_-_(since_visionOS_support)

Updating macOS build instructions to reflect this.

💬 maflcko commented on pull request "doc: macOS 15 ships llvm 16":
(https://github.com/bitcoin/bitcoin/pull/30949#issuecomment-2367502905)
Are you sure?

CI checks for this and passes, so you'll have to explain why CI didn't fail. Ideally, with exact steps to reproduce. Otherwise, it will be hard to follow.

Also, keep in mind that the "Clang version string" inside XCode is completely made up by Apple. It does not correspond to the llvm versioning.

💬 maflcko commented on pull request "test: Add missing sync_mempools() to fill_mempool()":
(https://github.com/bitcoin/bitcoin/pull/30948#issuecomment-2367507024)
Can be tested via the following diff, which should fail on master and pass on this pull request:

```diff
diff --git a/test/functional/p2p_1p1c_network.py b/test/functional/p2p_1p1c_network.py
index f9e782f524..5ea6add9ab 100755
--- a/test/functional/p2p_1p1c_network.py
+++ b/test/functional/p2p_1p1c_network.py
@@ -39,7 +39,7 @@ class PackageRelayTest(BitcoinTestFramework):
self.setup_clean_chain = True
self.num_nodes = 4
# hugely speeds up the test, as it in
...

💬 maflcko commented on issue "Intermittent failure in p2p_1p1c_network.py", line 58, in raise_network_minfee assert_greater_than(node.getmempoolinfo()['mempoolminfee'], FEERATE_1SAT_VB) ; AssertionError: 0.00001000 <= 0.00001000":
(https://github.com/bitcoin/bitcoin/issues/30922#issuecomment-2367521476)
Thanks @mzumsande for the detailed analysis and suggested fix. I've submitted it as https://github.com/bitcoin/bitcoin/pull/30948 to address the intermittent failure sooner rather than later. I hope it is fine.

💬 fanquake commented on pull request "doc: macOS 15 ships llvm 16":
(https://github.com/bitcoin/bitcoin/pull/30949#issuecomment-2367536842)
Yea, this isn't correct. The Apple Clang that is installable with macOS 14.x work perfectly fine. No need to install a different LLVM toolchain.

💬 maflcko commented on issue "Warn about / refuse unsupported clang version":
(https://github.com/bitcoin/bitcoin/issues/30947#issuecomment-2367541261)
There is no need to use brew to install clang/llvm. You can just pick the newer XCode: `sudo xcode-select --switch /Applications/Xcode_15.0.app`

You may have to upgrade to macOS 13.5 (or later), according to the release notes.

💬 fanquake commented on issue "Warn about / refuse unsupported clang version":
(https://github.com/bitcoin/bitcoin/issues/30947#issuecomment-2367541499)
> It would be good if cmake -B build checks the minimum version

We don't check compiler versions, we check for C++ compatibility (i.e `CMAKE_CXX_STANDARD`, `CMAKE_CXX_STANDARD_REQUIRED`, `CMAKE_CXX_EXTENSIONS`). If CMakes `CMAKE_CXX_STANDARD` check is incorrectly passing, when a compiler doesn't actually support C++20, we should file a bug upstream, so they can expand the checks they perform.

💬 hebasto commented on pull request "doc: macOS 15 ships llvm 16":
(https://github.com/bitcoin/bitcoin/pull/30949#issuecomment-2367594534)
https://en.wikipedia.org/wiki/Xcode#Toolchain_versions shows that Apple clang version 15.0.0 (clang-1500.0.40.1) used in the CI is based on LLVM 16.0.0.