💬 fanquake commented on pull request "kernel: chainparams updates for 25.x":
(https://github.com/bitcoin/bitcoin/pull/27482#discussion_r1170070814)
It will also be much deeper once 25.x is actually released.

💬 furszy commented on pull request "wallet: improve IBD sync time by skipping block scanning prior birth time":
(https://github.com/bitcoin/bitcoin/pull/27469#discussion_r1170076066)
Because the other one is a return statement (the flow breaks there) while this one is a setter.
Plus, when the line is too long, like this one, I think that braces help readability.

👍 hebasto approved a pull request: "[24.x] Additional backports for 24.1"
(https://github.com/bitcoin/bitcoin/pull/27474#pullrequestreview-1390181803)
re-ACK dc711fbd32653b09e196f72942106114a32353f4

💬 achow101 commented on pull request "doc: remove outdated version number usage from release-process":
(https://github.com/bitcoin/bitcoin/pull/27484#issuecomment-1513205003)
ACK fde224a6610699a6a28cc27e299ac14cbf7e16ca

🚀 achow101 merged a pull request: "doc: remove outdated version number usage from release-process"
(https://github.com/bitcoin/bitcoin/pull/27484)

💬 furszy commented on pull request "wallet: improve IBD sync time by skipping block scanning prior birth time":
(https://github.com/bitcoin/bitcoin/pull/27469#discussion_r1170086188)
yes. `BLANK_BIRTH_TIME` is for blank wallets. Blank wallets are wallets with no keys (no spkm exist). So it's ok to skip blocks as the wallet isn't going to find anything on them.

🤔 jonatack reviewed a pull request: "[24.x] Additional backports for 24.1"
(https://github.com/bitcoin/bitcoin/pull/27474#pullrequestreview-1390197262)
ACK dc711fbd32653b09e196f72942106114a32353f4

Pull description is missing some of the changes.

💬 0xB10C commented on pull request "kernel: chainparams updates for 25.x":
(https://github.com/bitcoin/bitcoin/pull/27482#discussion_r1170091153)
Getting 502 GB in `blocks/` and 5.1GB in `chainstate/`. The new values seem fine as they should include enough overhead.

💬 furszy commented on pull request "wallet: improve IBD sync time by skipping block scanning prior birth time":
(https://github.com/bitcoin/bitcoin/pull/27469#discussion_r1170098672)
The id is the db lookup key for the descriptor, and also a way to detect db corruption.

We could clean it up from here, yeah. And probably, depending on its usage, we should also think about caching it.

💬 furszy commented on pull request "wallet: improve IBD sync time by skipping block scanning prior birth time":
(https://github.com/bitcoin/bitcoin/pull/27469#discussion_r1170124551)
sure, pushed.

💬 furszy commented on pull request "wallet: improve IBD sync time by skipping block scanning prior birth time":
(https://github.com/bitcoin/bitcoin/pull/27469#discussion_r1170124375)
Ended up re-adding the id arg. So we don't calculate the spkm id twice.

💬 jonatack commented on pull request "Remove Sock::Get() and Sock::Sock()":
(https://github.com/bitcoin/bitcoin/pull/26312#issuecomment-1513266130)
This is the last part of parent https://github.com/bitcoin/bitcoin/pull/21878 opened 2 years ago, anyone else like to have a look?

💬 TheCharlatan commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1513251515)
Thank you for the review @mzumsande

Updated 97bf70119e5b8567bcdc553d59b18a09023fd05a -> 09f950e1f3608e3019e97236969b152e9252a220 ([removeBlockstorageArgs_11](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_11) -> [removeBlockstorageArgs_12](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_12), [compare](https://github.com/TheCharlatan/bitcoin/compare/removeBlockstorageArgs_11..removeBlockstorageArgs_12))
* Addressed @mzumsande's [comment](https://githu
...

💬 fanquake commented on pull request "[WIP] ci: standardize custom libc++ usage in MSAN jobs":
(https://github.com/bitcoin/bitcoin/pull/27485#issuecomment-1513258618)
We can likely do something similar for our Darwin depends build, once we're using a newer version of LLVM/Clang, might might make the flag usage and configuration in there slightly clearer.

💬 achow101 commented on pull request "kernel: chainparams updates for 25.x":
(https://github.com/bitcoin/bitcoin/pull/27482#issuecomment-1513267552)
ACK a2bef805c11a4ab391f4ea635bfde7dd2ec9ce81

✅ fanquake closed a pull request: "[24.x] Additional backports for 24.1"
(https://github.com/bitcoin/bitcoin/pull/27474)

💬 furszy commented on pull request "wallet: improve IBD sync time by skipping block scanning prior birth time":
(https://github.com/bitcoin/bitcoin/pull/27469#issuecomment-1513272159)
> Also I don't know if this is a problematic edge case or it could just be a good way to test but you could create a key and send BTC to it in a block, then a few blocks later import into a new descriptor and rescan. The wallet should miss the first transaction.

This PR is not modifying the rescan process. Only IBD.
Guess that you provided a timestamp that is +2 hours ahead of the block time (network time variability window) or the "now" arg to skip rescan?

💬 MarcoFalke commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1513279467)
Needs rebase on current `main` branch

💬 fanquake commented on pull request "[24.x] Additional backports for 24.1":
(https://github.com/bitcoin/bitcoin/pull/27474#issuecomment-1513264611)
This has been merged.

💬 jonatack commented on pull request "Make it possible to disable Tor binds and abort startup on bind failure":
(https://github.com/bitcoin/bitcoin/pull/22729#issuecomment-1513288273)
Concept ACK