✅ maflcko closed a pull request: "Bitcoil Project"
(https://github.com/bitcoin/bitcoin/pull/30914)

📝 hebasto opened a pull request: "ci: Use `ninja` to build in macOS native CI job"
(https://github.com/bitcoin/bitcoin/pull/30915)
Addresses [this](https://github.com/bitcoin/bitcoin/pull/30911#issuecomment-2354922939) comment:
> I wonder if one CI task should be using Ninja (and cmake >= 3.27), if it isn't too hard to implement. Otherwise this config will remain untested and errors may sneak in to the master branch, only being detected after merge.

Draft for now, as it is based on https://github.com/bitcoin/bitcoin/pull/30913 and conflicts with https://github.com/bitcoin/bitcoin/pull/30902.

💬 hebasto commented on pull request "build: speed up by flattening the dependency graph":
(https://github.com/bitcoin/bitcoin/pull/30911#issuecomment-2355556173)
> > ... though currently only Ninja benefits from this being set, and only CMake >= 3.27 understands it.
>
> I wonder if one CI task should be using Ninja (and cmake >= 3.27), if it isn't too hard to implement. Otherwise this config will remain untested and errors may sneak in to the master branch, only being detected after merge.

Please consider https://github.com/bitcoin/bitcoin/pull/30915.

📝 fanquake locked a pull request: "Bitcoil Project"
(https://github.com/bitcoin/bitcoin/pull/30914)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

📝 MichaelXCity opened a pull request: "Bitcoil project"
(https://github.com/bitcoin/bitcoin/pull/30916)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ MichaelXCity closed a pull request: "Bitcoil project"
(https://github.com/bitcoin/bitcoin/pull/30916)

📝 fanquake locked a pull request: "Bitcoil project"
(https://github.com/bitcoin/bitcoin/pull/30916)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 fanquake commented on pull request "ci: Use clang-19 in msan tasks":
(https://github.com/bitcoin/bitcoin/pull/30639#issuecomment-2355588809)
19.1.0 is now available: https://github.com/llvm/llvm-project/releases/tag/llvmorg-19.1.0.

💬 brunoerg commented on pull request "doc: update Eclipser fuzzing documentation":
(https://github.com/bitcoin/bitcoin/pull/30908#issuecomment-2355624193)
> I think we could even remove eclipser from the docs entirely. As you noted as well, it looks unmaintained and I don't think any of us are actively using it.

Agreed.

💬 fjahr commented on pull request "doc: update NeedsRedownload() and nStatus comment":
(https://github.com/bitcoin/bitcoin/pull/29624#issuecomment-2355678474)
ACK af9f9878934f88036423021c70ef523b6c9e1c90

💬 hebasto commented on pull request "cmake: Switch to crc32c upstream build system":
(https://github.com/bitcoin/bitcoin/pull/30905#issuecomment-2355688236)
> This PR is also changing the flags used for code generation.

Yes. The `crc32c` upstream build system modifies flags in many places, for [example](https://github.com/bitcoin-core/crc32c-subtree/blob/efb8ea04e4a5b6a18dc4bc1908fd1cb2dcefb585/CMakeLists.txt#L58-L64):
```cmake
# Disable C++ exceptions.
string(REGEX REPLACE "-fexceptions" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions")


# Disable RTTI.
string(REGEX REPLACE "-fr
...

📝 MichaelXCity opened a pull request: "Bitcoil"
(https://github.com/bitcoin/bitcoin/pull/30917)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoil Core user experience or Bitcoil Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ hebasto closed a pull request: "Bitcoil"
(https://github.com/bitcoin/bitcoin/pull/30917)

📝 hebasto locked a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/30917)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoil Core user experience or Bitcoil Core developer experience
significantly:

* Any test improvements or new tests that improv
...

👍 willcl-ark approved a pull request: "ci: Print inner env, Make ccache config more flexible"
(https://github.com/bitcoin/bitcoin/pull/30869#pullrequestreview-2309737230)
ACK fa99e4521b6fc0e7f6636d40bc0d6a7325227374

Making ccache mor configurable in CI seems like a reasonable change overall. Hopefully in the future this could help us if we moved to some more powerful CI runners (with bigger ccache!)

💬 willcl-ark commented on pull request "ci: Print inner env, Make ccache config more flexible":
(https://github.com/bitcoin/bitcoin/pull/30869#discussion_r1763232646)
This does work, but seems to come out a little garbled in the raw logs on CI itself. It didn't happen for me locally and it does not appear to be fault of the script itself, so I guess just GitHub UI processing stdout slowly or something, e.g.

```log
2024-09-16T15:22:03.4198819Z + echo '=== END env ==='
2024-09-16T15:22:03.4199084Z + tee /dev/fd/63
2024-09-16T15:22:03.4199339Z ++ patch -p1
2024-09-16T15:22:03.4199590Z + '[' false = true ']'
2024-09-16T15:22:03.4199872Z + '[' true = true
...

👍 hodlinator approved a pull request: "doc: clarify loadwallet path loading for wallets"
(https://github.com/bitcoin/bitcoin/pull/30302#pullrequestreview-2309767506)
re-ACK b9aded42252969cc81acf4122ca5e2d1e00ecf90

Checked changes since last ACK with `git range-diff master 69bf58d b9aded4`.

- Adjusted commit message to not mention indirect documentation generation.
- Incorporated feedback around .dat-file paths being for legacy wallets.

💬 fjahr commented on pull request "validation: fix m_best_header tracking and BLOCK_FAILED_CHILD assignment":
(https://github.com/bitcoin/bitcoin/pull/30666#issuecomment-2355828054)
> actually, that didn't work because NotifyHeaderTip can't be called when cs_main is held. Reverting this, I'll think about this a bit more.

Is this ready for review or should we wait until you have addressed this @mzumsande ?

💬 willcl-ark commented on issue "Increasing self-hosted runner raw performance":
(https://github.com/bitcoin/bitcoin/issues/30852#issuecomment-2355833959)
> > So I think the best way forward would be to have all workers of the same type on the same machine. (I am still running some performance tests to get an estimate if this make sense at all)

Is this so that re-runs (of the same PR) always hit the cache? If that's it I'm not _totally_ sure it's worth it. My intuition says that if we had multiple servers, even if a re-run took place on a different machine, we'd likely get a *pretty decent* cache hit from another run or a previous master build
...

💬 instagibbs commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#issuecomment-2355865265)
@marcofleon Example checks out, it's pretty simple:
1) txA is called with `txdownload_impl.MempoolRejectedTx` and `TX_RECONSIDERABLE`
2) txA is called with `txdownload_impl.MempoolRejectedTx` and `TX_NOT_STANDARD` or any failure that results in entry to reject filter
3) `ReceivedTx` is called with txA, child is found in orphanage, package returned even though txA is in both filters.