👍 stickies-v approved a pull request: "[28.x] Further backports and rc2"
(https://github.com/bitcoin/bitcoin/pull/30827#pullrequestreview-2309472462)
ACK 06a7df70df30879e0b691d1a252636f703b8cdfb

I verified that all backports are clean, except:
- b329ed739b7311b3b47cae1ef8d576a90e0a36a1 backported from 992f83bb6f4b29b44f4eaace1d1a2c0001d43cac: merge conflict due to a difference in `sha256sum_file` import, trivially resolved

I didn't review each commit in-depth since they're clean, but the changes backported seem sensible.

💬 hebasto commented on pull request "cmake: Revamp handling of data files for `{test,bench}_bitcoin` targets":
(https://github.com/bitcoin/bitcoin/pull/30901#discussion_r1763085593)
Once such a scenario happens, we can use another call:
```cmake
target_data_sources(test_bitcoin
RAW_FILES
data/some_file_with_another_namespace.raw
RAW_NAMESPACE somewhere::another_namespace
)
```
And I think it is better than (1) specifying `data/some_file_with_another_namespace.raw` to generate a header than (2) adding `${CMAKE_CURRENT_BINARY_DIR}/data/some_file_with_another_namespac.raw.h` to the sources.

💬 theStack commented on pull request "refactor: migrate `bool GetCoin` to return `optional<Coin>`":
(https://github.com/bitcoin/bitcoin/pull/30849#issuecomment-2355539328)
Concept ACK

👍 willcl-ark approved a pull request: "ci: Use macos-14 GHA image (x86_64-apple-darwin22.6.0 -> arm64-apple-darwin23.6.0)"
(https://github.com/bitcoin/bitcoin/pull/30913#pullrequestreview-2309566365)
ACK fab932b4211ea0a4c10e484c08042552f9c58c15

📝 MichaelXCity opened a pull request: "Bitcoil Project"
(https://github.com/bitcoin/bitcoin/pull/30914)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ maflcko closed a pull request: "Bitcoil Project"
(https://github.com/bitcoin/bitcoin/pull/30914)

📝 hebasto opened a pull request: "ci: Use `ninja` to build in macOS native CI job"
(https://github.com/bitcoin/bitcoin/pull/30915)
Addresses [this](https://github.com/bitcoin/bitcoin/pull/30911#issuecomment-2354922939) comment:
> I wonder if one CI task should be using Ninja (and cmake >= 3.27), if it isn't too hard to implement. Otherwise this config will remain untested and errors may sneak in to the master branch, only being detected after merge.

Draft for now, as it is based on https://github.com/bitcoin/bitcoin/pull/30913 and conflicts with https://github.com/bitcoin/bitcoin/pull/30902.

💬 hebasto commented on pull request "build: speed up by flattening the dependency graph":
(https://github.com/bitcoin/bitcoin/pull/30911#issuecomment-2355556173)
> > ... though currently only Ninja benefits from this being set, and only CMake >= 3.27 understands it.
>
> I wonder if one CI task should be using Ninja (and cmake >= 3.27), if it isn't too hard to implement. Otherwise this config will remain untested and errors may sneak in to the master branch, only being detected after merge.

Please consider https://github.com/bitcoin/bitcoin/pull/30915.

📝 fanquake locked a pull request: "Bitcoil Project"
(https://github.com/bitcoin/bitcoin/pull/30914)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

📝 MichaelXCity opened a pull request: "Bitcoil project"
(https://github.com/bitcoin/bitcoin/pull/30916)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ MichaelXCity closed a pull request: "Bitcoil project"
(https://github.com/bitcoin/bitcoin/pull/30916)

📝 fanquake locked a pull request: "Bitcoil project"
(https://github.com/bitcoin/bitcoin/pull/30916)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 fanquake commented on pull request "ci: Use clang-19 in msan tasks":
(https://github.com/bitcoin/bitcoin/pull/30639#issuecomment-2355588809)
19.1.0 is now available: https://github.com/llvm/llvm-project/releases/tag/llvmorg-19.1.0.

💬 brunoerg commented on pull request "doc: update Eclipser fuzzing documentation":
(https://github.com/bitcoin/bitcoin/pull/30908#issuecomment-2355624193)
> I think we could even remove eclipser from the docs entirely. As you noted as well, it looks unmaintained and I don't think any of us are actively using it.

Agreed.

💬 fjahr commented on pull request "doc: update NeedsRedownload() and nStatus comment":
(https://github.com/bitcoin/bitcoin/pull/29624#issuecomment-2355678474)
ACK af9f9878934f88036423021c70ef523b6c9e1c90

💬 hebasto commented on pull request "cmake: Switch to crc32c upstream build system":
(https://github.com/bitcoin/bitcoin/pull/30905#issuecomment-2355688236)
> This PR is also changing the flags used for code generation.

Yes. The `crc32c` upstream build system modifies flags in many places, for [example](https://github.com/bitcoin-core/crc32c-subtree/blob/efb8ea04e4a5b6a18dc4bc1908fd1cb2dcefb585/CMakeLists.txt#L58-L64):
```cmake
# Disable C++ exceptions.
string(REGEX REPLACE "-fexceptions" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions")


# Disable RTTI.
string(REGEX REPLACE "-fr
...

📝 MichaelXCity opened a pull request: "Bitcoil"
(https://github.com/bitcoin/bitcoin/pull/30917)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoil Core user experience or Bitcoil Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ hebasto closed a pull request: "Bitcoil"
(https://github.com/bitcoin/bitcoin/pull/30917)

📝 hebasto locked a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/30917)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoil Core user experience or Bitcoil Core developer experience
significantly:

* Any test improvements or new tests that improv
...

👍 willcl-ark approved a pull request: "ci: Print inner env, Make ccache config more flexible"
(https://github.com/bitcoin/bitcoin/pull/30869#pullrequestreview-2309737230)
ACK fa99e4521b6fc0e7f6636d40bc0d6a7325227374

Making ccache mor configurable in CI seems like a reasonable change overall. Hopefully in the future this could help us if we moved to some more powerful CI runners (with bigger ccache!)