💬 ismaelsadeeq commented on issue "Intermittent failure in feature_fee_estimation.py in sanity_check_rbf_estimates: est_feerate = node.estimatesmartfee(2)["feerate"] (KeyError: 'feerate')":
(https://github.com/bitcoin/bitcoin/issues/30640#issuecomment-2351038000)
I read the log from [https://api.cirrus-ci.com/v1/task/5165357323780096/logs/ci.log](https://api.cirrus-ci.com/v1/task/5165357323780096/logs/ci.log) and tried to recreate this intermittent failure.
```
cmake -B build -DWITH_ZMQ=ON -DREDUCE_EXPORTS=ON -DCMAKE_C_FLAGS="-g0 -O2 -funsigned-char" -DCMAKE_CXX_FLAGS="-g0 -O2 -funsigned-char -DBOOST_MULTI_INDEX_ENABLE_SAFE_MODE"
```

I used the seed where the failure occurred was but it passes locally:
<details>
<summary>logs</summary>

```
bu
...

💬 jamesob commented on pull request "rpc: add getdescriptoractivity":
(https://github.com/bitcoin/bitcoin/pull/30708#discussion_r1759630712)
Removed this generate() call.

🤔 jamesob reviewed a pull request: "rpc: add getdescriptoractivity"
(https://github.com/bitcoin/bitcoin/pull/30708#pullrequestreview-2304336437)
I've pushed an update addressing feedback and adding release notes. Thanks for all review so far.

💬 jamesob commented on pull request "rpc: add getdescriptoractivity":
(https://github.com/bitcoin/bitcoin/pull/30708#discussion_r1759630564)
I'm in favor of leaving this in as a convenience to the end user, although I think the suggestion to include a hex-encoded sPK is a good one and I'll add that. Many wallets will ultimately want to show which address is being spent from, e.g.


If we can inexpensively determine that here, I think it's a nice option for the end user.

In terms of a blank string vs. omitted key, I think it's better to h
...

💬 jamesob commented on pull request "rpc: add getdescriptoractivity":
(https://github.com/bitcoin/bitcoin/pull/30708#discussion_r1759640764)
This value is used as an invalid hash elsewhere (https://github.com/bitcoin/bitcoin/blob/master/test/functional/wallet_listsinceblock.py#L95) so I'm going to leave this as is.

💬 jamesob commented on pull request "rpc: add getdescriptoractivity":
(https://github.com/bitcoin/bitcoin/pull/30708#discussion_r1759642418)
I cherry-picked this, but it adds significant runtime to the test for what is a very basic check. I'd suggest filing a follow-up if you're still interested in testing this.

⚠️ johnsqonericgaK opened an issue: "https://github.market : Buy Github Stars, Forks & more over at https://github.market"
(https://github.com/bitcoin/bitcoin/issues/30904)
Boost visibility and ranking of your Github Profile and Repositories with our products over at https://github.market

We sell:
- Github Stars
- Github Forks
- Github Followers
- Github Watchers
- Github Reactions
- Github Upvotes
- Github Comments
- A Github Botting Tool

Our high-quality products come with substantial bulk discounts, ensuring both excellence and cost-effectiveness.

Buy now over at https://github.market

🤔 Shourya742 requested changes to a pull request: "Stratum v2 Noise Protocol"
(https://github.com/bitcoin/bitcoin/pull/29346#pullrequestreview-2291544930)
utACK. This looks good, just a few nits. It closely aligns with the Noise NX standards and the SRI template provider implementation. I will test it soon and share detailed findings.

💬 Shourya742 commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#discussion_r1758221954)
```suggestion
* @returns whether encryption succeeded
```

💬 Shourya742 commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#discussion_r1751379795)
```suggestion
size_t num_chunks = (plain.size() + max_chunk_size - 1) / max_chunk_size;
```

💬 Shourya742 commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#discussion_r1759755153)
```suggestion
size_t chunk_size = NOISE_MAX_CHUNK_SIZE - Poly1305::TAGLEN;
size_t num_chunks = (msg_len + chunk_size - 1) / chunk_size;
return msg_len + (num_chunks * Poly1305::TAGLEN);

```

👋 hebasto's pull request is ready for review: "cmake: Add `FindZeroMQ` module"
(https://github.com/bitcoin/bitcoin/pull/30903)

👋 hebasto's pull request is ready for review: "build: Improve `ccache` performance for different build directories"
(https://github.com/bitcoin/bitcoin/pull/30861)

💬 hebasto commented on pull request "build: Improve `ccache` performance for different build directories":
(https://github.com/bitcoin/bitcoin/pull/30861#issuecomment-2351053745)
The PR has been reworked to keep compatibility with git worktrees. See [this](https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1752076990) discussion.

The PR description has been updated accordingly.

💬 hebasto commented on pull request "build: Improve `ccache` performance for different build directories":
(https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1759763193)
@ryanofsky
> I only do the second not the first, because I use git worktrees...

Thanks for your feedback. Your concerns should be addressed in the recent [push](https://github.com/bitcoin/bitcoin/pull/30861#issuecomment-2351053745).

💬 kevkevinpal commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change":
(https://github.com/bitcoin/bitcoin/pull/30875#discussion_r1759769956)
thank you! Updated in [4f72eca](https://github.com/bitcoin/bitcoin/pull/30875/commits/4f72ecae2b542dbc052fae78cdc5b64a0da8b534)

💬 kevkevinpal commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change":
(https://github.com/bitcoin/bitcoin/pull/30875#discussion_r1759769962)
thank you! Updated in [4f72eca](https://github.com/bitcoin/bitcoin/pull/30875/commits/4f72ecae2b542dbc052fae78cdc5b64a0da8b534)

💬 kevkevinpal commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change":
(https://github.com/bitcoin/bitcoin/pull/30875#discussion_r1759769972)
thank you! Updated in [4f72eca](https://github.com/bitcoin/bitcoin/pull/30875/commits/4f72ecae2b542dbc052fae78cdc5b64a0da8b534)

💬 kevkevinpal commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change":
(https://github.com/bitcoin/bitcoin/pull/30875#discussion_r1759769979)
thank you! Updated in [4f72eca](https://github.com/bitcoin/bitcoin/pull/30875/commits/4f72ecae2b542dbc052fae78cdc5b64a0da8b534)

💬 kevkevinpal commented on pull request "doc: fixed inconsistencies in documentation between autotools to cmake change":
(https://github.com/bitcoin/bitcoin/pull/30875#issuecomment-2351067786)
> Also in `test_deterministic_coverage.sh`: `Run \"./configure --enable-lcov\"`

thank you! Updated in [4f72eca](https://github.com/bitcoin/bitcoin/pull/30875/commits/4f72ecae2b542dbc052fae78cdc5b64a0da8b534)