💬 maflcko commented on issue "CI timeouts":
(https://github.com/bitcoin/bitcoin/issues/30851#issuecomment-2348550239)
> network IO

Reminds me that Cirrus Logs are randomly disappearing. So maybe there is an issue in the Cirrus backend that streams logs and the streaming process dies or turns into a zombie process?

💬 fjahr commented on pull request "Embed default ASMap as binary dump header file":
(https://github.com/bitcoin/bitcoin/pull/28792#discussion_r1758574372)
Seems like there is still some tinkering going on on that one, I will give it a try when that has settled down.

🤔 hebasto reviewed a pull request: "Fix crash when closing wallet"
(https://github.com/bitcoin-core/gui/pull/835#pullrequestreview-2302703900)
Concept ACK.

`git bisect` points to 5d15485aafefdc759ba97e039bb1b9ccac267358 from https://github.com/bitcoin/bitcoin/pull/30659 as the root of the issue, which aligns with the other [comment](https://github.com/bitcoin/bitcoin/issues/30887#issuecomment-2347237302).

It would be reasonable to add a dedicated test to `test_bitcoin-qt` in a follow-up.

🤔 pablomartin4btc reviewed a pull request: "doc: replaced --enable-debug with -DCMAKE_BUILD_TYPE=Debug in developer-notes"
(https://github.com/bitcoin/bitcoin/pull/30875#pullrequestreview-2302713059)
ACK dd0941cc6de6852c8ee1347c7ccfcc887cd07e4b

nit: since you are there at `doc/zmq.md`, I think there's a typo close to the end, look for "chain--as".

⚠️ Abbbyrose opened an issue: "Hrlp me reach my goal of 10k"
(https://github.com/bitcoin/bitcoin/issues/30895)
https://cash.app/launch/bitcoin/$abbyyrosemckenna/Fs1ntjfabE

💬 maflcko commented on pull request "guix: Drop unused autotools packages":
(https://github.com/bitcoin/bitcoin/pull/30752#discussion_r1758594864)
If libtool is fine to drop here in guix, which uses depends, why is it not dropped from the depends docs as well, and the CI tasks?

```
depends/README.md: apt install automake bison cmake curl libtool make patch pkg-config python3 xz-utils
depends/packages.md:In general, the output of a depends package should not contain any libtool
.github/workflows/ci.yml: brew install --quiet automake libtool pkg-config gnu-getopt ccache boost libevent miniupnpc libnatpmp zeromq qt@5 qrencod
...

✅ fanquake closed an issue: "Help me reach my goal of 10k!!!"
(https://github.com/bitcoin/bitcoin/issues/30895)

:lock: fanquake locked an issue: "Help me reach my goal of 10k!!!"
(https://github.com/bitcoin/bitcoin/issues/30895)

💬 maflcko commented on pull request "doc: replaced --enable-debug with -DCMAKE_BUILD_TYPE=Debug in developer-notes":
(https://github.com/bitcoin/bitcoin/pull/30875#issuecomment-2348584112)
I think you are still missing:

```
test/lint/lint-spelling.py:FILES_ARGS = ['git', 'ls-files', '--', ":(exclude)build-aux/m4/", ":(exclude)contrib/seeds/*.txt", ":(exclude)depends/", ":(exclude)doc/release-notes/", ":(exclude)src/qt/locale/", ":(exclude)src/qt/*.qrc", ":(exclude)contrib/guix/patches"]
```

Also, the pull title should be updated?

👍 theStack approved a pull request: "test: Check already deactivated network stays suspended after dumptxoutset"
(https://github.com/bitcoin/bitcoin/pull/30892#pullrequestreview-2302738124)
utACK 72c9a1fe94f927220d3159f516fda684ae9d4caa

💬 maflcko commented on issue "CI timeouts":
(https://github.com/bitcoin/bitcoin/issues/30851#issuecomment-2348588797)
Some examples:

* https://cirrus-ci.com/task/5353088029032448 has missing logs (404). However, this one is not a timeout.
* https://cirrus-ci.com/task/5260390286753792 is a timeout, but has logs
* https://cirrus-ci.com/task/4532788332855296 is a timeout, and has missing logs

👍 hebasto approved a pull request: "Fix crash when closing wallet"
(https://github.com/bitcoin-core/gui/pull/835#pullrequestreview-2302743498)
ACK a965f2bc07a3588f8c2b8d6a542961562e3f5d0e.

Now, the `BitcoinGUI::removeWallet` signal is emitted once per wallet for both the "Closet Wallet..." and "Close All Wallets..." menu actions.

💬 Ianilfy commented on pull request "Don't empty dbcache on prune flushes: >30% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/28280#discussion_r1758606550)
What do I do

🤔 stratospher reviewed a pull request: "fuzz: reduce number of iterations in `crypto_aeadchacha20poly1305` target"
(https://github.com/bitcoin/bitcoin/pull/30826#pullrequestreview-2302751871)
ACK f482d0e. saw similar coverage stats
1. on branch
`#3002361 REDUCE cov: 568 ft: 3821 corp: 275/28Kb lim: 4096 exec/s: 1559 rss: 861Mb L: 154/867 MS: 4 InsertByte-EraseBytes-ShuffleBytes-ChangeBinInt-`

2. on master
`#3004483 REDUCE cov: 567 ft: 4067 corp: 270/47Kb lim: 4096 exec/s: 1917 rss: 842Mb L: 278/2782 MS: 1 EraseBytes-`

💬 fjahr commented on pull request "test: Introduce ensure helper":
(https://github.com/bitcoin/bitcoin/pull/30893#discussion_r1758617119)
My thought here was that we set a higher factor when things are generally expected to run slower, so in that case it seems natural to me that we will also want to wait longer. But yeah, I didn't take into account that people will set this factor unreasonably high to not see timeouts at all. I have removed it for now but I think an alternative could be to set a reasonable upper bound like 10x.

💬 fjahr commented on pull request "test: Introduce ensure helper":
(https://github.com/bitcoin/bitcoin/pull/30893#discussion_r1758617767)
Done and renamed to `duration`.

💬 Sjors commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#issuecomment-2348604652)
The first two commits of https://github.com/Sjors/bitcoin/pull/62 could be included here to put it behind a `-DWITH_SV2=ON` feature flag.

I'll include that in a future push once it had some review. It shouldn't be a blocker for this PR, because the classes introduced here are not used yet.

💬 fjahr commented on pull request "test: Introduce ensure helper":
(https://github.com/bitcoin/bitcoin/pull/30893#discussion_r1758618169)
sounds good, done

💬 fanquake commented on pull request "build: add `standard branch-protection` to hardening flags for aarch64-linux":
(https://github.com/bitcoin/bitcoin/pull/30433#issuecomment-2348605539)
Sorry, fixed the buggy previous version.

✅ hebasto closed an issue: "Closing a wallet using the fa46088440 28.x QT client segfaults"
(https://github.com/bitcoin/bitcoin/issues/30887)