👍 naumenkogs approved a pull request: "refactor: move m_is_inbound out of CNodeState"
(https://github.com/bitcoin/bitcoin/pull/30233#pullrequestreview-2302367391)
ACK 07f4cebe5780f1039541d989e64b70eccc5b4eb5

👍 naumenkogs approved a pull request: "test: addrman: tried 3 times and never a success so `isTerrible=true`"
(https://github.com/bitcoin/bitcoin/pull/30445#pullrequestreview-2302379127)
ACK d6fabbe2d40b53f6fa35d6b0191f3d73999d6b41

💬 petertodd commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#issuecomment-2348274066)
Re: dust UTXO creation, MARA has told me directly that they do not enforce the dust limit at all, and IIUC F2Pool does not as well. I haven't however personally tested this.

On September 13, 2024 3:08:05 AM GMT+03:00, Suhas Daftuar ***@***.***> wrote:
>@sdaftuar commented on this pull request.
>
>
>
>> @@ -934,6 +935,13 @@ bool MemPoolAccept::PreChecks(ATMPArgs& args, Workspace& ws)
> fSpendsCoinbase, nSigOpsCost, lock_points.value()));
> ws.m_vsize = ent
...

💬 maflcko commented on issue "Nuke format linter":
(https://github.com/bitcoin/bitcoin/issues/30530#issuecomment-2348277045)
The next step is https://github.com/bitcoin/bitcoin/pull/30889

💬 petertodd commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1758381743)
@sdaftuar

Re: dust UTXO creation, MARA has told me directly that they do not enforce the dust limit at all, and IIUC F2Pool does not as well. I haven't however personally tested this.

💬 Sjors commented on pull request "signet: fixing mining for OP_TRUE challenge":
(https://github.com/bitcoin/bitcoin/pull/29032#discussion_r1758386359)
Taken

💬 Sjors commented on pull request "signet: fixing mining for OP_TRUE challenge":
(https://github.com/bitcoin/bitcoin/pull/29032#discussion_r1758386457)
Moved the comment down and taken the suggestion.

💬 Sjors commented on pull request "signet: fixing mining for OP_TRUE challenge":
(https://github.com/bitcoin/bitcoin/pull/29032#discussion_r1758386552)
Also taken, and added a signed example.

💬 Sjors commented on pull request "signet: fixing mining for OP_TRUE challenge":
(https://github.com/bitcoin/bitcoin/pull/29032#issuecomment-2348304975)
Also rebased, just in case that helps with CI.

💬 Sjors commented on pull request "Have createNewBlock() return a BlockTemplate interface":
(https://github.com/bitcoin/bitcoin/pull/30440#issuecomment-2348323823)
Rebased for cmake (no changes).

💬 Sjors commented on pull request "Drop -dbcache limit":
(https://github.com/bitcoin/bitcoin/pull/28358#discussion_r1758414459)
I'm not sure what "available" means here? The amount of RAM used by other processes can vary wildly, especially on a desktop computer.

In any case, I prefer to leave changes to the text to a followup.

💬 Sjors commented on pull request "Introduce waitTipChanged() mining interface, replace RPCNotifyBlockChange, drop CRPCSignals & g_best_block":
(https://github.com/bitcoin/bitcoin/pull/30409#issuecomment-2348352540)
Trivial `#include` rebase after #30546.

💬 davidgumberg commented on pull request "streams: cache file position within AutoFile":
(https://github.com/bitcoin/bitcoin/pull/30884#issuecomment-2348369701)
crACK https://github.com/bitcoin/bitcoin/pull/30884/commits/4cfff4e58c6d806e4bc5a12386f84ff207c83419

Awesome! My testing (n=2) indicates that this branch solves the Windows IBD regression reported in #30833.

In my bench runs your branch cherry picked on 28.x took 3% more wall clock time than 27.1rc1 (3% is smaller than the fluctuations I observed during runs on the same branch), but `v28rc1` took 112% more time to reach block 300k than 27.1.

I left a nit and some out-of-scope observati
...

💬 hebasto commented on issue "GUI event loop should be block free":
(https://github.com/bitcoin/bitcoin/issues/17145#issuecomment-2348369864)
> qt has a tool that will build on android with qmake. not sure how much work this would be, but it's doable. ffiw
> […](#)
> On Thu, Sep 12, 2024, 4:57 AM maflcko ***@***.***> wrote: Ok, and Android support was blocked on cmake or qt6, or was it both? (Sorry for using this thread, but I couldn't find the tracking issue). — Reply to this email directly, view it on GitHub <[#17145 (comment)](https://github.com/bitcoin/bitcoin/issues/17145#issuecomment-2346089167)>, or unsubscribe <https://githu
...

💬 davidgumberg commented on pull request "test: remove unused src_dir param from run_tests after CMake migration":
(https://github.com/bitcoin/bitcoin/pull/30733#issuecomment-2348406588)
@fanquake thanks for catching,

post-merge ACK https://github.com/bitcoin/bitcoin/pull/30733/commits/2ad560139b80e149844f285cd1456bb7cc0eb1ee

👍 pablomartin4btc approved a pull request: "Fix crash when closing wallet"
(https://github.com/bitcoin-core/gui/pull/835#pullrequestreview-2302553051)
tACK a965f2bc07a3588f8c2b8d6a542961562e3f5d0e

Tested on Linux, I've reproduced the segfault on both "Close Walllet" and "Close All Wallets" actions from the File menu items and this PR fixes it and related features work as expected (eg closing a wallet will remove it from the top right combo when multi wallets are loaded).

💬 maflcko commented on pull request "test: Introduce ensure helper":
(https://github.com/bitcoin/bitcoin/pull/30893#issuecomment-2348437857)
```
test 2024-09-13T08:23:13.856000Z TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
File "/ci_container_base/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()
File "/ci_container_base/ci/scratch/build-i686-pc-linux-gnu/test/functional/feature_minchainwork
...

💬 fjahr commented on pull request "test: Check already deactivated network stays suspended after dumptxoutset":
(https://github.com/bitcoin/bitcoin/pull/30892#discussion_r1758502373)
Seems like we don't have a test for that explicitly. It's handled by `ParseHashOrHeight()` which used in other RPCs and is covered in other tests but still would be good to have it for `dumptxoutset`. Do you want to open a PR for that @pablomartin4btc ? Otherwise, I can add it here.

👍 TheCharlatan approved a pull request: "build: add `standard branch-protection` to hardening flags for aarch64-linux"
(https://github.com/bitcoin/bitcoin/pull/30433#pullrequestreview-2302613161)
ACK 0bb8cdbe8cf1d634fb6555913dc9b498c95aeee1

master:
```bash
/usr/bin/aarch64-linux-gnu-readelf --notes build/src/CMakeFiles/bitcoind.dir/init/bitcoind.cpp.o

Displaying notes found in: .note.gnu.property
Owner Data size Description
GNU 0x00000010 NT_GNU_PROPERTY_TYPE_0
Properties: AArch64 feature: BTI
```
This PR:
```bash
/usr/bin/aarch64-linux-gnu-readelf --notes build_b/src/CMakeFiles/bitcoind.dir/init/bitcoind.cpp.o

Displaying notes
...

💬 willcl-ark commented on issue "CI timeouts":
(https://github.com/bitcoin/bitcoin/issues/30851#issuecomment-2348489523)
> I recreated a CI timeout and the machine's CPU was idle flat at 0% for most of the part for 2 hours, but I didn't look where it spent so much time "doing nothing".

I have noticed this in the cirrus GUI before, it seems to have always been like this though IIRC:

e.g. https://cirrus-ci.com/task/6481793086390272 :

or a random pre-cmake run: https://cirrus-ci.com/task/6010695337115648

Perhaps the
...