💬 fjahr commented on pull request "scripted-diff: Modernize nLocalServices naming":
(https://github.com/bitcoin/bitcoin/pull/30885#issuecomment-2347258648)
> Following the last push, suggest renaming the pull title to `scripted-diff: Modernize nLocalServices naming` (edit: and also the commit name)

done

💬 TheCharlatan commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-2347263134)
Rebased.

💬 furszy commented on issue "Closing a wallet using the fa46088440 28.x QT client segfaults":
(https://github.com/bitcoin/bitcoin/issues/30887#issuecomment-2347263442)
Replicated. It happens closing it through the GUI toolbar button. Not the command-line. Will investigate it.

🤔 ryanofsky reviewed a pull request: "multiprocess: Add IPC wrapper for Mining interface"
(https://github.com/bitcoin/bitcoin/pull/30510#pullrequestreview-2301289042)
Updated 1be749c771cd9fd80361ebb69c87482920b25cd1 -> b95bb2179610183d9398d50d8c8fd24b1450ad4d ([`pr/mine-types.10`](https://github.com/ryanofsky/bitcoin/commits/pr/mine-types.10) -> [`pr/mine-types.11`](https://github.com/ryanofsky/bitcoin/commits/pr/mine-types.11), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/mine-types.10..pr/mine-types.11)) switching to concepts instead of enable_if

💬 ryanofsky commented on pull request "multiprocess: Add IPC wrapper for Mining interface":
(https://github.com/bitcoin/bitcoin/pull/30510#discussion_r1757602140)
re: https://github.com/bitcoin/bitcoin/pull/30510#discussion_r1757372497

Removed enable_if so this should be simpler now. Thanks for bringing this up!

📝 fjahr opened a pull request: "test: Check already deactivated network stays suspended after dumptxoutset"
(https://github.com/bitcoin/bitcoin/pull/30892)
Follow-up to #30817 which covered the robustness of `dumptxoutset`: network is deactivated during the run but re-activated even when an issue was encountered. But it did not cover the case if the user had deactivated the network themselves before. In that case the user may want the network to stay off so the network is not reactivated after `dumptxoutset` finishes. A test for this behavior is added here.

💬 fjahr commented on pull request "test: Add coverage for dumptxoutset failure robustness":
(https://github.com/bitcoin/bitcoin/pull/30817#issuecomment-2347273844)
> could go one step further and even test that if the network was already disabled (via setnetworkactive False), it won't be enabled after a dumptxoutset call.

Added in #30892

💬 fabioBaraDev commented on issue "No such file or directory: bitcoind Error":
(https://github.com/bitcoin/bitcoin/issues/30891#issuecomment-2347283479)
I was not using the right tutorial version, I did everything over again, but still got the same problem, I ran all the commands from this link
`https://github.com/bitcoin/bitcoin/blob/v27.1/doc/build-osx.md`

but this time it says that at leat 21 tests ran OK...
still [Errno 2] No such file or directory: '/Users/user/Documents/personalProjects/bitcoin/src/bitcoind'

check it out

```
Temporary test directory at /var/folders/_t/zldzv3sn05qdk78yltr69h340000gp/T/test_runner_₿_🏃_20240912
...

🤔 glozow reviewed a pull request: "Ephemeral Dust"
(https://github.com/bitcoin/bitcoin/pull/30239#pullrequestreview-2301347857)
Finer comb of the first 2 commits

💬 glozow commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1757541211)
I think this language is a little bit too strong. It's not risk-free, I think we're just checking that there is no visible incentive for the dust to enter the utxo set.

💬 glozow commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1757548475)
I don't really understand the "or itself being spent by another child, and so on" part

💬 glozow commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1757536232)
Any reason to use a `CTransaction&` instead of a `CTransactionRef`?

💬 glozow commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1757550476)
?
```suggestion
if (txfee != 0 && std::any_of(tx.vout.cbegin(), tx.vout.cbegin(), [&](const auto& output) { return IsDust(output, dust_relay_fee); })) {
return state.Invalid(TxValidationResult::TX_NOT_STANDARD, "dust", "tx with dust output must be 0-fee");
}
```

💬 glozow commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1757552226)
Can you add documentation for when each function must be called, like we did for TRUC?

💬 glozow commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1757546693)
```suggestion
* Returns false if the fee is non-zero and dust exists, populating state. True otherwise.
```

💬 glozow commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1757574587)
This isn't really the desirable behavior, perhaps worth commenting. If we fix this through something like #27476, this should be replaced with a test for the opposite case.

💬 glozow commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1757578284)
nit: sentence structure kind of weird. the transaction ignores modified? I know what you mean, but maybe confusing wording

💬 glozow commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1757611051)
spend spend

💬 furszy commented on issue "Closing a wallet using the fa46088440 28.x QT client segfaults":
(https://github.com/bitcoin/bitcoin/issues/30887#issuecomment-2347289507)
The issue is we are calling `removeAndDeleteWallet` twice for the same wallet model. The first time inside `WalletController::closeWallet` and a second time when the backend emits the wallet `unload` signal. Preparing the PR..

👍 jarolrod approved a pull request: "doc: unit test runner help fixup"
(https://github.com/bitcoin/bitcoin/pull/30890#pullrequestreview-2301431567)
ACK 0024d2c6ea0fafe9b9949af4bbcd0c583e580746