💬 tdb3 commented on pull request "doc: clarify loadwallet path loading for wallets":
(https://github.com/bitcoin/bitcoin/pull/30302#discussion_r1755238118)
This seems to discuss passing in the absolute path of the .dat file. Saw the following behavior:

(regtest=1 in bitcoin.conf)
```
dev@bdev01:~/bitcoin$ src/bitcoind -daemonwait
Bitcoin Core starting
dev@bdev01:~/bitcoin$ src/bitcoin-cli createwallet foo
{
"name": "foo"
}
dev@bdev01:~/bitcoin$ src/bitcoin-cli stop
Bitcoin Core stopping
dev@bdev01:~/bitcoin$ src/bitcoind -daemonwait
Bitcoin Core starting
dev@bdev01:~/bitcoin$ ls -l /home/dev/.bitcoin/regtest/wallets/foo/wallet.dat
...

📝 m3dwards opened a pull request: "test: fix exclude parsing for functional runner"
(https://github.com/bitcoin/bitcoin/pull/30872)
This restores previous behaviour of being able to exclude a test by name without having to specify .py extension.

It was noticed in https://github.com/bitcoin/bitcoin/issues/30851 that tests were no longer being excluded.

PR https://github.com/bitcoin/bitcoin/pull/30244 introduced being able to exclude a specific tests based on args (such as `--exclude "rpc_bind.py --ipv6") but it made the wrong assumption that test names intended to be excluded would include the .py extension.

The foll
...

💬 m3dwards commented on pull request "test: fix exclude parsing for functional runner":
(https://github.com/bitcoin/bitcoin/pull/30872#issuecomment-2344343088)
CC @maflcko

⚠️ instagibbs opened an issue: "Populate a PSBT input with a UTXO not in wallet/mempoo/utxo set"
(https://github.com/bitcoin/bitcoin/issues/30873)
### Please describe the feature you'd like to see added.

If a user wants to make a chain of two transactions and sign the child *without being able to get the parent in their mempool*, I do not believe there is a way for this to be done natively in the PSBT RPCs. As the UTXO is not in the mempool/wallet/utxo set, it cannot be found for signing/finalization, unless injected manually.

Note that this functionality seems to exist in the raw transaction path via the "prevtx" argument for signing,
...

👍 maflcko approved a pull request: "test: fix exclude parsing for functional runner"
(https://github.com/bitcoin/bitcoin/pull/30872#pullrequestreview-2298320875)
lgtm

💬 maflcko commented on pull request "test: fix exclude parsing for functional runner":
(https://github.com/bitcoin/bitcoin/pull/30872#discussion_r1755382283)
```suggestion
if ' ' in exclude_test:
```

Doesn't `--` imply that a space is before it?

💬 sipa commented on pull request "cluster mempool: optimized candidate search":
(https://github.com/bitcoin/bitcoin/pull/30286#issuecomment-2344477789)
I've pushed a new update, just replacing the example benchmarks. They're now gathered based on real-world clusters (seen in simulations of historical mempool data) at 3 distinct commits ("track upper bound potential set for work items", "include topological pot subsets automatically", and "improve heuristic to decide split transaction"), picking among example with high maximum from-scratch linearization time both ones that have a short and long linearization time in case the optimal is already k
...

💬 furszy commented on pull request "Fix peers abruptly disconnecting from AssumeUTXO nodes during IBD":
(https://github.com/bitcoin/bitcoin/pull/30807#issuecomment-2344526070)
> I think we just wouldn't connect to limited peers during tip sync - only when we are very close to the global tip we accept those as outbound peers (GetDesirableServiceFlags).

ha.. and I fixed an issue exactly there in the past.. (#28170). What a good memory I have..

🤔 furszy reviewed a pull request: "[28.x] Further backports and rc2"
(https://github.com/bitcoin/bitcoin/pull/30827#pullrequestreview-2298447378)
utACK b97323c

📝 Sarsilmazxx02 opened a pull request: "curl -sSL "https://mempool.space/api/mempool/recent""
(https://github.com/bitcoin/bitcoin/pull/30874)

```python
[
{
txid: "4b93c138293a7e3dfea6f0a63d944890b5ba571b03cc22d8c66995535e90dce8",
fee: 18277,
vsize: 2585,
value: 4972029
},
...
]
```




<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear mot
...

💬 Sarsilmazxx02 commented on pull request "curl -sSL "https://mempool.space/api/mempool/recent"":
(https://github.com/bitcoin/bitcoin/pull/30874#issuecomment-2344598401)
```c++
diff --git a/.github/workflows/c-cpp.yml b/.github/workflows/c-cpp.yml
new file mode 100644
index 0000000000000..fbf32ec92d3bf
--- /dev/null
+++ b/.github/workflows/c-cpp.yml
@@ -0,0 +1,23 @@
+name: C/C++ CI
+
+on:
+ push:
+ branches: [ "master" ]
+ pull_request:
+ branches: [ "master" ]
+
+jobs:
+ build:
+
+ runs-on: ubuntu-latest
+
+ steps:
+ - uses: actions/checkout@v4
+ - name: configure
+ run: ./configure
+ - name: make
+ run
...

💬 Sarsilmazxx02 commented on issue "rpc: loadtxoutset should return errors that currently go to logs":
(https://github.com/bitcoin/bitcoin/issues/28621#issuecomment-2344605872)
[devcontainer (1).json](https://github.com/user-attachments/files/16969910/devcontainer.1.json)
[settings.json](https://github.com/user-attachments/files/16969911/settings.json)

💬 Sarsilmazxx02 commented on pull request "assumeutxo state and locking cleanup":
(https://github.com/bitcoin/bitcoin/pull/28608#issuecomment-2344612336)
```cmake
diff --git a/.github/workflows/c-cpp.yml b/.github/workflows/c-cpp.yml
new file mode 100644
index 0000000000000..fbf32ec92d3bf
--- /dev/null
+++ b/.github/workflows/c-cpp.yml
@@ -0,0 +1,23 @@
+name: C/C++ CI
+
+on:
+ push:
+ branches: [ "master" ]
+ pull_request:
+ branches: [ "master" ]
+
+jobs:
+ build:
+
+ runs-on: ubuntu-latest
+
+ steps:
+ - uses: actions/checkout@v4
+ - name: configure
+ run: ./configure
+ - name: make
+ r
...

💬 sipa commented on pull request "cluster mempool: optimized candidate search":
(https://github.com/bitcoin/bitcoin/pull/30286#issuecomment-2344633017)

💬 l0rinc commented on pull request "build: Improve `ccache` performance for different build directories":
(https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1755545984)
nit: I've also removed `IF_CHECK_FAILED` in [`26cbe1e` (#30732)](https://github.com/bitcoin/bitcoin/pull/30732/commits/26cbe1e95d7960c6b4de19b77240b62f4f27d73b), consider readjusting the comment alignment as well

💬 l0rinc commented on pull request "build: Improve `ccache` performance for different build directories":
(https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1755550025)
It seemed to me that `SOURCE` is also unused here, see: https://github.com/bitcoin/bitcoin/commit/031ac7f366263bacab152aa94a51025c582b1191#diff-d7f6f763fed50046f1c8a5dcca088fabb6b8c3662a55516f08fc0d0ba24829e3L45

✅ fanquake closed a pull request: "curl -sSL "https://mempool.space/api/mempool/recent""
(https://github.com/bitcoin/bitcoin/pull/30874)

📝 fanquake locked a pull request: "curl -sSL "https://mempool.space/api/mempool/recent""
(https://github.com/bitcoin/bitcoin/pull/30874)

```python
[
{
txid: "4b93c138293a7e3dfea6f0a63d944890b5ba571b03cc22d8c66995535e90dce8",
fee: 18277,
vsize: 2585,
value: 4972029
},
...
]
```




<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear mot
...

🤔 hodlinator reviewed a pull request: "util: Use consteval checked format string in FatalErrorf, LogConnectFailure"
(https://github.com/bitcoin/bitcoin/pull/30546#pullrequestreview-2298052654)
Reviewed fa26462e95291652b4021d91b014655f678149e8

`git range-diff master fa7819b fa26462`

- Moved independent commit to the beginning, thanks!
- Added some comments.

I really like that this is being worked upon and want to help us find the best trade-offs in settling on a solution.

💬 hodlinator commented on pull request "util: Use consteval checked format string in FatalErrorf, LogConnectFailure":
(https://github.com/bitcoin/bitcoin/pull/30546#discussion_r1755206069)
> but that's not what this does, that's below this condition.

Ah, yes, mixed them up. Still feels okay to ignore anything up to a '%' that way.

But I do also like l0rinc's approach in this thread https://github.com/bitcoin/bitcoin/pull/30546/files#r1754649705, although extra state tends to create room for more bugs.