💬 mzumsande commented on pull request "rpc, rest: Improve block rpc error handling, check header before attempting to read block data.":
(https://github.com/bitcoin/bitcoin/pull/30410#discussion_r1751039102)
renamed to `CheckBlockDataAvailability()`

💬 mzumsande commented on pull request "rpc, rest: Improve block rpc error handling, check header before attempting to read block data.":
(https://github.com/bitcoin/bitcoin/pull/30410#issuecomment-2339321767)
[041b78c ](https://github.com/bitcoin/bitcoin/commit/041b78ccede9974117dac5d8623fedec2f32471d)to [92236f4](https://github.com/bitcoin/bitcoin/commit/92236f43ff92c931f3a099e03d7851b890bff263): addressed feedback by @fjahr

📝 sipa opened a pull request: "cluster mempool: extend DepGraph (multiple dependencies, removing transactions, parents/children)"
(https://github.com/bitcoin/bitcoin/pull/30857)
This adds:
* `DepGraph::AddDependencies` to add 0 or more dependencies to a single transaction at once (identical to calling `DepGraph::AddDependency` once for each, but more efficient).
* `DepGraph::RemoveTransactions` to remove 0 or more transactions from a depgraph.
* `DepGraph::GetReducedParents` (and `DepGraph::GetReducedChildren`) to get the (reduced) direct parents a children of a transaction in a depgraph.

This is the result of fleshing out the design for the "intermediate layer" (
...

⚠️ Freks24 opened an issue: "Fishy F g"
(https://github.com/bitcoin/bitcoin/issues/30858)
Fish he to her try hit u rh F my F re try

💬 Freks24 commented on issue "Fishy F g":
(https://github.com/bitcoin/bitcoin/issues/30858#issuecomment-2339451319)
Hi

✅ achow101 closed an issue: "Fishy F g"
(https://github.com/bitcoin/bitcoin/issues/30858)

:lock: achow101 locked an issue: "Fishy F g"
(https://github.com/bitcoin/bitcoin/issues/30858)

📝 LarryRuane opened a pull request: "doc: cmake: prepend "build" to functional/test_runner.py"
(https://github.com/bitcoin/bitcoin/pull/30859)
This is a small follow-on to #30741. Also, improve the error message if someone runs the functional tests the old way (outside of the build directory).

💬 LarryRuane commented on pull request "doc: cmake: prepend "build" to functional/test_runner.py":
(https://github.com/bitcoin/bitcoin/pull/30859#issuecomment-2339578313)
This patch would have helped me; I'm new to `cmake`; after building it for the first time, I tried to run the functional tests (the way I was used to), and it failed in a strange way:
```
$ test/functional/test_runner.py
Traceback (most recent call last):
File "/sd/g/bitcoin/test/functional/test_runner.py", line 950, in <module>
main()
File "/sd/g/bitcoin/test/functional/test_runner.py", line 465, in main
config.read_file(open(configfile, encoding="utf8"))

...

🤔 tdb3 reviewed a pull request: "doc: cmake: prepend "build" to functional/test_runner.py"
(https://github.com/bitcoin/bitcoin/pull/30859#pullrequestreview-2291346092)
Thanks for noticing this. I'd support the documentation change without changing the python programs.

💬 tdb3 commented on pull request "doc: cmake: prepend "build" to functional/test_runner.py":
(https://github.com/bitcoin/bitcoin/pull/30859#discussion_r1751241259)
This extra line seems like overkill if the proceeding line is being updated to include "build"

💬 tdb3 commented on pull request "doc: cmake: prepend "build" to functional/test_runner.py":
(https://github.com/bitcoin/bitcoin/pull/30859#discussion_r1751243701)
Seems like it might be enough to update the instructions rather than change `test_framework.py` or `test_runner.py`

💬 achow101 commented on issue "Increasing self-hosted runner raw performance":
(https://github.com/bitcoin/bitcoin/issues/30852#issuecomment-2339623497)
Not really that much faster: https://cirrus-ci.com/build/5557255590903808, but possibly also misconfigured as everything was setup to run on that one machine simultaneously, although it should enough cores and memory.

💬 maflcko commented on issue "Increasing self-hosted runner raw performance":
(https://github.com/bitcoin/bitcoin/issues/30852#issuecomment-2339651980)
Hmm, you could also try to re-run the tasks individually to see the best possible performance (which is what was tested above as well).

Otherwise, my suggestion would be to go with one of the AMD CPUs mentioned above. (I can give this a try in the coming days)

💬 maflcko commented on pull request "util: Use consteval checked format string in FatalErrorf":
(https://github.com/bitcoin/bitcoin/pull/30546#discussion_r1751290182)
Yes. I am thinking that it could make sense to have a wrapper-header around tinyformat, so that each relevant tfm function can be called with `ConstevalFormatString`.

💬 maflcko commented on issue "Trying to run bitcoin qt on Windows and getting an AV":
(https://github.com/bitcoin/bitcoin/issues/30825#issuecomment-2339720856)
It would also be good to confirm the exact commit hash where this happened, because `master` may have changed when it was pulled and when the issue was filed (and certainly has changed now).

💬 Sjors commented on pull request "Introduce waitTipChanged() mining interface, replace RPCNotifyBlockChange, drop CRPCSignals & g_best_block":
(https://github.com/bitcoin/bitcoin/pull/30409#issuecomment-2339769505)
Trivial rebase after #30509.

💬 Sjors commented on pull request "multiprocess: Add -ipcbind option to bitcoin-node":
(https://github.com/bitcoin/bitcoin/pull/30509#issuecomment-2339814474)
Post-merge re-utACK 30073e6b3a24cbe417c45cd5df6a3a2de0251e9d

💬 stickies-v commented on pull request "test: support std::optional in BOOST_CHECK_* and increase FromUserHex fuzz feature coverage":
(https://github.com/bitcoin/bitcoin/pull/30618#issuecomment-2339825378)
rebase re-ACK 6da47f6ba5450e7f2b2ab2a64c7cfd354f67a1a9, CI timeout failure seems unrelated

💬 Sjors commented on pull request "multiprocess: Add IPC wrapper for Mining interface":
(https://github.com/bitcoin/bitcoin/pull/30510#discussion_r1751353778)
988dacead4a9a6850b767a8ced0c08b47fece56d: can you add a comment for why this isn't in `src/test/CMakeFile.txt`? A tl&dr of https://github.com/bitcoin/bitcoin/pull/30510/files#r1747656292