💬 stickies-v commented on pull request "util: Use consteval checked format string in FatalErrorf":
(https://github.com/bitcoin/bitcoin/pull/30546#discussion_r1750371020)
typo nit
```suggestion
if (count_nor && count_pos) throw "Format specifiers must be all positional or all non-positional!";
```

🤔 stickies-v reviewed a pull request: "util: Use consteval checked format string in FatalErrorf"
(https://github.com/bitcoin/bitcoin/pull/30546#pullrequestreview-2290090683)
Concept ACK. Doing this at compile time is much more helpful, besides the bugs being fixed.

✅ l0rinc closed a pull request: "test: add subsidy sum test, iterating every block"
(https://github.com/bitcoin/bitcoin/pull/30699)

💬 l0rinc commented on pull request "test: add subsidy sum test, iterating every block":
(https://github.com/bitcoin/bitcoin/pull/30699#issuecomment-2339078081)
Ok, thanks for taking the time to explain it.
I don't want others to approve it if you've NACK-ed it. While I don't fully understand the reasoning, I respect your decision, so I'll just close this off instead.

💬 achow101 commented on pull request "multiprocess: Add -ipcbind option to bitcoin-node":
(https://github.com/bitcoin/bitcoin/pull/30509#issuecomment-2339090654)
ACK 30073e6b3a24cbe417c45cd5df6a3a2de0251e9d

🚀 achow101 merged a pull request: "multiprocess: Add -ipcbind option to bitcoin-node"
(https://github.com/bitcoin/bitcoin/pull/30509)

💬 brunoerg commented on pull request "rpc: add getorphantxs":
(https://github.com/bitcoin/bitcoin/pull/30793#issuecomment-2339208164)
Concept ACK

👋 tdb3's pull request is ready for review: "rpc: add `revelant_blocks` to `scanblocks status`"
(https://github.com/bitcoin/bitcoin/pull/30713)

💬 tdb3 commented on pull request "rpc: add `revelant_blocks` to `scanblocks status`":
(https://github.com/bitcoin/bitcoin/pull/30713#issuecomment-2339214391)
Will add release notes when incorporating reviewer comments.

💬 tdb3 commented on pull request "rpc: add `revelant_blocks` to `scanblocks status`":
(https://github.com/bitcoin/bitcoin/pull/30713#discussion_r1750990127)
While leaving `scanblocks()` without resetting `g_relevant_blocks` isn't ideal, resetting `g_relevant_blocks` just before `BlockFiltersScanReserver` is used by the `start` branch seemed to be a good way to prevent `status` from accidentally seeing an empty `g_relevant_blocks` (at least in common cases). Please let me know if I'm overlooking a likely concurrency case, and it can be adjusted.

📝 theStack opened a pull request: "build: drop obj/ subdirectory for generated build.h"
(https://github.com/bitcoin/bitcoin/pull/30856)
As indicated by the TODO, the obj subdirectory is not needed anymore now for the generated build.h header, since autotools are gone and we don't have in-source builds anymore.

💬 mzumsande commented on pull request "rpc, rest: Improve block rpc error handling, check header before attempting to read block data.":
(https://github.com/bitcoin/bitcoin/pull/30410#discussion_r1751038732)
I can break this up, but I think the suggestion doesn't work because we still need to feed the result into `have_undo` so that if `UndoReadFromDisk` fails for an unexpected reason, we don't attempt to access `blockUndo` below and segfault.

💬 mzumsande commented on pull request "rpc, rest: Improve block rpc error handling, check header before attempting to read block data.":
(https://github.com/bitcoin/bitcoin/pull/30410#discussion_r1751038941)
done

💬 mzumsande commented on pull request "rpc, rest: Improve block rpc error handling, check header before attempting to read block data.":
(https://github.com/bitcoin/bitcoin/pull/30410#discussion_r1751039102)
renamed to `CheckBlockDataAvailability()`

💬 mzumsande commented on pull request "rpc, rest: Improve block rpc error handling, check header before attempting to read block data.":
(https://github.com/bitcoin/bitcoin/pull/30410#issuecomment-2339321767)
[041b78c ](https://github.com/bitcoin/bitcoin/commit/041b78ccede9974117dac5d8623fedec2f32471d)to [92236f4](https://github.com/bitcoin/bitcoin/commit/92236f43ff92c931f3a099e03d7851b890bff263): addressed feedback by @fjahr

📝 sipa opened a pull request: "cluster mempool: extend DepGraph (multiple dependencies, removing transactions, parents/children)"
(https://github.com/bitcoin/bitcoin/pull/30857)
This adds:
* `DepGraph::AddDependencies` to add 0 or more dependencies to a single transaction at once (identical to calling `DepGraph::AddDependency` once for each, but more efficient).
* `DepGraph::RemoveTransactions` to remove 0 or more transactions from a depgraph.
* `DepGraph::GetReducedParents` (and `DepGraph::GetReducedChildren`) to get the (reduced) direct parents a children of a transaction in a depgraph.

This is the result of fleshing out the design for the "intermediate layer" (
...

⚠️ Freks24 opened an issue: "Fishy F g"
(https://github.com/bitcoin/bitcoin/issues/30858)
Fish he to her try hit u rh F my F re try

💬 Freks24 commented on issue "Fishy F g":
(https://github.com/bitcoin/bitcoin/issues/30858#issuecomment-2339451319)
Hi

✅ achow101 closed an issue: "Fishy F g"
(https://github.com/bitcoin/bitcoin/issues/30858)

:lock: achow101 locked an issue: "Fishy F g"
(https://github.com/bitcoin/bitcoin/issues/30858)