Bitcoin Core Github
43 subscribers
123K links
Download Telegram
👍 Ayush170-Future approved a pull request: "p2p: skip netgroup diversity follow-up"
(https://github.com/bitcoin/bitcoin/pull/27467#pullrequestreview-1386334439)
ACK on the concept.

The code also looks good to me.
💬 pinheadmz commented on pull request "Make GUI and CLI tools use the same datadir":
(https://github.com/bitcoin/bitcoin/pull/27409#issuecomment-1509735704)
This PR probably closes https://github.com/bitcoin/bitcoin/issues/8106
💬 fanquake commented on pull request "Update src/secp256k1 subtree to release v0.3.1":
(https://github.com/bitcoin/bitcoin/pull/27445#issuecomment-1509735922)
Guix Build:
```bash
a750ae4390cbc5386cd263097da9470c1437d798379fe3f5f10a5086e48fc6fb guix-build-621c17869d37/output/aarch64-linux-gnu/SHA256SUMS.part
1458929f13ef9d52ebca28948d83f7e1ed9bd2e992fe0334482cdaf3fa32aab6 guix-build-621c17869d37/output/aarch64-linux-gnu/bitcoin-621c17869d37-aarch64-linux-gnu-debug.tar.gz
74458df1b50213bff9231ed87f0d80f7fe2ab2e6b83d1a959a28b7f1297339b4 guix-build-621c17869d37/output/aarch64-linux-gnu/bitcoin-621c17869d37-aarch64-linux-gnu.tar.gz
1ed57572087d7b09
...
👍 fanquake approved a pull request: "Update src/secp256k1 subtree to release v0.3.1"
(https://github.com/bitcoin/bitcoin/pull/27445#pullrequestreview-1386436800)
ACK 621c17869d3754559c03e4f2bee73885659e0c68
💬 fanquake commented on issue "Opening bitcoin-24.0rc1-arm64-apple-darwin.dmg does not open Finder window":
(https://github.com/bitcoin/bitcoin/issues/26176#issuecomment-1509738298)
#27099 isn't going to get in before branch-off, so moving this to 26.x.
🚀 fanquake merged a pull request: "Update src/secp256k1 subtree to release v0.3.1"
(https://github.com/bitcoin/bitcoin/pull/27445)
💬 MarcoFalke commented on issue "test: `wallet_importdescriptors.py --descriptors` failure":
(https://github.com/bitcoin/bitcoin/issues/27282#issuecomment-1509741820)
Is this still an issue with a recent version of Bitcoin Core? If yes, what are the steps to reproduce?
💬 fanquake commented on issue "test: `wallet_importdescriptors.py --descriptors` failure":
(https://github.com/bitcoin/bitcoin/issues/27282#issuecomment-1509743072)
I don't think I've seen this again, only occurence seemed to be Cirrus above (before the fix). Guess we can reclose for now? Will remove from the milestone in any case.
💬 MarcoFalke commented on issue "make check errors on big endian OpenBSD 7.2":
(https://github.com/bitcoin/bitcoin/issues/26492#issuecomment-1509743101)
Not a regression, so I removed the milestone. Bug fixes are still welcome, though.
💬 MarcoFalke commented on issue "test: `wallet_importdescriptors.py --descriptors` failure":
(https://github.com/bitcoin/bitcoin/issues/27282#issuecomment-1509743273)
sgtm. Closing for now, until this happens again.
MarcoFalke closed an issue: "test: `wallet_importdescriptors.py --descriptors` failure"
(https://github.com/bitcoin/bitcoin/issues/27282)
🚀 fanquake merged a pull request: "bumpfee: avoid making bumped transactions with too low fee when replacing outputs"
(https://github.com/bitcoin/bitcoin/pull/27308)
👍 fanquake approved a pull request: "doc: fix typo in developer-notes.md"
(https://github.com/bitcoin/bitcoin/pull/27465#pullrequestreview-1386442306)
ACK f24f4fa3f114b1bd5b7e7ff9ebb0ef73bfc81eda
🚀 fanquake merged a pull request: "doc: fix typo in developer-notes.md"
(https://github.com/bitcoin/bitcoin/pull/27465)
👍 stickies-v approved a pull request: "bugfix: rest: avoid segfault for invalid URI"
(https://github.com/bitcoin/bitcoin/pull/27468#pullrequestreview-1386480124)
ACK 827b14c33f39131ede35ddecde75cc052d977ec5
💬 furszy commented on pull request "bumpfee: allow send coins back to yourself":
(https://github.com/bitcoin/bitcoin/pull/27195#issuecomment-1509837822)
rebased, conflicts solved. Ready to go.
📝 furszy opened a pull request: "wallet: improve IBD sync time by skipping block scanning prior birth time"
(https://github.com/bitcoin/bitcoin/pull/27469)
During initial block download, the node's wallet(s) scans every arriving block looking for data that it owns.
This process can be resource-intensive, as it involves sequentially scanning all transactions within each
arriving block.

To avoid wasting processing power, we can skip blocks that occurred before the wallet's creation time,
since these blocks are guaranteed not to contain any relevant wallet data.

This has direct implications (an speed improvement) on the underlying blockchain
...
📝 Muhammedhamid23 opened a pull request: "Create docker-image.yml"
(https://github.com/bitcoin/bitcoin/pull/27470)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...
📝 furszy opened a pull request: "test: fix bumpfee 'spend_one_input' occasional failure"
(https://github.com/bitcoin/bitcoin/pull/27471)
CI test failure, in master: https://cirrus-ci.com/task/5975232842825728.
In #27469 https://cirrus-ci.com/task/6452468402356224

Most of the subtests in `wallet_bumpfee.py` expect to find spendable UTXOs of 0.001 btc in the rbf wallet (they use the `spend_one_input()` method that tries to spend one of them and if it doesn't find any, it throws an exception).

The sporadic failure comes from the recently added `test_feerate_checks_replaced_outputs` subtest that can spend all them. Leaving the
...
🤔 turkycat reviewed a pull request: "blockstorage: do not flush block to disk if it is already there"
(https://github.com/bitcoin/bitcoin/pull/27039#pullrequestreview-1386645395)
core review and local test run ACK 470ef396