💬 petertodd commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#issuecomment-2336709943)
ACK 4f65c8e98957a6d8fe48ef56383d9d5776d5acd4

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1749269436)
Sure! Here are the steps to cross-compile for Windows and run unit test on a _fresh_ Ubuntu 24.04 installation:
```
$ sudo apt install binfmt-support cmake curl git g++-mingw-w64-x86-64-posix make pkg-config wine-binfmt
$ sudo update-binfmts --enable wine
$ git clone https://github.com/bitcoin/bitcoin.git
$ cd bitcoin
$ gmake -C depends -j $(nproc) HOST=x86_64-w64-mingw32 NO_QT=1
$ cmake -B build --toolchain depends/x86_64-w64-mingw32/toolchain.cmake
$ cmake --build build -j $(nproc)
$
...

💬 QBlockQ commented on issue "28.0rc1 synchronizes much slower on Windows":
(https://github.com/bitcoin/bitcoin/issues/30833#issuecomment-2336727593)
Try raising the dbcache setting to allocate more memory for caching (e.g., dbcache=1000 or more) to improve sync performance. Also, consider enabling pruning could speed up synchronization.

💬 fanquake commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1749270148)
Ok. That is what I did; so I'll have to retest. Although, above you said we'd have to do wine configuration etc, and that was a reason to not add it to the docs. However I don't see anything like that here?

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1749271047)
> Although, above you said we'd have to do wine configuration etc, and that was a reason to not add it to the docs. However I don't see anything like that here?

```
$ sudo update-binfmts --enable wine
```

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1749271553)
The unused dead code has been deleted in https://github.com/bitcoin/bitcoin/pull/30803.

💬 fanquake commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1749271611)
I was under the impression that happened automatically on wine installation. Will also re-test.

💬 hebasto commented on pull request "build: Minor build system fixes and amendments":
(https://github.com/bitcoin/bitcoin/pull/30803#issuecomment-2336730196)
> lgtm ACK [cc9d65d](https://github.com/bitcoin/bitcoin/commit/cc9d65dc05f802aaaa108a2edcf30c3758c3f459)
>
> Let's wait for the outcome of the discussions in [#30454 (comment)](https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1726684296) and [#30454 (comment)](https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1723106474) as well?

Thanks! Both comments have been addressed.

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1749272494)
> I was under the impression that happened automatically on wine installation.

I'm not sure, but it can depend on a distro.

💬 andrewtoth commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#discussion_r1749277512)
Fixed.

💬 andrewtoth commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#discussion_r1749277546)
Fixed.

💬 andrewtoth commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#discussion_r1749277622)
Added a sentence in the commit message.

💬 andrewtoth commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#discussion_r1749277694)
Renamed to `should_write`.

💬 andrewtoth commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#discussion_r1749277743)
Renamed.

💬 andrewtoth commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#discussion_r1749277789)
Removed the dates altogether.

💬 andrewtoth commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#discussion_r1749277815)
Split into 2 commits.

💬 andrewtoth commented on pull request "Drop -dbcache limit":
(https://github.com/bitcoin/bitcoin/pull/28358#issuecomment-2336737880)
If we merge https://github.com/bitcoin/bitcoin/pull/30611, then write outs will be more evenly distributed throughout the sync and will not all happen on shutdown with a high dbcache.

💬 andrewtoth commented on pull request "coins: remove logic for spent-and-FRESH cache entries and writing non-DIRTY entries":
(https://github.com/bitcoin/bitcoin/pull/30673#discussion_r1749283536)
Are you suggesting to refactor direct flags access with `SetDirty` and `SetDirtyAndFresh` first? If we do that first, we would still need a `SetFresh` setter since we still have a case here with setting FRESH-but-not-DIRTY. It's kind of a chicken-and-egg problem.

💬 itornaza commented on pull request "docs: Updated debug build instructions for cmake":
(https://github.com/bitcoin/bitcoin/pull/30840#issuecomment-2336760996)
Rebased to address the CI lint test error that was due to documentation lines terminating with whitespace characters.

👍 tdb3 approved a pull request: "docs: Updated debug build instructions for cmake"
(https://github.com/bitcoin/bitcoin/pull/30840#pullrequestreview-2288575391)
ACK 0b003e1ff7e09b56cd013b15f1998495994b7211