👍 ismaelsadeeq approved a pull request: "init: fix init fatal error on invalid negated option value"
(https://github.com/bitcoin/bitcoin/pull/30684#pullrequestreview-2288536299)
Tested ACK ee47ca29d6ef55650a0af63bca817c5d494f31ef

I’ve verified that on master, passing a non-boolean convertible value and 0 causes a fatal error. This PR provides a much clearer error message.

💬 fanquake commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1749233940)
Can you list the steps to make that happen. Given the steps in our instructions aren't currently sufficient.

💬 laanwj commented on issue "build: reproducibility issue with macOS Guix builds":
(https://github.com/bitcoin/bitcoin/issues/30815#issuecomment-2336699084)
Any idea why this happens?

Is it something else from the context outside GUIX that leaks in? Umasks? File system differences?

We can likely work around this at the cmake level but ideally the guix build shell would prevent this from happening at a in the first place.

💬 laanwj commented on pull request "build: Use CMake's default permissions in macOS `deploy` target":
(https://github.com/bitcoin/bitcoin/pull/30838#issuecomment-2336702171)
Concept ACK

👍 BrandonOdiwuor approved a pull request: "test: Add coverage for dumptxoutset failure robustness"
(https://github.com/bitcoin/bitcoin/pull/30817#pullrequestreview-2288545006)
Code Review ACK c2b779da4e7f1bf1a5c5d67ec94cba3027b42ee7

💬 furszy commented on pull request "RPC: improve SFFO arg parsing, error catching and coverage":
(https://github.com/bitcoin/bitcoin/pull/30844#issuecomment-2336706369)
@murchandamus

💬 petertodd commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#issuecomment-2336709943)
ACK 4f65c8e98957a6d8fe48ef56383d9d5776d5acd4

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1749269436)
Sure! Here are the steps to cross-compile for Windows and run unit test on a _fresh_ Ubuntu 24.04 installation:
```
$ sudo apt install binfmt-support cmake curl git g++-mingw-w64-x86-64-posix make pkg-config wine-binfmt
$ sudo update-binfmts --enable wine
$ git clone https://github.com/bitcoin/bitcoin.git
$ cd bitcoin
$ gmake -C depends -j $(nproc) HOST=x86_64-w64-mingw32 NO_QT=1
$ cmake -B build --toolchain depends/x86_64-w64-mingw32/toolchain.cmake
$ cmake --build build -j $(nproc)
$
...

💬 QBlockQ commented on issue "28.0rc1 synchronizes much slower on Windows":
(https://github.com/bitcoin/bitcoin/issues/30833#issuecomment-2336727593)
Try raising the dbcache setting to allocate more memory for caching (e.g., dbcache=1000 or more) to improve sync performance. Also, consider enabling pruning could speed up synchronization.

💬 fanquake commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1749270148)
Ok. That is what I did; so I'll have to retest. Although, above you said we'd have to do wine configuration etc, and that was a reason to not add it to the docs. However I don't see anything like that here?

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1749271047)
> Although, above you said we'd have to do wine configuration etc, and that was a reason to not add it to the docs. However I don't see anything like that here?

```
$ sudo update-binfmts --enable wine
```

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1749271553)
The unused dead code has been deleted in https://github.com/bitcoin/bitcoin/pull/30803.

💬 fanquake commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1749271611)
I was under the impression that happened automatically on wine installation. Will also re-test.

💬 hebasto commented on pull request "build: Minor build system fixes and amendments":
(https://github.com/bitcoin/bitcoin/pull/30803#issuecomment-2336730196)
> lgtm ACK [cc9d65d](https://github.com/bitcoin/bitcoin/commit/cc9d65dc05f802aaaa108a2edcf30c3758c3f459)
>
> Let's wait for the outcome of the discussions in [#30454 (comment)](https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1726684296) and [#30454 (comment)](https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1723106474) as well?

Thanks! Both comments have been addressed.

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1749272494)
> I was under the impression that happened automatically on wine installation.

I'm not sure, but it can depend on a distro.

💬 andrewtoth commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#discussion_r1749277512)
Fixed.

💬 andrewtoth commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#discussion_r1749277546)
Fixed.

💬 andrewtoth commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#discussion_r1749277622)
Added a sentence in the commit message.

💬 andrewtoth commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#discussion_r1749277694)
Renamed to `should_write`.

💬 andrewtoth commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#discussion_r1749277743)
Renamed.