💬 instagibbs commented on pull request "rpc: Add importmempool RPC":
(https://github.com/bitcoin/bitcoin/pull/27460#issuecomment-1508506500)
concept ACK, will review

📝 MarcoFalke opened a pull request: "fuzz: re-enable prioritisetransaction RPC"
(https://github.com/bitcoin/bitcoin/pull/27464)
The linked issue seems fixed, so it should be fine to re-enable

💬 instagibbs commented on pull request "rpc: Add importmempool RPC":
(https://github.com/bitcoin/bitcoin/pull/27460#discussion_r1166889886)
I'd like the test to load against two mempool files with differing txn subsets at least, showing that "additional" txs are loaded even if they weren't there originally. Even better if they're not strict subsets.

💬 MarcoFalke commented on issue "index: ThreadSanitizer: data race on vptr ":
(https://github.com/bitcoin/bitcoin/issues/27355#issuecomment-1508629562)
All I run into here is a bdb issue, which can be worked around with:

```diff
diff --git a/test/sanitizer_suppressions/tsan b/test/sanitizer_suppressions/tsan
index d33199127..35c6a5f95 100644
--- a/test/sanitizer_suppressions/tsan
+++ b/test/sanitizer_suppressions/tsan
@@ -23,7 +23,7 @@ race:src/qt/test/*
deadlock:src/qt/test/*

# External libraries
-deadlock:libdb
+deadlock:__db_pthread_mutex_lock
race:libzmq

# Intermittent issues

💬 instagibbs commented on issue "Package Relay Project Tracking":
(https://github.com/bitcoin/bitcoin/issues/27463#issuecomment-1508641506)
Very helpful. I think this helps define "sprints" that can be achieved to hit next milestones.

💬 MarcoFalke commented on pull request "Allow configuring target block time for a signet":
(https://github.com/bitcoin/bitcoin/pull/27446#discussion_r1166919624)
unrelated nit: If you retouch, you could also remove `__func__` for `-signetchallenge`

💬 fanquake commented on issue "qa: Intermittent failure in `feature_fee_estimation.py`":
(https://github.com/bitcoin/bitcoin/issues/23165#issuecomment-1508710573)
https://cirrus-ci.com/task/6110951150190592?logs=ci#L3312:
```bash
node1 2023-04-14T11:01:41.617514Z [http] [httpserver.cpp:257] [http_request_cb] [http] Received a POST request for / from 127.0.0.1:49238
node1 2023-04-14T11:01:41.617673Z [httpworker.2] [rpc/request.cpp:180] [parse] [rpc] ThreadRPCServer method=getmempoolinfo user=__cookie__
test 2023-04-14T11:01:41.618000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):

...

💬 MarcoFalke commented on pull request "rpc: Add importmempool RPC":
(https://github.com/bitcoin/bitcoin/pull/27460#discussion_r1166947724)
thx, done

💬 MarcoFalke commented on pull request "rpc: Add importmempool RPC":
(https://github.com/bitcoin/bitcoin/pull/27460#discussion_r1166947957)
thx, done

💬 MarcoFalke commented on pull request "rpc: Add importmempool RPC":
(https://github.com/bitcoin/bitcoin/pull/27460#discussion_r1166948122)
thx, done

💬 MarcoFalke commented on pull request "rpc: Add importmempool RPC":
(https://github.com/bitcoin/bitcoin/pull/27460#discussion_r1166948363)
thx, done

💬 MarcoFalke commented on pull request "rpc: Add importmempool RPC":
(https://github.com/bitcoin/bitcoin/pull/27460#discussion_r1166948827)
Might do next week/month, unless someone beats me to it

💬 MarcoFalke commented on pull request "rpc: Add importmempool RPC":
(https://github.com/bitcoin/bitcoin/pull/27460#discussion_r1166950408)
Just using the current time seems good enough. Might implement next week.

💬 furszy commented on issue "index: ThreadSanitizer: data race on vptr ":
(https://github.com/bitcoin/bitcoin/issues/27355#issuecomment-1508740170)
Not really a fix if there is something else going on but.. could use https://github.com/furszy/bitcoin-core/commit/8495c852ebe199a96a4e205937861b76f54227eb (quick and dirty) to remove the active-wait timeout error.

💬 MarcoFalke commented on pull request "depends: fix compiling bdb with clang-16":
(https://github.com/bitcoin/bitcoin/pull/27462#issuecomment-1508758659)
This is only broken on aarch64, right?

💬 fanquake commented on pull request "depends: fix compiling bdb with clang-16":
(https://github.com/bitcoin/bitcoin/pull/27462#issuecomment-1508763753)
> This is only broken on aarch64, right?

Yea. Otherwise the CI should be failing. I haven't looked into the x86_64 vs aarch64 code in bdb.

💬 sipa commented on pull request "Update src/secp256k1 subtree to release v0.3.1":
(https://github.com/bitcoin/bitcoin/pull/27445#issuecomment-1508763839)
Updated, and also improved the linter logic to decide which files to lint.

💬 sipa commented on pull request "Update src/secp256k1 subtree to release v0.3.1":
(https://github.com/bitcoin/bitcoin/pull/27445#discussion_r1166963400)
Note for reviewers: this should just be excluding the following files:
* src/crc32c/.ycm_extra_conf.py
* src/minisketch/tests/pyminisketch.py
* src/secp256k1/tools/tests_wycheproof_generate.py

💬 theuni commented on pull request "depends: fix compiling bdb with clang-16 on aarch64":
(https://github.com/bitcoin/bitcoin/pull/27462#issuecomment-1508784669)
Concept ACK. To @MarcoFalke's point, how nasty would a patch be to actually fix the casts?

💬 fanquake commented on pull request "depends: fix compiling bdb with clang-16 on aarch64":
(https://github.com/bitcoin/bitcoin/pull/27462#issuecomment-1508790120)
> how nasty would a patch be to actually fix the casts?

The first failures occur in configure, so probably nasty.