💬 glozow commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1744310449)
```suggestion
// Now with dust, ok because the tx has no dusty parents
```

💬 glozow commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1744335056)
Could comment that `tx_input.prevout.n` doesn't need to equal `map_tx_dust.at(tx_input.prevout.hash)`; a child can spend multiple outputs of a parent.

💬 glozow commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1744312279)
```suggestion
const Txid& parent_txid = ephemeral_violation.value();
```

💬 alphachart commented on pull request "p2p: detect addnode cjdns peers in GetAddedNodeInfo()":
(https://github.com/bitcoin/bitcoin/pull/30085#issuecomment-2329956541)
Shet

💬 furszy commented on pull request "init: fix init fatal error on invalid negated option value":
(https://github.com/bitcoin/bitcoin/pull/30684#issuecomment-2330067124)
> May want to update the pr description to say this bug also when happens passing a double negated value, since the not_a_boolean case is really just a special case of that

yeah, thanks. Done. PR description updated.

💬 theStack commented on pull request "refactor: move `SignSignature` helpers to test utils":
(https://github.com/bitcoin/bitcoin/pull/30561#issuecomment-2330113153)
Rebased on master, needed after https://github.com/bitcoin/bitcoin/pull/30784 got merged.

📝 hebasto converted_to_draft a pull request: "Reintroduce external signer support for Windows"
(https://github.com/bitcoin/bitcoin/pull/29868)
Based on upstream https://github.com/arun11299/cpp-subprocess/pull/99.

Partially reverts:
- https://github.com/bitcoin/bitcoin/pull/28967
- https://github.com/bitcoin/bitcoin/pull/29489

After this PR, we can proceed to actually remove the [unused code](https://github.com/bitcoin/bitcoin/pull/28981#pullrequestreview-1991272752) from `src/util/subprocess.hpp`.

🤔 fjahr reviewed a pull request: "test: Use std::span and std::string_view for raw data"
(https://github.com/bitcoin/bitcoin/pull/30796#pullrequestreview-2281377791)
Code review ACK fa0321cc742754af4e5822d4227d4136a6f4f467

💬 fjahr commented on pull request "test: Use std::span and std::string_view for raw data":
(https://github.com/bitcoin/bitcoin/pull/30796#discussion_r1744492602)
What does the `detail_` prefix mean?

👋 hebasto's pull request is ready for review: "Reintroduce external signer support for Windows"
(https://github.com/bitcoin/bitcoin/pull/29868)

🤔 furszy reviewed a pull request: "Fix peers abruptly disconnecting from AssumeUTXO nodes during IBD"
(https://github.com/bitcoin/bitcoin/pull/30807#pullrequestreview-2281468112)
Updated and rebased due to conflicts with a recently merged PR. The CI shouldn't complain now.

On a side note:
It took me longer to place my test code inside `feature_assumeutxo.py` than to fix the issue. I think it would be good to reorganize this file a bit and make the assumeUTXO parameters configurable at startup or runtime for tests. This would allow us to split tests into different files for each of the products we provide: network/p2p, local node, and wallet.

💬 benthecarman commented on issue "Testnet4 consensus failure due to timewarp related "softfork"":
(https://github.com/bitcoin/bitcoin/issues/30786#issuecomment-2330211051)
I am on 28.0rc1 and seem to be on a different chain. Block is `00000000000044a7284978db5161b2f4ca012b3fb981a9405a4ce2473f3e4a5f` for height `42545`, unsure how to get to the main chain

📝 marcofleon opened a pull request: "doc: fix assumeutxo design doc link"
(https://github.com/bitcoin/bitcoin/pull/30819)
A correction to a link as I was exploring Assumeutxo stuff.

💬 hebasto commented on issue "build: reproducibility issue with macOS Guix builds":
(https://github.com/bitcoin/bitcoin/issues/30815#issuecomment-2330215121)
This issue boils down to two following calls:

- https://github.com/bitcoin/bitcoin/blob/93e48240bfdc25c2760d33da69e739ba1f92da9b/cmake/module/Maintenance.cmake#L95
- https://github.com/bitcoin/bitcoin/blob/93e48240bfdc25c2760d33da69e739ba1f92da9b/cmake/module/Maintenance.cmake#L99

💬 fjahr commented on pull request "doc: fix assumeutxo design doc link":
(https://github.com/bitcoin/bitcoin/pull/30819#issuecomment-2330220764)
ACK e5f7272ad322aa4eb7a7d6f531419a4d7aee4802

Thanks @marcofleon for spotting this!

💬 hodlinator commented on pull request "contrib: fix check-deps.sh to check for weak symbols":
(https://github.com/bitcoin/bitcoin/pull/30415#discussion_r1744564915)
What happened to **wallet_tool** in the latest push?

2 dependencies exist according to **/doc/design/libraries.md**:
```
libbitcoin_wallet_tool-->libbitcoin_wallet;
libbitcoin_wallet_tool-->libbitcoin_util;
```

💬 hebasto commented on issue "build: reproducibility issue with macOS Guix builds":
(https://github.com/bitcoin/bitcoin/issues/30815#issuecomment-2330244811)
@fanquake @TheCharlatan

I wonder if binaries are reproducible on the _same_ machine during repeated builds?

💬 ryanofsky commented on pull request "contrib: fix check-deps.sh to check for weak symbols":
(https://github.com/bitcoin/bitcoin/pull/30415#discussion_r1744326718)
re: https://github.com/bitcoin/bitcoin/pull/30415#discussion_r1740531844

> Looks like this was merged

Thanks! Updated

💬 ryanofsky commented on pull request "contrib: fix check-deps.sh to check for weak symbols":
(https://github.com/bitcoin/bitcoin/pull/30415#discussion_r1744573708)
I didn't dig into it but it appeared wallet_tool library disappeared in the conversion to cmake, so I removed references to it here. Probably libraries.md needs to be updated too though. There may be an existing cmake documentation PR where that change could be / has been made

💬 ryanofsky commented on pull request "contrib: fix check-deps.sh to check for weak symbols":
(https://github.com/bitcoin/bitcoin/pull/30415#issuecomment-2330254084)
Updated 76ef8113f70070ab1deeeb142977d46d8132c36e -> 3e4312eef78f233eb7ae1d7d85e497de34144f2e ([`pr/weakcheck.8`](https://github.com/ryanofsky/bitcoin/commits/pr/weakcheck.8) -> [`pr/weakcheck.9`](https://github.com/ryanofsky/bitcoin/commits/pr/weakcheck.9), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/weakcheck.8..pr/weakcheck.9)) to fix failing CI job due to changed default build directory (https://cirrus-ci.com/task/5141392714891264?logs=ci#L5325)