📝 fanquake opened a pull request: "build: fix version number post CMake"
(https://github.com/bitcoin/bitcoin/pull/30729)
CMake was merged after branching-off for `28.x`.

👍 TheCharlatan approved a pull request: "build: fix version number post CMake"
(https://github.com/bitcoin/bitcoin/pull/30729#pullrequestreview-2265791256)
ACK 680f05ee98e4d7978e2c4f07fdbb8bc0d178c497

👍 vasild approved a pull request: "build: fix version number post CMake"
(https://github.com/bitcoin/bitcoin/pull/30729#pullrequestreview-2265792811)
ACK 680f05ee98e4d7978e2c4f07fdbb8bc0d178c497

💬 hebasto commented on pull request "build: fix version number post CMake":
(https://github.com/bitcoin/bitcoin/pull/30729#issuecomment-2314904663)
ACK 680f05ee98e4d7978e2c4f07fdbb8bc0d178c497

🚀 fanquake merged a pull request: "fuzz: Add missing fuzz targets to cmake build"
(https://github.com/bitcoin/bitcoin/pull/30712)

🚀 fanquake merged a pull request: "build: fix version number post CMake"
(https://github.com/bitcoin/bitcoin/pull/30729)

✅ hebasto closed a pull request: "depends: Set `CMAKE_SYSTEM_VERSION` for CMake builds"
(https://github.com/bitcoin/bitcoin/pull/30465)

✅ hebasto closed a pull request: "depends: Amend handling flags environment variables"
(https://github.com/bitcoin/bitcoin/pull/30477)

💬 fanquake commented on pull request "depends: Fix CMake-generated `libzmq.pc` file":
(https://github.com/bitcoin/bitcoin/pull/30508#discussion_r1734450582)
Isn't an upstream commit? Can just drop the commit/author/date etc.

💬 fanquake commented on pull request "depends: Set `CMAKE_SYSTEM_VERSION` for CMake builds":
(https://github.com/bitcoin/bitcoin/pull/30465#issuecomment-2314986439)
> Concept ACK, but we need more docs here.
> I can't tell (even from looking at the CMake docs) what macOS should be set to and why you've chosen this value
> I can only assume that the Linux value means "minimum kernel version" for the sake of kernel headers, but I don't see that in the docs either
> Agree with @fanquake that it's not clear how this affects our other version vars. Which take precedence?

Where did this get followed up on?

📝 fanquake opened a pull request: "guix: Bump time machine to 53396a22afc04536ddf75d8f82ad2eafa5082725"
(https://github.com/bitcoin/bitcoin/pull/30730)
Followup to #30511.
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=9aa38f98cbd41644abe2c43bb4f44f74df642df2 landed.

Linux headers `6.1.102` -> `6.1.106`

💬 hebasto commented on pull request "depends: Fix CMake-generated `libzmq.pc` file":
(https://github.com/bitcoin/bitcoin/pull/30508#discussion_r1734465759)
Amended per your request.

👋 hebasto's pull request is ready for review: "build: Remove Autotools-based build system"
(https://github.com/bitcoin/bitcoin/pull/30664)

📝 fanquake opened a pull request: "build: remove old MSVC build system"
(https://github.com/bitcoin/bitcoin/pull/30731)
This has been superseded by CMake, and should not be blocked on anything for removal.

👍 stickies-v approved a pull request: "refactor: Replace ParseHex with consteval ""_hex literals"
(https://github.com/bitcoin/bitcoin/pull/30377#pullrequestreview-2265810088)
re-ACK dae42d474d04168fba077f30bf5113721e9fc108

💬 stickies-v commented on pull request "refactor: Replace ParseHex with consteval ""_hex literals":
(https://github.com/bitcoin/bitcoin/pull/30377#discussion_r1734485435)
I'm happy to keep things as is for now, this can be considered in follow-ups indeed.

💬 stickies-v commented on pull request "refactor: Replace ParseHex with consteval ""_hex literals":
(https://github.com/bitcoin/bitcoin/pull/30377#discussion_r1734398828)
grammar nit: https://grammarist.com/usage/alternately-vs-alternatively/
```suggestion
* declaring local variables if hex strings are large. Alternatively, variables
```

💬 stickies-v commented on pull request "refactor: Replace ParseHex with consteval ""_hex literals":
(https://github.com/bitcoin/bitcoin/pull/30377#discussion_r1734481968)
Note: the `_hex_v` operator is currently unused, except for in unit tests on this operator:

<details>
<summary>git diff on dae42d474d</summary>

```diff
diff --git a/src/test/util_tests.cpp b/src/test/util_tests.cpp
index 46eca2f0d8..ab521f5628 100644
--- a/src/test/util_tests.cpp
+++ b/src/test/util_tests.cpp
@@ -158,10 +158,6 @@ BOOST_AUTO_TEST_CASE(parse_hex)
auto hex_literal_span{MakeUCharSpan(hex_literal_array)};
BOOST_CHECK_EQUAL_COLLECTIONS(hex_literal_span.begin(),
...

👍 fanquake approved a pull request: "depends: Fix CMake-generated `libzmq.pc` file"
(https://github.com/bitcoin/bitcoin/pull/30508#pullrequestreview-2265955175)
ACK 371910a7682ecdaf86b3e65753667746add1ecd2

🚀 fanquake merged a pull request: "depends: Fix CMake-generated `libzmq.pc` file"
(https://github.com/bitcoin/bitcoin/pull/30508)