📝 achow101 opened a pull request: "[28.x] Bump to 28.0rc1"
(https://github.com/bitcoin/bitcoin/pull/30726)
* Bump version to 28.0rc1
* Generated manpages
* Generated example bitcoin.conf
* Point release notes to wiki

💬 brunoerg commented on pull request "fuzz: fix timeout in `crypto_fschacha20poly1305`":
(https://github.com/bitcoin/bitcoin/pull/30725#issuecomment-2313117709)
cc: @stratospher

🤔 hebasto reviewed a pull request: "[28.x] Bump to 28.0rc1"
(https://github.com/bitcoin/bitcoin/pull/30726#pullrequestreview-2264076708)
ACK bd45bc611b8b245d0a6bc8e0f5a224b0642f06d0.

💬 achow101 commented on pull request "bench: [refactor] iwyu":
(https://github.com/bitcoin/bitcoin/pull/30716#issuecomment-2313166416)
ACK fab0e834b8cf906c286ebbeed86eca8d65854f75

🚀 achow101 merged a pull request: "bench: [refactor] iwyu"
(https://github.com/bitcoin/bitcoin/pull/30716)

💬 achow101 commented on pull request "refactor: Allow CScript construction from any std::input_iterator":
(https://github.com/bitcoin/bitcoin/pull/29369#issuecomment-2313190754)
ACK fa7b9b99a2ed466d1765d748f4a59c2f581b974f

🚀 achow101 merged a pull request: "refactor: Allow CScript construction from any std::input_iterator"
(https://github.com/bitcoin/bitcoin/pull/29369)

🤔 theuni reviewed a pull request: "refactor: Allow CScript construction from any std::input_iterator"
(https://github.com/bitcoin/bitcoin/pull/29369#pullrequestreview-2264150207)
Post-merge utACK fa7b9b99a2ed466d1765d748f4a59c2f581b974f. I had a similar commit while hacking on allocators a while back: https://github.com/theuni/bitcoin/commit/3d34f21931226e7c39fb0cfcfe3581c3dfa3cc0f . This is even more elegant :)

💬 stickies-v commented on pull request "Bugfix: Ensure Atomicity in Wallet Settings Updates from Chain Interface":
(https://github.com/bitcoin/bitcoin/pull/30697#issuecomment-2313236101)
I wish this hadn't been merged so quickly as I was still working on reviewing this, but I understand getting this in before `28.x` branch off is helpful. I'm not a big fan of extending the `Chain` interface with non-chainstate related functions, that's a wrong direction imo. I think rebasing this PR on something like https://github.com/stickies-v/bitcoin/commit/53acb88072ce4450d4cc3f16c40b05d8382e7287 would have been a more elegant base.

Also note that this PR did not update `Node::updateRwSe
...

💬 ryanofsky commented on pull request "Bugfix: Ensure Atomicity in Wallet Settings Updates from Chain Interface":
(https://github.com/bitcoin/bitcoin/pull/30697#issuecomment-2313273295)
> I'm not a big fan of extending the `Chain` interface with non-chainstate related functions, that's a wrong direction imo.

It would be be nice to split up the Chain interface or just rename it to reflect way it is used, but it probably makes sense for wallet to use some interface class to read and write settings instead of using ArgsManager directly as in https://github.com/stickies-v/bitcoin/commit/53acb88072ce4450d4cc3f16c40b05d8382e7287. Wallet code originally did used ArgsManager directl
...

👍 theuni approved a pull request: "build: Introduce CMake-based build system"
(https://github.com/bitcoin/bitcoin/pull/30454#pullrequestreview-2264222354)
I haven't reviewed this exact series in detail, but I believe I reviewed it all as it passed through @heabsto's staging branch.

Quickly tested this PR merged into master, with depends on Linux x86-64.

With the understanding that there will be a flurry of follow-up PRs to clean up some things requested here, along with the deletion of autotools:

ACK 41051290ab3b6c36312cec26a27f787cea9961b4.

💬 stratospher commented on pull request "fuzz: fix timeout in `crypto_fschacha20poly1305`":
(https://github.com/bitcoin/bitcoin/pull/30725#issuecomment-2313312086)
Concept ACK. (running it locally, will ACK after that!)
did you check if the timeout happens in `crypto_aeadchacha20poly1305` too?

✅ fjahr closed an issue: "AssumeUTXO Mainnet Readiness Tracking"
(https://github.com/bitcoin/bitcoin/issues/29616)

💬 fjahr commented on issue "AssumeUTXO Mainnet Readiness Tracking":
(https://github.com/bitcoin/bitcoin/issues/29616#issuecomment-2313320794)
While there are still a few nice improvements to review and merge, this issue has achieved its main purpose and can be closed with the merge of #28553. If someone wants to open a follow-up issue that's great but I think as things stand now the existing open PRs are easy enough to keep track of.

It's also possible that we will see more new feedback come in when the feature starts to get adoption after the release of v28 but we can still open a follow-up issue that matches whatever structure we
...

💬 github12101 commented on issue "b-msghand[4988] general protection fault":
(https://github.com/bitcoin/bitcoin/issues/30706#issuecomment-2313344355)
> > > Was there anything unusual in the debug log before the crash?
>
> > Logs contains nothing else worth mentioning, machine continues to run as intended.
>
> Do you mean the machine logs contain nothing worth mentioning or the Bitcoin Core `debug.log`?
>
> Just in case you are not aware: Bitcoin Core writes to a `debug.log` file in your data directory (where the blockchain is stored too). It would be useful to know what Bitcoin Core logged at around `2024-08-23 23:47:55 BST`.

Of c
...

💬 github12101 commented on issue "b-msghand[4988] general protection fault":
(https://github.com/bitcoin/bitcoin/issues/30706#issuecomment-2313364188)
> The debug symbols are separately produced by guix and the downloads are on https://bitcoincore.org/bin/bitcoin-core-27.1/. In this case it would be `x86_64-linux-gnu-debug`.

That's great, thank you! Now I have upgraded to bitcoin-core-27.1 and debug symbols are downloaded.
Is there anything else I should do before next crash (if it ever happens), regarding debugging symbols? How to "tell" gdb that I have them? Thanks.

🚀 achow101 merged a pull request: "[28.x] Bump to 28.0rc1"
(https://github.com/bitcoin/bitcoin/pull/30726)

💬 mzumsande commented on pull request "rpc: Add test-only RPCs under `-test=<option>` flag":
(https://github.com/bitcoin/bitcoin/pull/30717#discussion_r1733431082)
`stopatheight` is also frequently used for benchmarks on mainnet, most recently in #28280. The `-checkXYZ ` startup options that can help debug issues on all networks and I've run some of them on several occasions on mainnet and signet.

Many of the options are debug-only because they are meant to only be used by devs testing new things, but that doesn't mean they can only be useful regtest - often it's helpful to test things on other networks too.

I think that restricting to regtest should
...

💬 achow101 commented on pull request "node: reduce unsafe uint256S usage":
(https://github.com/bitcoin/bitcoin/pull/30569#issuecomment-2313472718)
ACK 18d65d27726bf9fc7629b8e794047a10c9cf6156

💬 TheCharlatan commented on pull request "multiprocess: Add -ipcbind option to bitcoin-node":
(https://github.com/bitcoin/bitcoin/pull/30509#discussion_r1732716844)
Nit: There is a problem with the indentation here.