💬 maflcko commented on pull request "Pre-28.x branch off version bump and doc updates":
(https://github.com/bitcoin/bitcoin/pull/30719#discussion_r1733082202)
md, not mediawiki?

💬 maflcko commented on pull request "Pre-28.x branch off version bump and doc updates":
(https://github.com/bitcoin/bitcoin/pull/30719#issuecomment-2312859777)
ACK d3fd608100f6f4aff2a9f7a25b43f6c5ae065024 after typo fix

💬 achow101 commented on pull request "seeds: Pull additional nodes from my seeder and update fixed seeds":
(https://github.com/bitcoin/bitcoin/pull/30008#issuecomment-2312860231)
> I wasn't referring to the removal of the manually curated addresses in `nodes_main_manual.txt` but to the fact that there won't be any Onion or I2P seeds hardcoded into the binary at all (via `src/chainparamsseeds.h`), which I believe is an accident.

Yes, just noticed that too.

I've added #30695 to the milestone to get those added back in.

💬 achow101 commented on pull request "Pre-28.x branch off version bump and doc updates":
(https://github.com/bitcoin/bitcoin/pull/30719#discussion_r1733084845)
Fixed

💬 maflcko commented on pull request "Pre-28.x branch off version bump and doc updates":
(https://github.com/bitcoin/bitcoin/pull/30719#issuecomment-2312875597)
lgtm ACK 1bf9b706583572b1211762ec6ee5368bb8a2f2cd

💬 achow101 commented on pull request "seeds: Add additional seed source and bump uptime requirements for Onion and I2P nodes":
(https://github.com/bitcoin/bitcoin/pull/30695#issuecomment-2312886567)
ACK b061b3510585a1fe113cc9d1af65852b155aba45

Instruction updates look correct; did not check any of the changed seeds but did check that i2p and onion mainnet seeds have been readded.

If anyone has a testnet crawler, we probably want to have additional sources for testnet and add more i2p and onion testnet seeds.

💬 TheCharlatan commented on pull request "multiprocess: Add IPC wrapper for Mining interface":
(https://github.com/bitcoin/bitcoin/pull/30510#discussion_r1732637930)
Nit (clang-format): Missing space after `template`.

👍 TheCharlatan approved a pull request: "multiprocess: Add IPC wrapper for Mining interface"
(https://github.com/bitcoin/bitcoin/pull/30510#pullrequestreview-2262976938)
ACK c538ec69f266b51c893a374a4bb82796ede3d7cb

💬 instagibbs commented on pull request "fuzz: Test headers pre-sync through p2p":
(https://github.com/bitcoin/bitcoin/pull/30661#issuecomment-2312928188)
I think some text in the fuzz case itself would help motivate what it's trying to accomplish. Right now it's pretty bare so I'm not sure what kinds of bugs/issues it is trying to unsurface.

💬 maflcko commented on pull request "fuzz: fix timeout in `crypto_fschacha20poly1305`":
(https://github.com/bitcoin/bitcoin/pull/30725#issuecomment-2312933942)
lgtm ACK c6d2d1cb66b8c0c15b1a6a712e196869b4bf3040

💬 maflcko commented on pull request "fuzz: fix timeout in `crypto_fschacha20poly1305`":
(https://github.com/bitcoin/bitcoin/pull/30725#issuecomment-2312939463)
https://cirrus-ci.com/task/6004238088667136?logs=ci#L5367

```
crypto_fschacha20poly1305 #83 DONE cov: 3202 ft: 21189 corp: 80/12762b lim: 1368 exec/s: 2 rss: 119Mb
```


https://cirrus-ci.com/task/6249653828583424?logs=ci#L5217

```
crypto_fschacha20poly1305 #83 DONE cov: 3202 ft: 21417 corp: 80/12762b lim: 1368 exec/s: 1 rss: 121Mb

💬 laanwj commented on pull request "net: Replace libnatpmp with built-in PCP+NATPMP implementation":
(https://github.com/bitcoin/bitcoin/pull/30043#discussion_r1733163380)
yeah no problem, i'll push the change as a commit (after rebase, i guess)

🤔 fjahr reviewed a pull request: "seeds: Add additional seed source and bump uptime requirements for Onion and I2P nodes"
(https://github.com/bitcoin/bitcoin/pull/30695#pullrequestreview-2263826447)
utACK b061b3510585a1fe113cc9d1af65852b155aba45

I have reviewed the changes and verified that the included files generate the included `chainparamsseeds.h`. I have not tested the seed nodes but I did a quick plausibility check on the txt file changes.

Fun side note: TIL that there is a stable node with a single digit ASN, AS9, which is Carnegie Mellon University.

💬 fjahr commented on pull request "seeds: Add additional seed source and bump uptime requirements for Onion and I2P nodes":
(https://github.com/bitcoin/bitcoin/pull/30695#discussion_r1733130317)
nit: It's clear what belongs to who because all the other links have the names in the URL but still might be nicer to be explicit in the future. Ignore if you don't have to retouch.

```suggestion
virtu's crawler (21.ninja), and fjahr's community AS map data. Run the following commands from the
```

✅ achow101 closed an issue: "wallet: setting changes are subject to race conditions"
(https://github.com/bitcoin/bitcoin/issues/30620)

🚀 achow101 merged a pull request: "Bugfix: Ensure Atomicity in Wallet Settings Updates from Chain Interface"
(https://github.com/bitcoin/bitcoin/pull/30697)

👍 tdb3 approved a pull request: "Pre-28.x branch off version bump and doc updates"
(https://github.com/bitcoin/bitcoin/pull/30719#pullrequestreview-2263953998)
re ACK 1bf9b706583572b1211762ec6ee5368bb8a2f2cd

🚀 achow101 merged a pull request: "seeds: Add additional seed source and bump uptime requirements for Onion and I2P nodes"
(https://github.com/bitcoin/bitcoin/pull/30695)

🚀 achow101 merged a pull request: "Pre-28.x branch off version bump and doc updates"
(https://github.com/bitcoin/bitcoin/pull/30719)

📝 achow101 opened a pull request: "[28.x] Bump to 28.0rc1"
(https://github.com/bitcoin/bitcoin/pull/30726)
* Bump version to 28.0rc1
* Generated manpages
* Generated example bitcoin.conf
* Point release notes to wiki