💬 github12101 commented on issue "b-msghand[4988] general protection fault":
(https://github.com/bitcoin/bitcoin/issues/30706#issuecomment-2312795052)
> The guix debug symbols are split from the `bitcoind` you are using. So someone would have download them before demangling. I tried to do that, but for some reason I had no success. I am not a build system expert, so I am not sure where the problem lies.

My knowledge goes only as far as adding `deb http://deb.debian.org/debian-debug/ bookworm-debug main` to the sources.list and then installing *-dbgsym packages. But that will not include bitcoind. If someone has any instructions how to get d
...

👍 hebasto approved a pull request: "build: add `standard branch-protection` to hardening flags for aarch64-linux"
(https://github.com/bitcoin/bitcoin/pull/30433#pullrequestreview-2263686690)
ACK 03171002e5de04953ecd220cce40313f42315fcb. Tested in both cross and native build scenarios.

💬 maflcko commented on pull request "fuzz: fix timeout in `crypto_fschacha20poly1305`":
(https://github.com/bitcoin/bitcoin/pull/30725#issuecomment-2312811224)
Please cross-link to the issue (https://github.com/bitcoin/bitcoin/issues/30505)

💬 0xB10C commented on issue "b-msghand[4988] general protection fault":
(https://github.com/bitcoin/bitcoin/issues/30706#issuecomment-2312820074)
>> Was there anything unusual in the debug log before the crash?

> Logs contains nothing else worth mentioning, machine continues to run as intended.

Do you mean the machine logs contain nothing worth mentioning or the Bitcoin Core `debug.log`?

Just in case you are not aware: Bitcoin Core writes to a `debug.log` file in your data directory (where the blockchain is stored too). It would be useful to know what Bitcoin Core logged at around `2024-08-23 23:47:55 BST`.

💬 hebasto commented on pull request "fuzz: Add missing fuzz targets to cmake build":
(https://github.com/bitcoin/bitcoin/pull/30712#discussion_r1733048320)
I've noticed the same -- https://github.com/hebasto/bitcoin/issues/341#issuecomment-2310510852:
> However, on my machine, I had to add `--timeout-factor=4`.

💬 maflcko commented on issue "b-msghand[4988] general protection fault":
(https://github.com/bitcoin/bitcoin/issues/30706#issuecomment-2312826024)
The debug symbols are separately produced by guix and the downloads are on https://bitcoincore.org/bin/bitcoin-core-27.1/. In this case it would be `x86_64-linux-gnu-debug`.

💬 maflcko commented on pull request "Pre-28.x branch off version bump and doc updates":
(https://github.com/bitcoin/bitcoin/pull/30719#issuecomment-2312839785)
> lgtm, should also do doc/release-notes/release-notes-27064.md

Added to the wiki, but still needs to be removed here.

👍 hebasto approved a pull request: "Pre-28.x branch off version bump and doc updates"
(https://github.com/bitcoin/bitcoin/pull/30719#pullrequestreview-2263736245)
ACK d3fd608100f6f4aff2a9f7a25b43f6c5ae065024.

💬 achow101 commented on pull request "Pre-28.x branch off version bump and doc updates":
(https://github.com/bitcoin/bitcoin/pull/30719#issuecomment-2312855550)
> lgtm, should also do doc/release-notes/release-notes-27064.md

Good catch, removed it.

💬 maflcko commented on pull request "Pre-28.x branch off version bump and doc updates":
(https://github.com/bitcoin/bitcoin/pull/30719#discussion_r1733082202)
md, not mediawiki?

💬 maflcko commented on pull request "Pre-28.x branch off version bump and doc updates":
(https://github.com/bitcoin/bitcoin/pull/30719#issuecomment-2312859777)
ACK d3fd608100f6f4aff2a9f7a25b43f6c5ae065024 after typo fix

💬 achow101 commented on pull request "seeds: Pull additional nodes from my seeder and update fixed seeds":
(https://github.com/bitcoin/bitcoin/pull/30008#issuecomment-2312860231)
> I wasn't referring to the removal of the manually curated addresses in `nodes_main_manual.txt` but to the fact that there won't be any Onion or I2P seeds hardcoded into the binary at all (via `src/chainparamsseeds.h`), which I believe is an accident.

Yes, just noticed that too.

I've added #30695 to the milestone to get those added back in.

💬 achow101 commented on pull request "Pre-28.x branch off version bump and doc updates":
(https://github.com/bitcoin/bitcoin/pull/30719#discussion_r1733084845)
Fixed

💬 maflcko commented on pull request "Pre-28.x branch off version bump and doc updates":
(https://github.com/bitcoin/bitcoin/pull/30719#issuecomment-2312875597)
lgtm ACK 1bf9b706583572b1211762ec6ee5368bb8a2f2cd

💬 achow101 commented on pull request "seeds: Add additional seed source and bump uptime requirements for Onion and I2P nodes":
(https://github.com/bitcoin/bitcoin/pull/30695#issuecomment-2312886567)
ACK b061b3510585a1fe113cc9d1af65852b155aba45

Instruction updates look correct; did not check any of the changed seeds but did check that i2p and onion mainnet seeds have been readded.

If anyone has a testnet crawler, we probably want to have additional sources for testnet and add more i2p and onion testnet seeds.

💬 TheCharlatan commented on pull request "multiprocess: Add IPC wrapper for Mining interface":
(https://github.com/bitcoin/bitcoin/pull/30510#discussion_r1732637930)
Nit (clang-format): Missing space after `template`.

👍 TheCharlatan approved a pull request: "multiprocess: Add IPC wrapper for Mining interface"
(https://github.com/bitcoin/bitcoin/pull/30510#pullrequestreview-2262976938)
ACK c538ec69f266b51c893a374a4bb82796ede3d7cb

💬 instagibbs commented on pull request "fuzz: Test headers pre-sync through p2p":
(https://github.com/bitcoin/bitcoin/pull/30661#issuecomment-2312928188)
I think some text in the fuzz case itself would help motivate what it's trying to accomplish. Right now it's pretty bare so I'm not sure what kinds of bugs/issues it is trying to unsurface.

💬 maflcko commented on pull request "fuzz: fix timeout in `crypto_fschacha20poly1305`":
(https://github.com/bitcoin/bitcoin/pull/30725#issuecomment-2312933942)
lgtm ACK c6d2d1cb66b8c0c15b1a6a712e196869b4bf3040

💬 maflcko commented on pull request "fuzz: fix timeout in `crypto_fschacha20poly1305`":
(https://github.com/bitcoin/bitcoin/pull/30725#issuecomment-2312939463)
https://cirrus-ci.com/task/6004238088667136?logs=ci#L5367

```
crypto_fschacha20poly1305 #83 DONE cov: 3202 ft: 21189 corp: 80/12762b lim: 1368 exec/s: 2 rss: 119Mb
```


https://cirrus-ci.com/task/6249653828583424?logs=ci#L5217

```
crypto_fschacha20poly1305 #83 DONE cov: 3202 ft: 21417 corp: 80/12762b lim: 1368 exec/s: 1 rss: 121Mb