⚠️ bitcoinchunk opened an issue: "Question on Changing Bitcoin Blockchain Data Directory in Linux Without Redownloading"
(https://github.com/bitcoin/bitcoin/issues/30672)
Hello Bitcoin Community,

I’m looking for some guidance on how to change the default data directory for the Bitcoin blockchain on a Linux system. I want to move the blockchain data to a different drive with more space, but I’d prefer not to download the entire blockchain from scratch.

Could someone walk me through the steps to move the data seamlessly, ensuring that all configurations are correctly updated? Any tips to avoid issues during the process would be greatly appreciated.

Thanks
...

💬 whitslack commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1721043065)
> I'm doing some test builds on Windows and it was a bit of a treasure hunt to find the binaries.

@sipsorcery: Rather than going on a treasure hunt, wouldn't you "install" the built product to a staging directory and then produce your distributable package from there? That way you'll pick up all the bits that the build system wants you to have and none that it doesn't.

💬 whitslack commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#issuecomment-2295367078)
> > One small gripe: When we enter the install phase, CMake always rebuilds `src/clientversion.cpp`, which forces a relink of all target executables. It would be better if `ninja install` would not rebuild anything.
>
> Is this still an issue with the recent update?

@hebasto: Nope! It works as expected at 41051290ab3b6c36312cec26a27f787cea9961b4. :grin: Thanks!

💬 johndpierre1 commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#issuecomment-2295367360)
Who is using my email to text you
I have been hacked


On Sun, Aug 18, 2024 at 20:30 Matt Whitlock ***@***.***>
wrote:

> ***@***.**** commented on this pull request.
> ------------------------------
>
> In doc/build-windows-msvc.md
> <https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1721043065>:
>
> > +
> +### 4. Building with Dynamic Linking with GUI
> +
> +```
> +cmake -B build --preset vs2022 -DBUILD_GUI=ON # It might take a while if the vcpkg binary cache is unpop
...

💬 johndpierre1 commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#issuecomment-2295367666)
I don’t know who I’m talking to right now everything is confusing me here

John


On Sun, Aug 18, 2024 at 20:36 John D Pierre ***@***.***> wrote:

>
> Who is using my email to text you
> I have been hacked
>
>
> On Sun, Aug 18, 2024 at 20:30 Matt Whitlock ***@***.***>
> wrote:
>
>> ***@***.**** commented on this pull request.
>> ------------------------------
>>
>> In doc/build-windows-msvc.md
>> <https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1721043065>:
>>
>> >
...

💬 paplorinc commented on pull request "refactor: Replace ParseHex with consteval HexLiteral":
(https://github.com/bitcoin/bitcoin/pull/30377#discussion_r1721044730)
> But nice thing is neither of these should be necessary if cscript supports std::array

Would it be too early for me to provide a separate PR for that?

✅ achow101 closed an issue: "Question on Changing Bitcoin Blockchain Data Directory in Linux Without Redownloading"
(https://github.com/bitcoin/bitcoin/issues/30672)

💬 achow101 commented on issue "Question on Changing Bitcoin Blockchain Data Directory in Linux Without Redownloading":
(https://github.com/bitcoin/bitcoin/issues/30672#issuecomment-2295371762)
Usually the issue tracker is used to track technical issues related to the Bitcoin Core code base. General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com) or the `#bitcoin` IRC channel on Libera Chat.

💬 sipsorcery commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1721048474)
> @sipsorcery: Rather than going on a treasure hunt, wouldn't you "install" the built product to a staging directory and then produce your distributable package from there? That way you'll pick up all the bits that the build system wants you to have and none that it doesn't.

I think that would be a reasonable soln. I'm used to the way msvc places all the executables in a single directory. GIven the `cmake --install` command provides an option to achieve the same that would work.

As mentio
...

👍 TheCharlatan approved a pull request: "validation: improve m_best_header tracking"
(https://github.com/bitcoin/bitcoin/pull/30666#pullrequestreview-2244388019)
ACK c9bf06a531617fdd70b64e23572931af2b969828

💬 TheCharlatan commented on pull request "validation: improve m_best_header tracking":
(https://github.com/bitcoin/bitcoin/pull/30666#discussion_r1721048165)
It might be a good idea to expand this a bit:
```diff
@@ -45 +45 @@ class InvalidateTest(BitcoinTestFramework):
- tip = int(self.nodes[0].getbestblockhash(), 16)
+ tip = self.nodes[0].getbestblockhash()
@@ -47 +47 @@ class InvalidateTest(BitcoinTestFramework):
- block = create_block(tip, create_coinbase(self.nodes[0].getblockcount()), block_time, version=4)
+ block = create_block(int(tip, 16), create_coinbase(self.nodes[0].getblockcount()), block_time, version=
...

💬 hodlinator commented on pull request "test: Shut down framework cleanly on RPC connection failure":
(https://github.com/bitcoin/bitcoin/pull/30660#issuecomment-2295379703)
> Can you explain this a bit more? I think optimizing the test framework to cleanly shut down on a failure is a bit premature, and may not be needed.

As long as the additional complexity and maintenance burden is low, I think it is worth having a cleaner shutdown to avoid muddying the waters for people trying to figure out root causes.

> However, if a failing test may leave behind a dangling bitcoind process, this seems like something to fix, because it will otherwise lead to test warnings
...

🤔 tdb3 reviewed a pull request: "addrman: change internal id counting to int64_t"
(https://github.com/bitcoin/bitcoin/pull/30568#pullrequestreview-2244390291)
Approach ACK
Reviewed a bit more. Just nits.

💬 tdb3 commented on pull request "addrman: change internal id counting to int64_t":
(https://github.com/bitcoin/bitcoin/pull/30568#discussion_r1721050883)
nit: The return type in the Doxygen content could be adjusted.
```diff
- * @return int The nid of the entry. If the addrman position is empty or not found, returns -1.
+ * @return nid_type The nid of the entry. If the addrman position is empty or not found, returns -1.
* */
nid_type GetEntry(bool use_tried, size_t bucket, size_t position) const EXCLUSIVE_LOCKS_REQUIRED(cs);
```

nit / thinking out loud: Returning `-1` is a remnant of the previous type being a pla
...

📝 andrewtoth opened a pull request: "coins: remove logic for spent-and-FRESH cache entries and writing non-DIRTY entries"
(https://github.com/bitcoin/bitcoin/pull/30673)
Following up from https://github.com/bitcoin/bitcoin/pull/28280#discussion_r1655477509, which suggested a revival of #18746.

`GetCoin` will never return `true` for a spent entry, so we can safely assume that any entry we fetch will not be spent. This lets us remove the only non-test code path which adds a FRESH-but-not-DIRTY entry to the flagged linked list. This in turn ensures all entries being sent to `BatchWrite` are `DIRTY` entries.

This is a pure refactor removing dead code which han
...

💬 andrewtoth commented on pull request "Don't empty dbcache on prune flushes: >30% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/28280#discussion_r1721074014)
Done in #30673 30673

💬 andrewtoth commented on pull request "Don't empty dbcache on prune flushes: >30% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/28280#discussion_r1721074195)
Revived in #30673

💬 andrewtoth commented on pull request "Don't empty dbcache on prune flushes: >30% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/28280#discussion_r1721074348)
Done in #30673

💬 gmaxwell commented on pull request "Halt processing of unrequested transactions v2":
(https://github.com/bitcoin/bitcoin/pull/30572#issuecomment-2295433373)
@vasild I don't think ariaid's initial justification for the PR was the most important one. Sometimes people propose doing the right things for less than the most important reasons. If one were to judge things only by their initial proposals then it would open a very easy attack on development-- just keep proposing good things with bad justification to make sure they won't get done. :)

The amount of CPU-work per byte sent might only be increased by 50% by forcing INV use. E.g. say an at
...

💬 gmaxwell commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-2295439986)
Private broadcast can also reduce privacy. I think the weakness is a tossup vs the obvious alternative (run ordinary connections exclusively over Tor) so it's not a reason to not implement the feature, but it's worth discussing in order to understand the limits and see if mitigations are possible.

The issue on my mind is that Tor has little to no resistance to traffic analysis. The small amount of resistance it has is by quantizing messages into fixed size cells. Otherwise, it essentially
...