💬 paplorinc commented on pull request "refactor: Replace ParseHex with consteval HexLiteral":
(https://github.com/bitcoin/bitcoin/pull/30377#discussion_r1720801377)
(On phone, can't check)
Both of them produce a vector<unsigned char>, right?

💬 paplorinc commented on pull request "refactor: Replace ParseHex with consteval HexLiteral":
(https://github.com/bitcoin/bitcoin/pull/30377#discussion_r1720801552)
I mean both Vec and ToByteVector would work here, right?

📝 haydenbanz opened a pull request: "modified version"
(https://github.com/bitcoin/bitcoin/pull/30668)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ achow101 closed a pull request: "modified version"
(https://github.com/bitcoin/bitcoin/pull/30668)

📝 achow101 locked a pull request: "modified version"
(https://github.com/bitcoin/bitcoin/pull/30668)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 sipsorcery commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#issuecomment-2294985333)
I'm doing some test builds on Windows and it was a bit of a treasure hunt to find the binaries. The relevant doc states "CMake will put the resulting object files, libraries, and executables into a dedicated build directory.". Would it be worth listing the directories?

The Autotools Linux based builds put the binaries into a single obvious location. If that's tricky with cmake then maybe the next best thing is to list the locations where the binaries can be found?

Shouldn't this PR also re
...

💬 paplorinc commented on pull request "refactor: Replace ParseHex with consteval HexLiteral":
(https://github.com/bitcoin/bitcoin/pull/30377#discussion_r1720836846)
Thanks @ryanofsky

💬 fjahr commented on pull request "seeds: Pull additional nodes from my seeder and update fixed seeds":
(https://github.com/bitcoin/bitcoin/pull/30008#issuecomment-2294996033)
re-ACK 41ad84a00c20f54b520aab7f6f975231da0ee2d0

Only changes were addressing above (minor) comments: https://github.com/bitcoin/bitcoin/compare/7f55140007186cda876ad0a5da812e391cddbcc4..41ad84a00c20f54b520aab7f6f975231da0ee2d0

📝 tdb3 opened a pull request: "test: check xor.dat creation when missing"
(https://github.com/bitcoin/bitcoin/pull/30669)
Builds on PR #30657 by adding a check that `xor.dat` is created when missing.

Help states:
```
-blocksxor
Whether an XOR-key applies to blocksdir *.dat files. The created XOR-key
will be zeros for an existing blocksdir or when `-blocksxor=0` is
set, and random for a freshly initialized blocksdir. (default: 1)
```

💬 gmaxwell commented on pull request "[WIP] p2p: send not_found msgs for unknown, pruned or unwilling to share blocks":
(https://github.com/bitcoin/bitcoin/pull/30385#issuecomment-2295018823)
The assumeutxo node would just be a limited node, it'll offer the most recent blocks and none of the history. (it might have more history then it offers, as is the case of any other limited node.) Signaling in a more fine grained manner would have little to no value to the network, but would enable tracking the node around as it moves from IP to IP. In any case, it's no justification for not-found even that aside as we wouldn't want nodes wasting their resources to connect to one only to be t
...

💬 gmaxwell commented on pull request "cluster mempool: optimized candidate search":
(https://github.com/bitcoin/bitcoin/pull/30286#issuecomment-2295021559)
@sipa Though there may be other patterns which are a worst case even more worse than the particular lattice used for testing without those optimizations? If you've been searching for worst case examples for a long time with those optimizations in place you may have missed cases that would be worse without them. No?

💬 asolo525 commented on issue "utils: add support for `bitcoin-wallet` tool configuration file":
(https://github.com/bitcoin/bitcoin/issues/30421#issuecomment-2295122385)

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#issuecomment-2295181963)
> Shouldn't this PR also remove the build_msvc directory and related doc?

This is supposed to be done in a follow-up PR (see https://github.com/hebasto/bitcoin/pull/166 and https://github.com/bitcoin/bitcoin/pull/30664).

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#issuecomment-2295183828)
> I'm doing some test builds on Windows and it was a bit of a treasure hunt to find the binaries. The relevant doc states "CMake will put the resulting object files, libraries, and executables into a dedicated build directory.". Would it be worth listing the directories?
>
> The Autotools Linux based builds put the binaries into a single obvious location. If that's tricky with cmake then maybe the next best thing is to list the locations where the binaries can be found?

A solution similar
...

💬 sipsorcery commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1720944823)
It would be useful to know what the install command will do.

📝 paplorinc opened a pull request: "doc: Extend developer-notes with file-name-only debugging fix"
(https://github.com/bitcoin/bitcoin/pull/30670)
Split out of https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1714285678

While testing the new `cmake` build with [CLion](https://youtrack.jetbrains.com/issue/CPP-15850/Debugger-doesnt-stop-on-breakpoints-in-case-of-fdebug-prefix-map#focus=Comments-27-4926356.0-0), I noticed that the tests don't always stop at the set breakpoints, so I've updated the `developer-notes.md`, hoping it will be useful for others experiencing the same.

Added links to gdb and lldb documentations.

Ass
...

✅ paplorinc closed a pull request: "optimization: Optimize IsSpace function for common non-whitespace characters"
(https://github.com/bitcoin/bitcoin/pull/29602)

👋 paplorinc's pull request is ready for review: "test: Fuzz the human-readable part of bech32 as well"
(https://github.com/bitcoin/bitcoin/pull/30623)

⚠️ GregTonoski opened an issue: "bitcoind shouldn't be shutdown automatically despite wallet synchronisation error"
(https://github.com/bitcoin/bitcoin/issues/30671)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Bitcoind startup is terminated.

### Expected behaviour

bitcoind should complete startup and keep running successfully.

### Steps to reproduce

Step:
`$ ./bitcoind`

### Relevant log output

Result (logs):
Keys: 9 plaintext, 0 encrypted, 0 w/ metadata, 9 total. Unknown wallet records: 0
Wallet completed loading in 326ms
Error: Prune: last wallet synchronisation goes beyon
...

💬 sipsorcery commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1720958987)
Is this meant to be cmake not gmake?