🚀 achow101 merged a pull request: "contrib: support reading XORed blocks in linearize-data.py script"
(https://github.com/bitcoin/bitcoin/pull/30607)

💬 achow101 commented on pull request "guix: fix suggested fake date for openssl-1.1.1l":
(https://github.com/bitcoin/bitcoin/pull/29999#issuecomment-2284745959)
ACK 8fee5355ee1d2f2b410c548bac9e85f2a21a696d

Going to merge this while we figure out whether openssl 1.x is still required.

💬 LarryRuane commented on pull request "logging: use bitset for categories":
(https://github.com/bitcoin/bitcoin/pull/26697#discussion_r1714265458)
As I look at this again, I agree this is over-engineered (what do you think, @ryanofsky?). #26619 was my first attempt but someone suggested using `std::bitset` and I took that suggestion. But that approach (this PR) turned out to be more complicated than expected.

The one thing I like about the current approach is not having to specify all the bit shift values explicitly, such as `NET = (1 << 0)`, instead it's just a clean list. But that isn't much of an advantage.

Why don't I rebase #2
...

🚀 achow101 merged a pull request: "guix: fix suggested fake date for openssl-1.1.1l"
(https://github.com/bitcoin/bitcoin/pull/29999)

📝 maflcko reopened a pull request: "log: expand BCLog::LogFlags (categories) to 64 bits"
(https://github.com/bitcoin/bitcoin/pull/26619)
Increase the maximum number of logging categories from 32 to 64.

We're currently using 29 of the 32 available logging categories (there are only 3 remaining). It would be good to increase the limit soon; the fourth PR to be merged that adds a new logging category will be blocked until something like this is done.

This PR also adds a `TEST` category that uses the new range (`1ULL << 63`) in case there's a hidden assumption somewhere that the `BCLog::LogFlags` type is 32 bits. (Also added a
...

💬 maflcko commented on pull request "logging: use bitset for categories":
(https://github.com/bitcoin/bitcoin/pull/26697#discussion_r1714283665)
> both will be open and up to date, and reviewers can decide which to ACK (or maybe ACK both and a maintainer decides).

I haven't looked at the code or the bug here, but if this is a real bug that could be hit in production, acking and merging should not be done.

💬 paplorinc commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1714285678)
Note that with 80073c75d1218759f58ceefcb41b4fbc4a3d1ecd I could right click and debug and CLion would stop at a breakpoint, but with 67b1e236334f38ec4e4d2251dbdfb790f20ed88b (adding `debug-prefix-map`) it won't stop at breakpoints anymore.
<img width="500" src="https://github.com/user-attachments/assets/66651d62-2dc9-4fa7-9f8f-d45b240aa048">

But as stated in the docs, setting the `target.source-map` in `~/.lldbini` fixed debugging again.

👋 paplorinc's pull request is ready for review: "refactor: Migrate EmplaceCoinInternalDANGER to try_emplace"
(https://github.com/bitcoin/bitcoin/pull/30637)

💬 maflcko commented on pull request "net: Clarify that m_addr_local is only set once":
(https://github.com/bitcoin/bitcoin/pull/30617#issuecomment-2284780564)
Just to clarify: This should be a refactor (no behavior change for `bitcoind` users)

💬 achow101 commented on pull request "fuzz: a target for the block index database":
(https://github.com/bitcoin/bitcoin/pull/28209#issuecomment-2284803661)
ACK 86b38529d5014612c3e7bb59fdc4dad3bff2aa64

💬 LarryRuane commented on pull request "logging: use bitset for categories":
(https://github.com/bitcoin/bitcoin/pull/26697#discussion_r1714305448)
Hard to say if it's a bug, it's definitely not undefined behavior. This `any()` function is currently [used](https://github.com/bitcoin/bitcoin/pull/26697/files#diff-2ab59d52a34bfed0bded8d7c7ad995367b95dbb983b29efca5d2f56a59fa3ccbL339-L340) only by `qt` where it says, if there are any debug logs enabled, then display a bunch of extra debug stuff (which is a bit questionable, because the logging categories that are enabled may have nothing whatsoever to do with `qt`). So if the sequence vasild ou
...

💬 achow101 commented on pull request "optimization: Reduce cache lookups in CCoinsViewCache::FetchCoin":
(https://github.com/bitcoin/bitcoin/pull/30326#issuecomment-2284815826)
ACK 204ca67bba263018374fe86d7a6867362d09536f

🚀 achow101 merged a pull request: "fuzz: a target for the block index database"
(https://github.com/bitcoin/bitcoin/pull/28209)

💬 achow101 commented on pull request "contrib: asmap-tool - Compare ASMaps with respect to specific addresses":
(https://github.com/bitcoin/bitcoin/pull/30246#issuecomment-2284832694)
ACK 5215c925d1382e71c9e1d642fced8a152c629c7f

🚀 achow101 merged a pull request: "optimization: Reduce cache lookups in CCoinsViewCache::FetchCoin"
(https://github.com/bitcoin/bitcoin/pull/30326)

🚀 achow101 merged a pull request: "contrib: asmap-tool - Compare ASMaps with respect to specific addresses"
(https://github.com/bitcoin/bitcoin/pull/30246)

📝 paplorinc opened a pull request: "DO NOT MERGE: CCoinsCacheEntry move constructor Sonar fix"
(https://github.com/bitcoin/bitcoin/pull/30641)
Related to https://github.com/bitcoin/bitcoin/pull/28280#discussion_r1703187118

WIP: First, I have to make sure I can reproduce the Sonar warning, I'll push the fix after that.

💬 andrewtoth commented on pull request "DO NOT MERGE: CCoinsCacheEntry move constructor Sonar fix":
(https://github.com/bitcoin/bitcoin/pull/30641#issuecomment-2284885871)
@paplorinc you can mark this as a draft until you are ready to have it reviewed.

💬 fanquake commented on pull request "DO NOT MERGE: CCoinsCacheEntry move constructor Sonar fix":
(https://github.com/bitcoin/bitcoin/pull/30641#issuecomment-2284886011)
There's no need to open a PR with a TODO comment, for an issue which you haven't yet reproduced, for a tool we don't actively use.

Feel free re-open when you have an actual change to suggest.

Also, you can open draft PRs to indicate when changes are not ready for review.

✅ fanquake closed a pull request: "DO NOT MERGE: CCoinsCacheEntry move constructor Sonar fix"
(https://github.com/bitcoin/bitcoin/pull/30641)