💬 Sjors commented on pull request "multiprocess: Add -ipcbind option to bitcoin-node":
(https://github.com/bitcoin/bitcoin/pull/30509#discussion_r1714091657)
4137419b0170fa1e9ff9daacde57933f7c995b76: I have a hard hitting this, instead I tend to get a crash (on intel macOS):

For an existing path:

```
-ipcbind=unix://tmp
...
************************
EXCEPTION: NSt3__112system_errorE
Address already in use
bitcoin in AppInit()
```

Non-existing path that I don't have permission for:

```
-ipcbind=unix://root
...
************************
EXCEPTION: NSt3__112system_errorE
Read-only file system
bitcoin i
...

💬 Sjors commented on pull request "multiprocess: Add -ipcbind option to bitcoin-node":
(https://github.com/bitcoin/bitcoin/pull/30509#discussion_r1714085148)
4137419b0170fa1e9ff9daacde57933f7c995b76: In the mean time this has the nice side-effect of being able to run `src/bitcoin-gui -ipcbind=unix` (instead of `bitcoin-node`) and then connect to it with e.g. the miner demo `-ipcconnect=unix:gui.sock`.

See https://github.com/bitcoin/bitcoin/pull/30437#issuecomment-2226847354

💬 Sjors commented on pull request "multiprocess: Add -ipcbind option to bitcoin-node":
(https://github.com/bitcoin/bitcoin/pull/30509#discussion_r1714205805)
52917ad4be1ca574543e854fdc154e88d65ce57f: this could use a test.

Or maybe we can introduce something akin to `CNetAddr` for socket addresses? Fortunately this input can only be provided by the user, so we don't have to be overzealous about sanitising.

💬 achow101 commented on pull request "fuzz: improve `scriptpubkeyman` target":
(https://github.com/bitcoin/bitcoin/pull/30563#issuecomment-2284663808)
ACK 401cc4ec70d67ba2aa0e078d2fab214e1c40742c

💬 achow101 commented on pull request "wallet: fix blank legacy detection":
(https://github.com/bitcoin/bitcoin/pull/30621#discussion_r1714223454)
In 30f701317b4a674fea422766ac3ee179c9c6f554 "wallet: fix, detect blank legacy wallets in IsLegacy"

`IsLegacy()` is unnecessary, same as above.

💬 achow101 commented on pull request "wallet: fix blank legacy detection":
(https://github.com/bitcoin/bitcoin/pull/30621#discussion_r1714223083)
In 30f701317b4a674fea422766ac3ee179c9c6f554 "wallet: fix, detect blank legacy wallets in IsLegacy"

`IsLegacy()` is unnecessary here now since `GetLegacyScriptPubKeyMan()` also checks for `WALLET_FLAG_DESCRIPTORS`.

💬 achow101 commented on pull request "net: Clarify that m_addr_local is only set once":
(https://github.com/bitcoin/bitcoin/pull/30617#issuecomment-2284691570)
ACK fa6fe432075df5e0eceb1ccd85038159cc820ccc

🤔 mzumsande reviewed a pull request: "net: Clarify that m_addr_local is only set once"
(https://github.com/bitcoin/bitcoin/pull/30617#pullrequestreview-2233791304)
utACK fa6fe432075df5e0eceb1ccd85038159cc820ccc

✅ achow101 closed an issue: "scriptpubkeyman fuzz target TopUp is slow (2/N)"
(https://github.com/bitcoin/bitcoin/issues/30541)

🚀 achow101 merged a pull request: "fuzz: improve `scriptpubkeyman` target"
(https://github.com/bitcoin/bitcoin/pull/30563)

💬 achow101 commented on pull request "contrib: support reading XORed blocks in linearize-data.py script":
(https://github.com/bitcoin/bitcoin/pull/30607#issuecomment-2284704597)
ACK 77ff0ec1f185b818b30877de2bedc1750319e6c4

💬 maflcko commented on issue "contrib: Automation for Bitcoin Full Node Deployment":
(https://github.com/bitcoin/bitcoin/issues/30638#issuecomment-2284705416)
> **Ansible/Monitoring:** I agree, tooling preferences/ideologies are a thing now, I am agnostic, I adapt, my questions:
>
> * What tooling do you, Bitcoin core devs, and community support for system provisioning?
>
> * What tooling for monitoring?

Bitcoin Core is also agnostic, because it should work with any monitoring or provisioning solution out there out of the box with no further changes needed. (There are many out there, including graphana, or self-written ones)

The sa
...

🚀 achow101 merged a pull request: "contrib: support reading XORed blocks in linearize-data.py script"
(https://github.com/bitcoin/bitcoin/pull/30607)

💬 achow101 commented on pull request "guix: fix suggested fake date for openssl-1.1.1l":
(https://github.com/bitcoin/bitcoin/pull/29999#issuecomment-2284745959)
ACK 8fee5355ee1d2f2b410c548bac9e85f2a21a696d

Going to merge this while we figure out whether openssl 1.x is still required.

💬 LarryRuane commented on pull request "logging: use bitset for categories":
(https://github.com/bitcoin/bitcoin/pull/26697#discussion_r1714265458)
As I look at this again, I agree this is over-engineered (what do you think, @ryanofsky?). #26619 was my first attempt but someone suggested using `std::bitset` and I took that suggestion. But that approach (this PR) turned out to be more complicated than expected.

The one thing I like about the current approach is not having to specify all the bit shift values explicitly, such as `NET = (1 << 0)`, instead it's just a clean list. But that isn't much of an advantage.

Why don't I rebase #2
...

🚀 achow101 merged a pull request: "guix: fix suggested fake date for openssl-1.1.1l"
(https://github.com/bitcoin/bitcoin/pull/29999)

📝 maflcko reopened a pull request: "log: expand BCLog::LogFlags (categories) to 64 bits"
(https://github.com/bitcoin/bitcoin/pull/26619)
Increase the maximum number of logging categories from 32 to 64.

We're currently using 29 of the 32 available logging categories (there are only 3 remaining). It would be good to increase the limit soon; the fourth PR to be merged that adds a new logging category will be blocked until something like this is done.

This PR also adds a `TEST` category that uses the new range (`1ULL << 63`) in case there's a hidden assumption somewhere that the `BCLog::LogFlags` type is 32 bits. (Also added a
...

💬 maflcko commented on pull request "logging: use bitset for categories":
(https://github.com/bitcoin/bitcoin/pull/26697#discussion_r1714283665)
> both will be open and up to date, and reviewers can decide which to ACK (or maybe ACK both and a maintainer decides).

I haven't looked at the code or the bug here, but if this is a real bug that could be hit in production, acking and merging should not be done.

💬 paplorinc commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1714285678)
Note that with 80073c75d1218759f58ceefcb41b4fbc4a3d1ecd I could right click and debug and CLion would stop at a breakpoint, but with 67b1e236334f38ec4e4d2251dbdfb790f20ed88b (adding `debug-prefix-map`) it won't stop at breakpoints anymore.
<img width="500" src="https://github.com/user-attachments/assets/66651d62-2dc9-4fa7-9f8f-d45b240aa048">

But as stated in the docs, setting the `target.source-map` in `~/.lldbini` fixed debugging again.

👋 paplorinc's pull request is ready for review: "refactor: Migrate EmplaceCoinInternalDANGER to try_emplace"
(https://github.com/bitcoin/bitcoin/pull/30637)