💬 vasild commented on issue "Finding peers to connect to after -onlynet changes may be problematic":
(https://github.com/bitcoin/bitcoin/issues/26035#issuecomment-2283323618)
This has been fixed by:

https://github.com/bitcoin/bitcoin/pull/26847
https://github.com/bitcoin/bitcoin/pull/27213

closing as resolved.

💬 paplorinc commented on pull request "doc: Update ccache website link":
(https://github.com/bitcoin/bitcoin/pull/30630#issuecomment-2283325788)
ACK fec74a8bcb29e7cdb1ef21c68c7c8c30c4386ca7

👍 hodlinator approved a pull request: "doc: Update ccache website link"
(https://github.com/bitcoin/bitcoin/pull/30630#pullrequestreview-2232298546)
ACK fec74a8bcb29e7cdb1ef21c68c7c8c30c4386ca7

Confirmed browser gets redirected from old URL to new URL.
(+ Pasted new URL into addressbar, removed last char, and saw the complete URL suggested based on browser history from prior redirect).

💬 dergoegge commented on issue "fuzz: `script`: Assertion `!extract_destination_ret' failed.":
(https://github.com/bitcoin/bitcoin/issues/30615#issuecomment-2283353116)
fwiw, I found this using afl++ and libfuzzer in parallel in ~16h CPU hours. The original input is much larger, but I minimized it for this issue:

```
TnNzc3NzknNzc3Nzc3Nzc3NzUXNzc3Nzc3NzcnNzc3Nzc3Nzc3Nzc3Nzc3Nzc3MAAAAAgPlzc3Nzc3NEY1wAAAAAgAEBAYABAfogAAAAc3Nzc3Nzc3Nzc3Nzc3NzbHNzc3Nzc3Jzc3//c3Nzc3Nzc3Nzc3Nzc3Nzc3Nzc3N3c3Nzc3NzRAFc/wEBAYABAQGAAQH6AS8vLy8vLy8vLy8vEi9/AC8vLy8vLy8vLy8vc3NWc3Nzc3NzlHNfc3Nzc3Pe3iHe3t7e3t7e3t7ec3NBQQCeW1yfn5+fn5+fn59cXFxcXFxcXV1cQZ+fc3Nzc3hzc3Nzc0QBXP8BAQGAAQEBgAEB+g
...

✅ glozow closed an issue: "fuzz: `script`: Assertion `!extract_destination_ret' failed."
(https://github.com/bitcoin/bitcoin/issues/30615)

🚀 glozow merged a pull request: "test: remove `ExtractDestination` false assertion for `ANCHOR` script"
(https://github.com/bitcoin/bitcoin/pull/30616)

📝 fanquake unlocked a pull request: "log: expand BCLog::LogFlags (categories) to 64 bits"
(https://github.com/bitcoin/bitcoin/pull/26619)
Increase the maximum number of logging categories from 32 to 64.

We're currently using 29 of the 32 available logging categories (there are only 3 remaining). It would be good to increase the limit soon; the fourth PR to be merged that adds a new logging category will be blocked until something like this is done.

This PR also adds a `TEST` category that uses the new range (`1ULL << 63`) in case there's a hidden assumption somewhere that the `BCLog::LogFlags` type is 32 bits. (Also added a
...

🚀 fanquake merged a pull request: "doc: Update ccache website link"
(https://github.com/bitcoin/bitcoin/pull/30630)

💬 Sjors commented on pull request "Remove Taproot activation height":
(https://github.com/bitcoin/bitcoin/pull/26201#issuecomment-2283399297)
Rebased after #30560 and #29775.

💬 ismaelsadeeq commented on pull request "BlockAssembler: return selected packages vsize and feerate":
(https://github.com/bitcoin/bitcoin/pull/30391#discussion_r1713369779)
That makes sense. I removed `findFeeRate` and explicitly checked the vector for the packages and verify the fee and size were as expected. I also took the opportunity to change the variables to be initialized uniformly.

👍 willcl-ark approved a pull request: "chainparams: Handle Testnet4 in GetNetworkForMagic"
(https://github.com/bitcoin/bitcoin/pull/30625#pullrequestreview-2232381658)
crACK b0ec8716bf27335686471e0ae4c6a34f9a08f33c

🚀 fanquake merged a pull request: "doc: Remove outdated nTx faking comment"
(https://github.com/bitcoin/bitcoin/pull/30624)

🚀 fanquake merged a pull request: "doc: rpc: Use "output script" consistently (2/2)"
(https://github.com/bitcoin/bitcoin/pull/30524)

💬 fanquake commented on pull request "Fixes for GCC 15 compatibility":
(https://github.com/bitcoin/bitcoin/pull/30612#discussion_r1713492439)
> You all can do whatever you want with my suggested fixes.

Thanks. We don't edit commits during merges, so I'll cherry-pick and fixup any nits in a new PR.

📝 fanquake opened a pull request: "Fixes for GCC 15 compatibility"
(https://github.com/bitcoin/bitcoin/pull/30633)
#30612 with changes made.

GCC 15 introduces three build failures:

* Two are related to missing includes. You can't use `uint16_t` et al. without including `<cstdint>`.

* The third is harder to understand but easy to fix. GCC changed something about the way templates are instantiated when checking type constraints, and now there is a dependency loop while checking `std::optional<CFeeRate>`. This manifests as the following compile-time mess:
```
In file included from /usr/lib/gc
...

✅ fanquake closed a pull request: "Fixes for GCC 15 compatibility"
(https://github.com/bitcoin/bitcoin/pull/30612)

💬 fanquake commented on pull request "Fixes for GCC 15 compatibility":
(https://github.com/bitcoin/bitcoin/pull/30612#issuecomment-2283597717)
See #30633.

💬 fanquake commented on pull request "Fixes for GCC 15 compatibility":
(https://github.com/bitcoin/bitcoin/pull/30612#discussion_r1713494639)
Done in #30633.

🚀 fanquake merged a pull request: "lint: Find function calls in default arguments"
(https://github.com/bitcoin/bitcoin/pull/30553)

🚀 fanquake merged a pull request: "doc: Drop no longer needed workaround for WSL"
(https://github.com/bitcoin/bitcoin/pull/30597)