💬 m3dwards commented on pull request "contrib: fix check-deps.sh to check for weak symbols":
(https://github.com/bitcoin/bitcoin/pull/30415#issuecomment-2282747080)
ACK 2bca4af323c5b505689c5203e6ddba8becac5dc8

Tested on Debian x86.

With the suppression disabled I got:

```shell
Error: libbitcoin_consensus_a-pubkey.o depends on libbitcoin_util_a-strencodings.o symbol 'std::optional<std::vector<unsigned char, std::allocator<unsigned char> > > TryParseHex<unsigned char>(std::basic_string_view<char, std::char_traits<char> >)'
```

⚠️ maprezentalok opened an issue: ""heapleakdetection" entry in registry for bitcoin-qt.exe"
(https://github.com/bitcoin/bitcoin/issues/30629)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

there is an entry indicating there is a heap leak in bitcoin-qt.exe:

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\RADAR\HeapLeakDetection\DiagnosedApplications\bitcoin-qt.exe]
"LastDetectionTime"=hex(b):ce,61,4c,3c,47,bc,da,01

unfortunately no details, also it could be qt related? i hope so :D

### Expected behaviour

expected to free memory as soon as it can be freed

### Steps to reprod
...

📝 hebasto opened a pull request: "doc: Update ccache website link"
(https://github.com/bitcoin/bitcoin/pull/30630)

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1713012418)
> * https://github.com/bitcoin/bitcoin/blob/14093d5d243f6eb9cfef721c80f92848d95032ee/doc/productivity.md?plain=1#L68

See https://github.com/hebasto/bitcoin/pull/323.

👍 tdb3 approved a pull request: "doc: Update ccache website link"
(https://github.com/bitcoin/bitcoin/pull/30630#pullrequestreview-2231883345)
ACK fec74a8bcb29e7cdb1ef21c68c7c8c30c4386ca7
Looks like ccache.samba.org 301 redirects to ccache.dev (checked in browser dev mode).

👍 theStack approved a pull request: "chainparams: Handle Testnet4 in GetNetworkForMagic"
(https://github.com/bitcoin/bitcoin/pull/30625#pullrequestreview-2231901768)
ACK b0ec8716bf27335686471e0ae4c6a34f9a08f33c

👍 tdb3 approved a pull request: "wallet: fix blank legacy detection"
(https://github.com/bitcoin/bitcoin/pull/30621#pullrequestreview-2231909317)
ACK 30f701317b4a674fea422766ac3ee179c9c6f554

Light code review. On the PR branch, created a blank legacy wallet, opened in bitcoin-qt. Saw that the migrate option was available and performed the migration.


💬 LarryRuane commented on pull request "logging: use bitset for categories":
(https://github.com/bitcoin/bitcoin/pull/26697#issuecomment-2282993104)
Thanks, Russ, I made both suggested changes (force pushed).

🤔 Shuhaib07 reviewed a pull request: "26.2 final changes"
(https://github.com/bitcoin/bitcoin/pull/30376#pullrequestreview-2232018547)
Approve

💬 Shuhaib07 commented on pull request "crypto, refactor: add new KeyPair class":
(https://github.com/bitcoin/bitcoin/pull/30051#discussion_r1713154630)
Okay

🤔 Shuhaib07 reviewed a pull request: "crypto, refactor: add new KeyPair class"
(https://github.com/bitcoin/bitcoin/pull/30051#pullrequestreview-2232024699)
Approve

📝 kirthana4323 opened a pull request: "Main"
(https://github.com/bitcoin/bitcoin/pull/30631)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ achow101 closed a pull request: "Main"
(https://github.com/bitcoin/bitcoin/pull/30631)

📝 achow101 locked a pull request: "Main"
(https://github.com/bitcoin/bitcoin/pull/30631)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 vasild commented on pull request "logging: use bitset for categories":
(https://github.com/bitcoin/bitcoin/pull/26697#discussion_r1713192718)
This can observe a state that never was. For example, lets say `bits[]` has 2 elements, initially `[0000, 0010]`:

0. `[0000, 0010]`, `any() == true`
1. `any()` is called and it reads the first element `0000`
2. another thread sets the 1st bit, new state: `[1000, 0010]`, `any() == true`
3. another thread resets the 7th bit, new state: `[1000, 0000]`, `any() == true`
4. the execution of `any()` from 1. continues and reads the second element: `0000` and that `any()` call returns `false`, eve
...

💬 maflcko commented on issue "LevelDB read failure: Corruption: block checksum mismatch":
(https://github.com/bitcoin/bitcoin/issues/30159#issuecomment-2283305777)
The very first machine I set up on AWS refused ssh access and had to be rebooted (fine so far after a reboot). Maybe all of this is just AWS hardware failures?

⚠️ GregTonoski opened an issue: "An "output descriptor" should not have many different checksums"
(https://github.com/bitcoin/bitcoin/issues/30632)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

There are different BIP-380 checksums for the same addresses/ScriptPubs/keys: "mpfvuvu6" and "ecrayewn".

```
$ bitcoin-cli deriveaddresses "wpkh([b8688df1]xprv9s21ZrQH143K2x4gnzRB1eZDq92Uuvy9CXbvgQGdvykXZ9mkkot6LBjzDpgaAfvzkuxJe9JKJXQ38VoPutxvACA5MsyoBs5UyQ4HZKGshGs/84'/0'/0'/0/0)#mpfvuvu6"
[
"bc1qgkju4yvvtuz0s8vqn837q396jezu2h8ex7gk98"
]
```

```
$ bitcoin-cli deriveaddresse
...

💬 paplorinc commented on pull request "logging: use bitset for categories":
(https://github.com/bitcoin/bitcoin/pull/26697#discussion_r1713312563)
+1 for uint64_t instead of AtomicBitSet

✅ vasild closed an issue: "Finding peers to connect to after -onlynet changes may be problematic"
(https://github.com/bitcoin/bitcoin/issues/26035)

💬 vasild commented on issue "Finding peers to connect to after -onlynet changes may be problematic":
(https://github.com/bitcoin/bitcoin/issues/26035#issuecomment-2283323618)
This has been fixed by:

https://github.com/bitcoin/bitcoin/pull/26847
https://github.com/bitcoin/bitcoin/pull/27213

closing as resolved.