Bitcoin Core Github
44 subscribers
120K links
Download Telegram
💬 stratospher commented on pull request "test: Add test for rpcwhitelistdefault":
(https://github.com/bitcoin/bitcoin/pull/29858#discussion_r1712687061)
3123eea: I wonder if [`replace_in_config`](https://github.com/bitcoin/bitcoin/blob/c2d15d993ef06d97d4c117012bda6efa3dcbac45/test/functional/test_framework/test_node.py#L441) can be used here?
💬 gmaxwell commented on pull request "Halt processing of unrequested transactions v2":
(https://github.com/bitcoin/bitcoin/pull/30572#issuecomment-2282241950)
@mzumsande Good point-- though the logic in the comment ought not apply when the transaction in the orphan pool comes from the same peer, in that case the extra request would be purely redundant.
📝 fjahr opened a pull request: "chainparams: Handle Testnet4 in GetNetworkForMagic"
(https://github.com/bitcoin/bitcoin/pull/30625)
Found during testing: The recently introduced `GetNetworkForMagic()` doesn't handle Testnet4 yet.
💬 fjahr commented on pull request "validation: assumeutxo params mainnet":
(https://github.com/bitcoin/bitcoin/pull/28553#issuecomment-2282275885)
re-ACK 1610643c8b37a9f674b236cfa79abf8f8aaf1410

Verified only rebase via `git range-diff master fb543c9f733610b8fadbfd6f1c71f1bb520de985 1610643c8b37a9f674b236cfa79abf8f8aaf1410` and re-tested loading and syncing with the new snapshot torrent.
💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#issuecomment-2282278895)
@fanquake in https://github.com/bitcoin/bitcoin/pull/30454#issuecomment-2277722262:
> Had a look at a Guix build. Stripping the macOS binaries is broken:
>
> ```shell
> -- Installing: /distsrc-base/distsrc-ad2140d4d8cc-arm64-apple-darwin/installed/bitcoin-ad2140d4d8cc/bin/bitcoind
> /root/.guix-profile/bin/llvm-strip: error: unknown argument '-u'
> ```

Fixed in https://github.com/hebasto/bitcoin/pull/321.
⚠️ Vick145 opened an issue: "https://t.me/OfficialBabyOtter"
(https://github.com/bitcoin/bitcoin/issues/30626)
### Motivation

Welcome John to the BabyOtter World

We're a wild gang of degen enthusiasts on a mission to rocket BabyOTTer to at least 300x! Count on us!! Let's blast off!!!

''OTTER'' the biggest hype SOLANA

$BabyOtter CA : EUYJtrgfuqnsqX27EDPSbS3LtoXV9vfGagF8ssUWsX5w

| NO TEAM TOKEN |
| 0% FEE |
|CONTRACT SAFU |
|LP BURNED & CONTRACT RENOUNCED |

‼️Read the pinned messages!
‼️ADM NEVER DM FIRST!

### Possible solution

Welcome John to the BabyOtter World
...
:lock: hebasto locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/30626)
👍 tdb3 approved a pull request: "chainparams: Handle Testnet4 in GetNetworkForMagic"
(https://github.com/bitcoin/bitcoin/pull/30625#pullrequestreview-2231690134)
cr ACK b0ec8716bf27335686471e0ae4c6a34f9a08f33c
💬 theStack commented on pull request "contrib: add tool to convert compact-serialized UTXO set to SQLite database":
(https://github.com/bitcoin/bitcoin/pull/27432#issuecomment-2282299449)
Rebased on master, with the following changes:
* adapted to the new snapshot format (VERSION=2, see #30598)
* extended the netmagic table with Testnet4 (see #29775)
* extended the test to also create a pay-to-anchor UTXO (see #30352)
* print out the supposed snapshot height after processing all coins, by tracking the maximum height (see https://github.com/bitcoin/bitcoin/pull/30598#issuecomment-2276350922)
💬 allanperlee commented on issue "use MiniWallet in functional test `rpc_signrawtransactionwithkey.py` for funding txs":
(https://github.com/bitcoin/bitcoin/issues/30600#issuecomment-2282304362)
Hi @theStack, I could soon start this issue
⚠️ sahil5d opened an issue: "Evaluate Unappreciated Evidence that Satoshi Nakamoto was Elon Musk"
(https://github.com/bitcoin/bitcoin/issues/30627)
### Please describe the feature you'd like to see added.

Add to the knowledge of Satoshi Nakamoto the following information:

## Unappreciated Evidence that Satoshi Nakamoto was Elon Musk

### An IP address in Los Angeles

On Satoshi: "This is not a TOR exit node which implies that this is the IP address used by Satoshi on 2009–01–10 and he was in Van Nuys [Los Angeles] on this day."
 https://whoissatoshi.wordpress.com/2016/02/20/satoshi-in-california/

On Musk: "The jet is registered
...
achow101 closed an issue: "Evaluate Unappreciated Evidence that Satoshi Nakamoto was Elon Musk"
(https://github.com/bitcoin/bitcoin/issues/30627)
:lock: achow101 locked an issue: "Evaluate Unappreciated Evidence that Satoshi Nakamoto was Elon Musk"
(https://github.com/bitcoin/bitcoin/issues/30627)
⚠️ VadymK666 opened an issue: "Чудовий початок роботи 👌💪"
(https://github.com/bitcoin/bitcoin/issues/30628)
### Motivation

GitHub автоматически создает ссылки, если допустимые URL-адреса записываются в комментарий. Дополнительные сведения см. в разделе

### Possible solution

Если для репозитория настроены пользовательские автоматические ссылки, то ссылки на внешние ресурсы, такие как проблема JIRA или тикет Zendesk, конвертируются в сокращенные ссылки. Чтобы узнать, какие автоматические ссылки доступны в репозитории, обратитесь к кому-то, у кого есть разрешения администратора в отношении репозитория
...
maflcko closed an issue: "Чудовий початок роботи 👌💪"
(https://github.com/bitcoin/bitcoin/issues/30628)
:lock: fanquake locked an issue: "Чудовий початок роботи 👌💪"
(https://github.com/bitcoin/bitcoin/issues/30628)
👍 maflcko approved a pull request: "chainparams: Handle Testnet4 in GetNetworkForMagic"
(https://github.com/bitcoin/bitcoin/pull/30625#pullrequestreview-2231783071)
review ACK b0ec8716bf27335686471e0ae4c6a34f9a08f33c

Left a style-nit to avoid a copy and to make the code shorter, but only if you re-touch.
💬 maflcko commented on pull request "chainparams: Handle Testnet4 in GetNetworkForMagic":
(https://github.com/bitcoin/bitcoin/pull/30625#discussion_r1712953968)
style-nit: I know you copied this from the surrounding code, but creating a copy is not needed to compare two const references, and if the size of the second range in `std::equal` is different, the result is either wrong or undefined behavior (UB/uninitialized read). See also the notes section (https://en.cppreference.com/w/cpp/algorithm/equal#Notes), which says "... When comparing entire containers for equality, operator== for the corresponding container are usually preferred".

So that'd be:
...
💬 paplorinc commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1712955667)
> The cmake -S src/bench -B build command fails.

It seems to me [they're using `ninja`](https://github.com/bitcoin-cash-node/bitcoin-cash-node/blob/master/doc/benchmarking.md?plain=1#L8) for these tasks, i.e. [`ninja bench-bitcoin`](https://github.com/bitcoin-cash-node/bitcoin-cash-node/blob/master/doc/ninja_targets.md?plain=1#L251) instead of raw cmake.