💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1712637433)
See https://github.com/hebasto/bitcoin/pull/320.

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1712637443)
See https://github.com/hebasto/bitcoin/pull/320.

💬 andrewtoth commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#issuecomment-2281899749)
This change didn't appear to have any speed impact for a reindex-chainstate using max dbcache. Ran the following benchmark:
```
nohup hyperfine \
--export-markdown ~/bench.md \
--show-output \
--parameter-list commit 81508954f1f89f95b6fdca10c3c471cdb6566c80,27a770b34b8f1dbb84760f442edb3e23a0c2420b \
--prepare 'git checkout {commit} && \
make -j$(nproc) src/bitcoind; \
sync; sudo /sbin/sysctl vm.drop_caches=3;' \
-M 2 \
'echo '{commit}' && \
./src/bitcoind -datadir=/home/user/.bitcoin
...

💬 1440000bytes commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#issuecomment-2282178130)
Concept ACK

📝 maflcko opened a pull request: "doc: Remove outdated nTx faking comment"
(https://github.com/bitcoin/bitcoin/pull/30624)
This problematic `nTx` "faking" was removed in commit b50554babdddf452acaa51bac757736766c70e81.

So fix the wrong comment.

Also, address the typo nits from:

* https://github.com/bitcoin/bitcoin/pull/29370#discussion_r1531789314
* https://github.com/bitcoin/bitcoin/pull/30598#discussion_r1711982543

💬 maflcko commented on pull request "assumeutxo: Drop block height from metadata":
(https://github.com/bitcoin/bitcoin/pull/30598#discussion_r1712660234)
Done as part of https://github.com/bitcoin/bitcoin/pull/30624

👍 tdb3 approved a pull request: "cli: restrict multiple exclusive argument usage in bitcoin-cli"
(https://github.com/bitcoin/bitcoin/pull/30148#pullrequestreview-2231464882)
cr re ACK c8e6771af002eaf15567794fcdc57fdb0e3fb140
Diff showed minor changes to comment header of `CheckMultipleCLIArgs()`

💬 agroce commented on issue "fuzz: `script`: Assertion `!extract_destination_ret' failed.":
(https://github.com/bitcoin/bitcoin/issues/30615#issuecomment-2282202407)
This actually leads to a q I was wondering about for OSS-Fuzz: are there configs for appropriate targets with smaller max-lens?

💬 fjahr commented on pull request "doc: Remove outdated nTx faking comment":
(https://github.com/bitcoin/bitcoin/pull/30624#issuecomment-2282212130)
ACK fa04511e44bc6c740ff1c4f912f689b2bc3d1288

🤔 stratospher reviewed a pull request: "addrman: change internal id counting to int64_t"
(https://github.com/bitcoin/bitcoin/pull/30568#pullrequestreview-2231495237)
Concept ACK. there's also if you retouch. https://github.com/bitcoin/bitcoin/blob/c2d15d993ef06d97d4c117012bda6efa3dcbac45/src/test/fuzz/addrman.cpp#L189

💬 gmaxwell commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#issuecomment-2282238485)
I didn't comment on IBD because I figured a hit per hour isn't that significant in the context of IBD and likely pays for itself in improving crash robustness. I'm a little surprised that the effect is quite so small, but it does probably improve performance too by making writes a little more concurrent.

Sipa: good point on the injection locking, I've previously wondered if the the 24 hour behavior could sync up.

💬 stratospher commented on pull request "test: Add test for rpcwhitelistdefault":
(https://github.com/bitcoin/bitcoin/pull/29858#discussion_r1712687061)
3123eea: I wonder if [`replace_in_config`](https://github.com/bitcoin/bitcoin/blob/c2d15d993ef06d97d4c117012bda6efa3dcbac45/test/functional/test_framework/test_node.py#L441) can be used here?

💬 gmaxwell commented on pull request "Halt processing of unrequested transactions v2":
(https://github.com/bitcoin/bitcoin/pull/30572#issuecomment-2282241950)
@mzumsande Good point-- though the logic in the comment ought not apply when the transaction in the orphan pool comes from the same peer, in that case the extra request would be purely redundant.

📝 fjahr opened a pull request: "chainparams: Handle Testnet4 in GetNetworkForMagic"
(https://github.com/bitcoin/bitcoin/pull/30625)
Found during testing: The recently introduced `GetNetworkForMagic()` doesn't handle Testnet4 yet.

💬 fjahr commented on pull request "validation: assumeutxo params mainnet":
(https://github.com/bitcoin/bitcoin/pull/28553#issuecomment-2282275885)
re-ACK 1610643c8b37a9f674b236cfa79abf8f8aaf1410

Verified only rebase via `git range-diff master fb543c9f733610b8fadbfd6f1c71f1bb520de985 1610643c8b37a9f674b236cfa79abf8f8aaf1410` and re-tested loading and syncing with the new snapshot torrent.

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#issuecomment-2282278895)
@fanquake in https://github.com/bitcoin/bitcoin/pull/30454#issuecomment-2277722262:
> Had a look at a Guix build. Stripping the macOS binaries is broken:
>
> ```shell
> -- Installing: /distsrc-base/distsrc-ad2140d4d8cc-arm64-apple-darwin/installed/bitcoin-ad2140d4d8cc/bin/bitcoind
> /root/.guix-profile/bin/llvm-strip: error: unknown argument '-u'
> ```

Fixed in https://github.com/hebasto/bitcoin/pull/321.

⚠️ Vick145 opened an issue: "https://t.me/OfficialBabyOtter"
(https://github.com/bitcoin/bitcoin/issues/30626)
### Motivation

❔ Welcome John to the BabyOtter World ❔

We're a wild gang of degen enthusiasts on a mission to rocket BabyOTTer to at least 300x! Count on us!! Let's blast off!!!

''OTTER'' the biggest hype SOLANA ❔

$BabyOtter CA : EUYJtrgfuqnsqX27EDPSbS3LtoXV9vfGagF8ssUWsX5w ❔

❔| NO TEAM TOKEN | ❔
❔| 0% FEE |❔
❔|CONTRACT SAFU |❔
❔|LP BURNED & CONTRACT RENOUNCED |❔

‼️Read the pinned messages!
‼️ADM NEVER DM FIRST!

### Possible solution

❔ Welcome John to the BabyOtter World ❔
...

✅ hebasto closed an issue: "https://t.me/OfficialBabyOtter"
(https://github.com/bitcoin/bitcoin/issues/30626)

:lock: hebasto locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/30626)

👍 tdb3 approved a pull request: "chainparams: Handle Testnet4 in GetNetworkForMagic"
(https://github.com/bitcoin/bitcoin/pull/30625#pullrequestreview-2231690134)
cr ACK b0ec8716bf27335686471e0ae4c6a34f9a08f33c