💬 Retropex commented on pull request "Add a `-permitbarepubkey` option":
(https://github.com/bitcoin/bitcoin/pull/29309#issuecomment-2274112090)
Why closing this? @vostrnad

💬 ariard commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#issuecomment-2274116264)
@petertodd On the lightning side, in a world where as a node you have a scarcity of UTXO to allocate seeing locally a record of transaction-relay policy and consensus transaction, it’s very useful to start to have (unsafe indeed) HTLC flowing or fee-bump the transaction to increase funds velocity.

I’m not insisting on keeping `mempoolfullrbf`. It’s more very likely that your first-seen log of transaction to monitor double-spend will ressemble an in-_memory_ pool of transactions and as your co
...

💬 vostrnad commented on pull request "Add a `-permitbarepubkey` option":
(https://github.com/bitcoin/bitcoin/pull/29309#issuecomment-2274129837)
@Retropex I've rebased this enough times already for something I don't really think should be merged. Also I suspect anyone interested in this option has already switched to Knots anyway (which has it implemented).

💬 pinheadmz commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#discussion_r1707675544)
@boring877 Your comments are off topic and inflammatory, resulting in a 24 ban from the organization to cool off. I'm not going to delete your comments since this PR is closed anyway, and contributors offered informational replies. To appeal a moderation decision, open an issue in bitcoin-core/meta

🚀 glozow merged a pull request: "refactor: use recommended type hiding on multi_index types"
(https://github.com/bitcoin/bitcoin/pull/30194)

💬 naiyoma commented on pull request "test: update satoshi_round function":
(https://github.com/bitcoin/bitcoin/pull/29566#issuecomment-2274153740)

> The pull request description will need to be updated to reflect the current state.

@maflcko Description updated. Also, reverted `fee_increment` to a float and then applied satoshi_round with ROUND_DOWN at the call site. This is much cleaner and more readable.

🤔 Shuhaib07 reviewed a pull request: "crypto, refactor: add new KeyPair class"
(https://github.com/bitcoin/bitcoin/pull/30051#pullrequestreview-2225978666)
Okay

💬 brunoerg commented on issue "fuzz: crypto_fschacha20poly1305 timeout":
(https://github.com/bitcoin/bitcoin/issues/30505#issuecomment-2274161098)
What is the timeout value in OSS-Fuzz?

💬 justinvforvendetta commented on pull request "get miniupnpc from ssl, this reverts commit 21b8a14d37c19ce292d5529597e0d52338db48a9":
(https://github.com/bitcoin/bitcoin/pull/30564#issuecomment-2274168843)
@willcl-ark fixed it. i misinterpreted, thanks

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1707716090)
Thanks! Implemented in https://github.com/hebasto/bitcoin/pull/313.

💬 fanquake commented on pull request "get miniupnpc from ssl, this reverts commit 21b8a14d37c19ce292d5529597e0d52338db48a9":
(https://github.com/bitcoin/bitcoin/pull/30564#issuecomment-2274181398)
> fixed it. i misinterpreted, thanks

Thanks, but you've still misinterpreted. You should literally type:
```bash
git revert 21b8a14d37c19ce292d5529597e0d52338db48a9
```
which will give a commit like this:
```patch
commit 3e36c5c07a32b24a10a4ded17ccd129717fb0c82 (HEAD -> master)
Author: fanquake <fanquake@gmail.com>
Date: Wed Aug 7 20:18:15 2024 +0100

Revert "depends: Fetch miniupnpc sources from an alternative website"

This reverts commit 21b8a14d37c19ce292d5529597
...

💬 sipa commented on pull request "Don't empty dbcache on prune flushes: >30% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/28280#issuecomment-2274188726)
reACK 589db872e116779ab9cae693171ac8a8c02d9923

✅ justinvforvendetta closed a pull request: "get miniupnpc from ssl, this reverts commit 21b8a14d37c19ce292d5529597e0d52338db48a9"
(https://github.com/bitcoin/bitcoin/pull/30564)

👍 ryanofsky approved a pull request: "logging: use bitset for categories"
(https://github.com/bitcoin/bitcoin/pull/26697#pullrequestreview-2225977743)
Code review ACK dadce0ba946aa9c209fc5c15d9efe627f7a486a2

Not important, but I think you could consider renaming `BCLog::LogFlagsBitset` to `BCLog::CategoryMask` to provide a less clunky type name and be consistent with existing `BCLog::::Logger::GetCategoryMask()` method.

💬 ryanofsky commented on pull request "logging: use bitset for categories":
(https://github.com/bitcoin/bitcoin/pull/26697#discussion_r1707700923)
In commit "logging: use bitset class for categories" (dadce0ba946aa9c209fc5c15d9efe627f7a486a2)

In std::bitset, the "is_any" and "is_none" methods seem to be called just any and none. IMO, the standard names make more sense than these names because I don't think it makes sense to say a set "is any" or a set "is none" but I do think it makes sense for it to have "any" and "none" properties.

💬 paplorinc commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1707740750)
do we need the escape at the end?

📝 justinvforvendetta opened a pull request: "Revert "depends: Fetch miniupnpc sources from an alternative website""
(https://github.com/bitcoin/bitcoin/pull/30602)
This reverts commit 21b8a14d37c19ce292d5529597e0d52338db48a9.

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
s
...

✅ justinvforvendetta closed a pull request: "Revert "depends: Fetch miniupnpc sources from an alternative website""
(https://github.com/bitcoin/bitcoin/pull/30602)

💬 paplorinc commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1707746253)
if this comment still refers to the mac build, note that mac doesn't have `nproc`

📝 justinvforvendetta opened a pull request: "Revert "depends: Fetch miniupnpc sources from an alternative website""
(https://github.com/bitcoin/bitcoin/pull/30603)
This reverts commit 21b8a14d37c19ce292d5529597e0d52338db48a9.

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
s
...