💬 willcl-ark commented on issue "Unexpected behaviour when using `sortedmulti_a` descriptor":
(https://github.com/bitcoin/bitcoin/issues/30518#issuecomment-2249872391)
Thanks for the report.

I would also expect to see these decodes behave the same as the only difference between them should be the sorting. I didn't investigate further yet, but incidentally I see the same behaviour in a toy rust-miniscript parser I have:

```
Loading descriptor: tr(50929b74c1a04954b78b4b6035e97a5e078a5a0f28ec96d547bfee9ace803ac0,and_v(v:pk(b6df9cc452123b137ae8ad15927ff78b7e4e010a97b8ef6732d6d9d692abd993),multi_a(1,0153089cb23a34755aeba2737cb2134add1708e09dca8ae128ccdb1f035
...

💬 fanquake commented on pull request "security-check: test for `_FORTIFY_SOURCE` usage in release binaries":
(https://github.com/bitcoin/bitcoin/pull/27038#issuecomment-2249873826)
RISCV build failed here:
```bash
Traceback (most recent call last):
File "/distsrc-base/distsrc-3733b4b088ff-riscv64-linux-gnu/./contrib/devtools/test-security-check.py", line 73, in test_ELF
self.assertEqual(call_security_check(cxx, source, executable, pass_flags + ['-no-pie','-fno-PIE']), (1, executable + ': failed PIE'))
AssertionError: Tuples differ: (1, 'test1: failed PIE FORTIFY') != (1, 'test1: failed PIE')

First differing element 1:
'test1: failed PIE FORTIFY'
'test1: fai
...

💬 maflcko commented on pull request "utils: replace boost::date_time usage with c++20 std::chrono":
(https://github.com/bitcoin/bitcoin/pull/30462#issuecomment-2249881098)
> Maybe I'm over-complicating it?

And if there were any issues that I am missing, commit fa72dcbfa56177ca878375bae7c7bca6ca6a1f40 would be wrong as well, no?

📝 maflcko opened a pull request: "ci: Add missing qttools5-dev install to Asan task"
(https://github.com/bitcoin/bitcoin/pull/30522)
This is required, according to the docs:

```
$ git grep --line-number 'qtbase5-dev qttools5-dev qttools5-dev-tools' doc
doc/build-unix.md:84: sudo apt-get install qtbase5-dev qttools5-dev qttools5-dev-tools
```

Also, needed for cmake.

💬 maflcko commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1691143911)
Done in https://github.com/bitcoin/bitcoin/pull/30522

👍 hebasto approved a pull request: "contrib: fix check-deps.sh to check for weak symbols"
(https://github.com/bitcoin/bitcoin/pull/30415#pullrequestreview-2198811168)
re-ACK 114b2a406e604747bd856f566aa8c7ad84dd8f15.

📝 fanquake converted_to_draft a pull request: "utils: replace boost::date_time usage with c++20 std::chrono"
(https://github.com/bitcoin/bitcoin/pull/30462)
This would be a very straightforward and uncontroversial change if not for the sad state of std lib implementations which implement this functionality.

As of now, `std::chrono::parse` and friends (c++20 additions) are only available as of gcc 14 and (unreleased) clang 19.

Formatting in chrono is quite useful, so I don't think it makes sense to wait years until we require those compilers.

Instead of waiting around, this PR takes the sledgehammer approach of adding a fully-conformant impl
...

💬 glozow commented on pull request "cluster mempool: cluster linearization algorithm":
(https://github.com/bitcoin/bitcoin/pull/30126#discussion_r1691152128)
Ah I didn't notice this yesterday - I think you may have swapped odd and even? Same in the commented mermaid diagram code just added.

💬 fanquake commented on pull request "Fee Estimation: change `estimatesmartfee` default mode to `economical`":
(https://github.com/bitcoin/bitcoin/pull/30275#issuecomment-2249911817)
Will need a release note.

✅ fanquake closed an issue: "Change estimate_mode default to "ECONOMICAL" in these RPC calls"
(https://github.com/bitcoin/bitcoin/issues/30009)

🚀 fanquake merged a pull request: "Fee Estimation: change `estimatesmartfee` default mode to `economical`"
(https://github.com/bitcoin/bitcoin/pull/30275)

💬 ismaelsadeeq commented on pull request "Fee Estimation: change `estimatesmartfee` default mode to `economical`":
(https://github.com/bitcoin/bitcoin/pull/30275#issuecomment-2249923172)
> Will need a release note.

Thanks, I will add it in the follow-up!

👍 hebasto approved a pull request: "ci: Add missing qttools5-dev install to Asan task"
(https://github.com/bitcoin/bitcoin/pull/30522#pullrequestreview-2198839834)
ACK faa359877270121b3cd442e1e5e865586ce7e530.

📝 hebasto opened a pull request: "doc: Rename build notes for MinGW-w64"
(https://github.com/bitcoin/bitcoin/pull/30523)
Broken out of https://github.com/bitcoin/bitcoin/pull/30454. Required because, after migration to CMake, the `doc/` subdirectory will contain notes for both MinGW-w64 and MSVC.

Addressed https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1690990701.

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1691182478)
Done in https://github.com/bitcoin/bitcoin/pull/30523.

💬 fanquake commented on pull request "Detect and ignore transactions that were CPFP'd in the fee estimator":
(https://github.com/bitcoin/bitcoin/pull/25380#issuecomment-2249963225)
PIcked up in #30079.

💬 maflcko commented on issue "Intermittent issue in feature_proxy.py AssertionError: not(bytearray(b'node.noumenon') == b'fc00:1:2:3:4:5:6:7')":
(https://github.com/bitcoin/bitcoin/issues/29871#issuecomment-2249968557)
I wonder it it is due to

```
ci/test/00_setup_env_i686_multiprocess.sh:15:export TEST_RUNNER_EXTRA="--v2transport"

💬 maflcko commented on issue "Intermittent issue in feature_proxy.py AssertionError: not(bytearray(b'node.noumenon') == b'fc00:1:2:3:4:5:6:7')":
(https://github.com/bitcoin/bitcoin/issues/29871#issuecomment-2249970208)
Ah yes. Well, that was quick. Steps to reproduce on the first try:

```
$ while test/functional/feature_proxy.py --v2transport --valgrind ; do true ; done
2024-07-25T10:09:50.233000Z TestFramework (INFO): PRNG seed is: 4706088440128402104
2024-07-25T10:09:50.234000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test__c5c1wwl
2024-07-25T10:10:16.428000Z TestFramework (ERROR): Assertion failed

AssertionError: not(bytearray(b'node.noumenon') == b'fc00:1:2:3:4:5:6:7'
...

💬 hebasto commented on pull request "ci: add `_LIBCPP_REMOVE_TRANSITIVE_INCLUDES` to TSAN (libc++) job":
(https://github.com/bitcoin/bitcoin/pull/30519#issuecomment-2249975246)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/281.

💬 maflcko commented on pull request "doc: Rename build notes for MinGW-w64":
(https://github.com/bitcoin/bitcoin/pull/30523#discussion_r1691209371)
Isn't this one and `doc/README.md` about *native* builds? So probably better to link to the msvc, but that seems unrelated, so anything is fine here.