👍 ryanofsky approved a pull request: "Have createNewBlock() return a BlockTemplate interface"
(https://github.com/bitcoin/bitcoin/pull/30440#pullrequestreview-2191872106)
Code review ACK bde6c7f7b126beea1359990e012c76c5cafc34a6. Left one suggestion, but this change is much simpler now and look good.

💬 ryanofsky commented on pull request "Have createNewBlock() return a BlockTemplate interface":
(https://github.com/bitcoin/bitcoin/pull/30440#discussion_r1686727569)
In commit "Have createNewBlock return BlockTemplate interface" (f434c8562281dfec1bab37e7232ca35fd759e25f)

While changing this it would make sense to add std::move() on line 148 below so the block data does not need to be copied there.

👍 hebasto approved a pull request: "contrib: simplify `test-security-check`"
(https://github.com/bitcoin/bitcoin/pull/30423#pullrequestreview-2191894000)
ACK 1bc9f64bee919bc46eb061ef8c66f936eb6a8918 (assuming my Guix hashes match; I'll provide them shortly).

My [concern](https://github.com/bitcoin/bitcoin/pull/30423#discussion_r1674030590) about `-pie` support for Windows is not a blocker.

📝 maflcko opened a pull request: " lint: Add missing docker.io prefix to ci/lint_imagefile "
(https://github.com/bitcoin/bitcoin/pull/30501)
Currently, the `ci/lint_imagefile` may pick the wrong (non-native) architecture due to the missing prefix.

For example, assuming the user has previously pulled an s390x image:

```
$ podman run --rm 'docker.io/s390x/debian:bookworm' dpkg --print-architecture
exec /usr/bin/dpkg: exec format error
```

Now, `debian:bookworm` will refer to the same image:

```
$ podman run --rm 'debian:bookworm' dpkg --print-architecture
exec /usr/bin/dpkg: exec format error
```

However, `docker.i
...

💬 maflcko commented on pull request "lint: Use consistent out-of-tree build for python and test_runner":
(https://github.com/bitcoin/bitcoin/pull/30499#discussion_r1686749450)
Done in https://github.com/bitcoin/bitcoin/pull/30501

👍 paplorinc approved a pull request: "lint: Add missing docker.io prefix to ci/lint_imagefile"
(https://github.com/bitcoin/bitcoin/pull/30501#pullrequestreview-2191914039)
utACK fa7bee13bf745d8d244fa8d3579a21016a0cb66d

Thanks!

👍 hebasto approved a pull request: "lint: Add missing docker.io prefix to ci/lint_imagefile"
(https://github.com/bitcoin/bitcoin/pull/30501#pullrequestreview-2191930364)
ACK fa7bee13bf745d8d244fa8d3579a21016a0cb66d.

✅ maflcko closed an issue: "Fuzz coverage for wallet RPCs is zero"
(https://github.com/bitcoin/bitcoin/issues/30458)

💬 maflcko commented on issue "Fuzz coverage for wallet RPCs is zero":
(https://github.com/bitcoin/bitcoin/issues/30458#issuecomment-2243304292)
> Added this in #29901.

Thanks!

I'll close my issue then. Happy to review a pull request if someone creates one, but probably no need to keep this issue open in the meantime.

💬 Sjors commented on pull request "Have createNewBlock() return a BlockTemplate interface":
(https://github.com/bitcoin/bitcoin/pull/30440#discussion_r1686795623)
Changed

💬 vasild commented on issue "Fuzzing related configuration/build options can be improved":
(https://github.com/bitcoin/bitcoin/issues/30318#issuecomment-2243385353)
Which are those flags?

🚀 fanquake merged a pull request: "depends: build zeromq with CMake"
(https://github.com/bitcoin/bitcoin/pull/29723)

💬 sipa commented on pull request "crypto, refactor: add new KeyPair class":
(https://github.com/bitcoin/bitcoin/pull/30051#discussion_r1686762705)
In commit "tests: add key tweak smoke test"

The `merkle_root.IsNull()` condition will never hold here. Perhaps it makes sense to run this test in a loop, and only set `merkle_root` to `InsecureRand256()` in some of the iterations?

💬 sipa commented on pull request "crypto, refactor: add new KeyPair class":
(https://github.com/bitcoin/bitcoin/pull/30051#discussion_r1686843355)
If the only purpose of this function is constructing a `const secp256k1_keypair*`, I think it would be better to make it private (it seems only accessed inside `KeyPair` anyway?), and give it another name (`data()` is used in STL containers to give raw access to the contents, which seems to be explicitly what we don't want here).

🚀 fanquake merged a pull request: "lint: Add missing docker.io prefix to ci/lint_imagefile"
(https://github.com/bitcoin/bitcoin/pull/30501)

🚀 fanquake merged a pull request: "Fix lint-spelling warnings"
(https://github.com/bitcoin/bitcoin/pull/30500)

👍 fanquake approved a pull request: "depends: Fix CMake-generated `libevent*.pc` files"
(https://github.com/bitcoin/bitcoin/pull/30488#pullrequestreview-2192092719)
ACK 8c935e625ea75d180144f0526d6a0d5fd58c1f29

🚀 fanquake merged a pull request: "depends: Fix CMake-generated `libevent*.pc` files"
(https://github.com/bitcoin/bitcoin/pull/30488)

👍 dergoegge approved a pull request: "fuzz: reduce keypool size in `scriptpubkeyman` target"
(https://github.com/bitcoin/bitcoin/pull/30494#pullrequestreview-2192109414)
utACK dcb4ec944984961e3b40452425a219e15e6ab508

✅ fanquake closed an issue: "scriptpubkeyman fuzz target TopUp is slow"
(https://github.com/bitcoin/bitcoin/issues/30476)