💬 paplorinc commented on pull request "crypto, refactor: add new KeyPair class":
(https://github.com/bitcoin/bitcoin/pull/30051#discussion_r1681672646)
Might be a naive question, but is this a behavior change, does it have any security implications (e.g. could it leave keys in the memory or something)?

💬 instagibbs commented on pull request "cluster mempool: cluster linearization algorithm":
(https://github.com/bitcoin/bitcoin/pull/30126#discussion_r1681676666)
this isn't making the trivial linear graph

💬 instagibbs commented on pull request "cluster mempool: cluster linearization algorithm":
(https://github.com/bitcoin/bitcoin/pull/30126#discussion_r1681678886)
Why is this benchmark "LIMO" but not `BenchLinearizeNoItersWorstCaseAnc`?

💬 instagibbs commented on pull request "cluster mempool: cluster linearization algorithm":
(https://github.com/bitcoin/bitcoin/pull/30126#discussion_r1681682373)
re: `clusterlin: optimize rechunking in LinearizationChunking`

benchmark doesn't seem to show much improvement for this change. I understood this as purely an efficiency improvement which should be reflected in bench results?

💬 sipa commented on pull request "cluster mempool: cluster linearization algorithm":
(https://github.com/bitcoin/bitcoin/pull/30126#discussion_r1681705464)
I have incorporated something like this into the DepGraphFormatter comment.

💬 sipa commented on pull request "cluster mempool: cluster linearization algorithm":
(https://github.com/bitcoin/bitcoin/pull/30126#discussion_r1681705729)
I have added a comment to explain this briefly.

💬 sipa commented on pull request "cluster mempool: cluster linearization algorithm":
(https://github.com/bitcoin/bitcoin/pull/30126#discussion_r1681706300)
I have moved the connected-component logic, together with its (now optional) usage to #30286.

💬 sipa commented on pull request "cluster mempool: cluster linearization algorithm":
(https://github.com/bitcoin/bitcoin/pull/30126#discussion_r1681706478)
Fixed.

💬 sipa commented on pull request "cluster mempool: cluster linearization algorithm":
(https://github.com/bitcoin/bitcoin/pull/30126#discussion_r1681706944)
Fixed.

💬 sipa commented on pull request "cluster mempool: cluster linearization algorithm":
(https://github.com/bitcoin/bitcoin/pull/30126#discussion_r1681707363)
I don't understand this comment.

💬 sipa commented on pull request "cluster mempool: cluster linearization algorithm":
(https://github.com/bitcoin/bitcoin/pull/30126#discussion_r1681707992)
I have moved this optimization (it is indeed supposed to be one) to #30286.

💬 sipa commented on pull request "cluster mempool: cluster linearization algorithm":
(https://github.com/bitcoin/bitcoin/pull/30126#discussion_r1681708231)
Done!

💬 sipa commented on pull request "cluster mempool: cluster linearization algorithm":
(https://github.com/bitcoin/bitcoin/pull/30126#issuecomment-2234250901)
I have made a number of changes:
* Addressed a number of typos
* Moved connected-component logic to #30286 (where `MakeConnected` is now optional, and `FindConnectedComponent` has its own fuzz test).
* Moved the chunk-caching logic in `LinearizationChunking` to #30286.
* Added more explanatory comments, especially in the `DepGraphFormatter` format description.
* Made the `DepGraphFormatter` deserializer resilient to EOF (previously it would return an empty graph in this case), plus added a
...

💬 pablomartin4btc commented on pull request "Bugfix - don't allow multiple dialogs for same tx in TransactionView":
(https://github.com/bitcoin-core/gui/pull/817#issuecomment-2234439130)
@hebasto it seems there are some [issues](https://gitlab.freedesktop.org/wayland/wayland/-/issues/233) with Wayland on how these actions are being handled ([this one specific](https://bugs.kde.org/show_bug.cgi?id=462574) to KDE but found some old ones in [gnome](https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/730)).

As a workaround (tried other things as well), might be not elegant, but this works fine on both X11/Xorg and Wayland:

```diff --git a/src/qt/transactionview.cpp b/src/qt/tr
...

💬 achow101 commented on pull request "Wallet: Add `max_tx_weight` to transaction funding options (take 2)":
(https://github.com/bitcoin/bitcoin/pull/29523#issuecomment-2234439584)
ACK 734076c6de1781f957c8bc3bf7ed6951920cfcf6

🚀 achow101 merged a pull request: "Wallet: Add `max_tx_weight` to transaction funding options (take 2)"
(https://github.com/bitcoin/bitcoin/pull/29523)

👍 pablomartin4btc approved a pull request: "Rendering an amp characters in the wallet name for QMenu"
(https://github.com/bitcoin-core/gui/pull/828#pullrequestreview-2184202382)
tACK 8233ee41ab9648cd0c3bd78bc2a8d692a54d9ea0

<details>
<summary>It corrects the bug in master.</summary>

- before


- after


</details>

💬 pablomartin4btc commented on pull request "Rendering an amp characters in the wallet name for QMenu":
(https://github.com/bitcoin-core/gui/pull/828#discussion_r1681843714)
I agree with @hebasto. Small nit:
```
// Menu items remove single &. Single & is shown when && are in
// the string. So replace & with &&.
```

💬 pablomartin4btc commented on pull request "Rendering an amp characters in the wallet name for QMenu":
(https://github.com/bitcoin-core/gui/pull/828#discussion_r1681847988)
In case the above suggestion is not taken, typo here:
```suggestion
// A single ampersand in the menu item's text sets a shortcut for this item.
```

👍 tdb3 approved a pull request: "rest: Reject negative outpoint index early in getutxos parsing"
(https://github.com/bitcoin/bitcoin/pull/30444#pullrequestreview-2184314661)
re ACK fac932bf93d9bd8cb7bef93f04ecf48ea2ccf1d1

Re-ran manual tests:
```
$ src/bitcoind -regtest -rest=1
$ src/bitcoin-cli -regtest createwallet test
$ src/bitcoin-cli -regtest -generate 101
$ src/bitcoin-cli -named sendtoaddress address=bcrt1qg2yks0c0slr8nklg30ts48lcq7yslcvaak7n9k amount=39 fee_rate=3
65203a75428597267c78b3781420cae8d753dcd0cf31d9b905bb904ca9431438
$ src/bitcoin-cli -generate 1
{
"address": "bcrt1q73g2xwe4ktc4zfyu8uaft9y8gj0skp7kxnuzvl",
"blocks": [
"5ce35
...