💬 hodlinator commented on pull request "fix: Make TxidFromString() respect string_view length":
(https://github.com/bitcoin/bitcoin/pull/30436#discussion_r1679040564)
Dropped 2 commits from this PR.

💬 glozow commented on pull request "locks: introduce mutex for tx download, flush rejection filters once per tip change":
(https://github.com/bitcoin/bitcoin/pull/30111#discussion_r1679055771)
Ah I was wrong about `LOCK` doing the assert, added that as well.

💬 glozow commented on pull request "locks: introduce mutex for tx download, flush rejection filters once per tip change":
(https://github.com/bitcoin/bitcoin/pull/30111#discussion_r1679056158)
done

💬 maflcko commented on pull request "fix: Make TxidFromString() respect string_view length":
(https://github.com/bitcoin/bitcoin/pull/30436#discussion_r1679074765)
not sure about this change. The types are the same either way and below is still using `std::string::npos`. Also, it has nothing to do with `base_blob` in the commit.

💬 maflcko commented on pull request "fix: Make TxidFromString() respect string_view length":
(https://github.com/bitcoin/bitcoin/pull/30436#discussion_r1679075260)
Same here. Has nothing to do with the `base_blob` commit.

💬 Sjors commented on pull request "Have createNewBlock() return a BlockTemplate interface":
(https://github.com/bitcoin/bitcoin/pull/30440#issuecomment-2230457349)
Rebased on the changes to #30356 and extracted `GetCoinBaseMerklePath` (that'll have to be its own PR though).

💬 hodlinator commented on pull request "fix: Make TxidFromString() respect string_view length":
(https://github.com/bitcoin/bitcoin/pull/30436#discussion_r1679085201)
Seems very harmless to correct the type. But yeah, should have fixed the `npos` if we go with this change.

I'll remove it from this PR for now if it goes outside of the "PR style" of the project.

💬 Sjors commented on pull request "net: additional disconnect logging":
(https://github.com/bitcoin/bitcoin/pull/28521#issuecomment-2230474854)
Rebased after #30420.

💬 Sjors commented on pull request "Silent payment index (for light wallets and consistency check)":
(https://github.com/bitcoin/bitcoin/pull/28241#discussion_r1679131618)
Can you retest after todays rebase?

💬 hodlinator commented on pull request "fix: Make TxidFromString() respect string_view length":
(https://github.com/bitcoin/bitcoin/pull/30436#discussion_r1679138796)
`base_blob` now calls `RemovePrefixView()` which it did not previously do. I want to make it as efficient as possible compared to the prior `base_blob` implementation, hence this change.

💬 paplorinc commented on pull request "optimization: Precalculate SipHash constant XOR with k0 and k1 in SaltedOutpointHasher":
(https://github.com/bitcoin/bitcoin/pull/30442#issuecomment-2230532745)
Now that the other benchmark finished after a few days, I ran this on a `gcc (Debian 12.2.0-14) 12.2.0`.

After the first run I got a warning of:
> Warning, results might be unstable:
> * CPU frequency scaling enabled: CPU 0 between 800.0 and 4,200.0 MHz
> * CPU governor is 'powersave' but should be 'performance'
> * Turbo is enabled, CPU frequency will fluctuate

which I've fixed and also ran `pyperf system tune`.
Additionally I set a `--min-time=10000`, otherwise the results weren't c
...

💬 1alexbc1 commented on issue "Bugreport":
(https://github.com/bitcoin-core/gui/issues/829#issuecomment-2230582415)
Do you shift

:lock: hebasto locked an issue: "Bugreport"
(https://github.com/bitcoin-core/gui/issues/829)

👍 marcofleon approved a pull request: "Add fuzz test for FSChaCha20Poly1305, AEADChacha20Poly1305"
(https://github.com/bitcoin/bitcoin/pull/28263#pullrequestreview-2179899100)
Tested ACK 8607773750e60931e51a33e48cd077a1dedf9db3. Ran both targets for ~200 CPU hours. Coverage of intended targets looks good to me. The simulation of damaged keys and checks that follow seem useful as well.

📝 fanquake opened a pull request: "guix: bump time-machine to 3c58b759a51072aabd7eaaca680674a0c2b36c23"
(https://github.com/bitcoin/bitcoin/pull/30452)
Needed for https://github.com/bitcoin/bitcoin/issues/30210. This doesn't switch runtimes, because upstream is
still configured to use the old runtime. See:
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=17188be0f723e00377b21b767f5447d7938a116e.

git-mimimal 2.45.1 -> 2.45.2
Kernel Headers 6.1.92 -> 6.1.98
LLVM 18.1.6 -> 18.1.8
mingw-w64 11.0.1 -> 12.0.0
patch 2.7.6 -> 2.7.6-0.f144b35

Draft; as the Windows build is now non-deterministic (across architectures), as atleast one sto
...

💬 fanquake commented on issue "build: use UCRT runtime for Windows (release) binaries":
(https://github.com/bitcoin/bitcoin/issues/30210#issuecomment-2230620672)
> I've sent a patchset a while ago

Thanks. That has now landed, so we'll bump the time machine to get things started here. See #30452.

💬 paplorinc commented on pull request "Don't empty dbcache on prune flushes: >30% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/28280#discussion_r1679202356)
Wow, that's a lot more complicated than I imagined, let's not touch it :D

💬 paplorinc commented on pull request "Don't empty dbcache on prune flushes: >30% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/28280#discussion_r1679203516)
Have you given it any more thought? I've tested it since, so i'll ack it, and will reack when you need more changes.

💬 paplorinc commented on pull request "Don't empty dbcache on prune flushes: >30% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/28280#issuecomment-2230625876)
ACK 21090d032f5c4d90a41c3ca2030690c75899ec1a, nicely done!

🚀 fanquake merged a pull request: "Add fuzz test for FSChaCha20Poly1305, AEADChacha20Poly1305"
(https://github.com/bitcoin/bitcoin/pull/28263)