💬 maflcko commented on pull request "refactor: Remove Span operator==, Use std::ranges::equal":
(https://github.com/bitcoin/bitcoin/pull/29071#discussion_r1677459551)
I'll fix it on the next force-push, if there is one

👍 dergoegge approved a pull request: "MiniMiner: use FeeFrac in AncestorFeerateComparator"
(https://github.com/bitcoin/bitcoin/pull/30412#pullrequestreview-2177138195)
tACK 09370529fb9f6d06f6d16bdb1fb336f7a265d8ba

Fuzzed both mini miner harnesses for a while.

👍 hebasto approved a pull request: "fix: rendering an amp characters in the wallet name for QMenu"
(https://github.com/bitcoin-core/gui/pull/828#pullrequestreview-2177151747)
ACK 948520b72d7fe8e7a3aa0d774159807058188627, module https://github.com/bitcoin-core/gui/pull/828/files#r1677136023.

Tested on Ubuntu 24.04, Windows 11 Pro and macOS 12.7.5 Monterey (x86).

💬 hebasto commented on pull request "fix: rendering an amp characters in the wallet name for QMenu":
(https://github.com/bitcoin-core/gui/pull/828#discussion_r1677487337)
Maybe:
```C++
// Menu items remove single &. Single & are shown when && is in
// the string. So replace & with &&.
```
?

💬 dergoegge commented on pull request "fuzz: Deglobalize signature cache in sigcache test":
(https://github.com/bitcoin/bitcoin/pull/30447#discussion_r1677491573)
I think we still need to setup logging or this test will oom because this constructor logs.

💬 hebasto commented on issue "Generalized fee bumping":
(https://github.com/bitcoin-core/gui/issues/822#issuecomment-2227992916)
cc @achow101 @Sjors @GBKS

💬 Sjors commented on pull request "Have createNewBlock() return a BlockTemplate interface":
(https://github.com/bitcoin/bitcoin/pull/30440#issuecomment-2228006803)
Pushed a commit that adds `submitSolution` to the `BlockTemplate` interface.

✅ fanquake closed an issue: "Mini miner `AncestorFeerateComparator` Signed Integer Overflow"
(https://github.com/bitcoin/bitcoin/issues/30284)

✅ fanquake closed an issue: "fuzz: mini_miner_selection: ASSERT: mock_template_txids.size() <= blocktemplate->block.vtx.size()"
(https://github.com/bitcoin/bitcoin/issues/30367)

🚀 fanquake merged a pull request: "MiniMiner: use FeeFrac in AncestorFeerateComparator"
(https://github.com/bitcoin/bitcoin/pull/30412)

👍 hebasto approved a pull request: "Keep focus on "Hide" while ModalOverlay is visible"
(https://github.com/bitcoin-core/gui/pull/795#pullrequestreview-2177280212)
re-ACK 992b1bbd5da95ee782515fb0f5674bb7a02684b2

✅ hebasto closed an issue: "Weird focus rect displayed on inital sync"
(https://github.com/bitcoin-core/gui/issues/783)

🚀 hebasto merged a pull request: "Keep focus on "Hide" while ModalOverlay is visible"
(https://github.com/bitcoin-core/gui/pull/795)

👍 dergoegge approved a pull request: "kernel: De-globalize static validation variables"
(https://github.com/bitcoin/bitcoin/pull/30425#pullrequestreview-2177300151)
Code review ACK 51fa26239af9bbfd44029aaf595cb4c6a8d4a75d

💬 hebasto commented on issue "Welcome screen uses GiB values as GB, risking running out of space":
(https://github.com/bitcoin-core/gui/issues/821#issuecomment-2228117027)
Also see https://github.com/bitcoin/bitcoin/pull/29678.

👍 dergoegge approved a pull request: "fuzz: bound some miniscript operations to avoid fuzz timeouts"
(https://github.com/bitcoin/bitcoin/pull/30197#pullrequestreview-2177308717)
utACK bc34bc288824978ef4b98e8802b47cb863c8a8c2

👍 dergoegge approved a pull request: "fuzz: fix key size in `crypter`"
(https://github.com/bitcoin/bitcoin/pull/30373#pullrequestreview-2177316284)
utACK 4383dc90bac1b5def73352fe222f99807d8ca4dd

💬 glozow commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#issuecomment-2228142149)
concept ACK

👍 dergoegge approved a pull request: "Add fuzz test for FSChaCha20Poly1305, AEADChacha20Poly1305"
(https://github.com/bitcoin/bitcoin/pull/28263#pullrequestreview-2177332281)
tACK 39805638663bdd567a50ecac962631b45ce8d73a

💬 dergoegge commented on pull request "Add fuzz test for FSChaCha20Poly1305, AEADChacha20Poly1305":
(https://github.com/bitcoin/bitcoin/pull/28263#discussion_r1677597969)
nit:

```suggestion
auto aad{rng.randbytes<std::byte>(aad_length)};
```