💬 hebasto commented on pull request "test/BIP324: disconnection scenarios during v2 handshake":
(https://github.com/bitcoin/bitcoin/pull/29431#issuecomment-2227216955)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#issuecomment-2227217140)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "build: add `-Wundef`":
(https://github.com/bitcoin/bitcoin/pull/29876#issuecomment-2227217262)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "Encapsulate warnings in generalized node::Warnings and remove globals":
(https://github.com/bitcoin/bitcoin/pull/30058#issuecomment-2227217405)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "kernel: De-globalize validation caches":
(https://github.com/bitcoin/bitcoin/pull/30141#issuecomment-2227217508)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "util: add BitSet":
(https://github.com/bitcoin/bitcoin/pull/30160#issuecomment-2227217787)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "util: add VecDeque":
(https://github.com/bitcoin/bitcoin/pull/30161#issuecomment-2227217854)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "test: MiniWallet: respect passed feerate for padded txs (using `target_weight`)":
(https://github.com/bitcoin/bitcoin/pull/30162#issuecomment-2227217923)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "depends: remove `FORCE_USE_SYSTEM_CLANG`":
(https://github.com/bitcoin/bitcoin/pull/30201#issuecomment-2227218096)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "doc: use TRUC instead of v3 and add release note":
(https://github.com/bitcoin/bitcoin/pull/30272#issuecomment-2227218237)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "kernel: remove mempool_persist":
(https://github.com/bitcoin/bitcoin/pull/30344#issuecomment-2227218290)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "random: add benchmarks and drop unnecessary Shuffle function":
(https://github.com/bitcoin/bitcoin/pull/30396#issuecomment-2227218388)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "remove truc_policy from libbitcoin_common_a_SOURCES":
(https://github.com/bitcoin/bitcoin/pull/30427#issuecomment-2227218487)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "build: Fix building `fuzz` binary on on SunOS / illumos":
(https://github.com/bitcoin/bitcoin/pull/30216#issuecomment-2227224103)
There is nothing to port to the CMake staging branch. Deleting the "Needs CMake port" label.

💬 hebasto commented on pull request "ci: move ASan job to GitHub Actions from Cirrus CI":
(https://github.com/bitcoin/bitcoin/pull/30193#issuecomment-2227224395)
There is nothing to port to the CMake staging branch. Deleting the "Needs CMake port" label.

💬 hebasto commented on pull request "build: Drop redundant `sys/sysctl.h` header check":
(https://github.com/bitcoin/bitcoin/pull/30327#issuecomment-2227224621)
There is nothing to port to the CMake staging branch. Deleting the "Needs CMake port" label.

💬 hebasto commented on pull request "Update libsecp256k1 subtree to latest master":
(https://github.com/bitcoin/bitcoin/pull/30334#issuecomment-2227224889)
There is nothing to port to the CMake staging branch. Deleting the "Needs CMake port" label.

💬 hebasto commented on pull request "fix: rendering an amp characters in the wallet name for QMenu":
(https://github.com/bitcoin-core/gui/pull/828#issuecomment-2227303124)
> In the current implementation Qt uses '&' as a signal to underscore letter and use it as a hot-key, which is not expected for case of wallet name.

Does this hold for all [supported](https://github.com/bitcoin-core/gui/blob/master/doc/dependencies.md) Qt versions?

>
> The [comment in the code](https://github.com/bitcoin/bitcoin/pull/30446/files#diff-2ecf8cbf369cf3d2f3d2b1cf5cfe4c1a647d63e11e2885d2fd0ac11fb5f7a804L402-L404) is misleading, if you replace one & to double &&, the next & wil
...

💬 hebasto commented on pull request "Migrate legacy wallets that are not loaded":
(https://github.com/bitcoin-core/gui/pull/824#discussion_r1677109394)
https://github.com/bitcoin-core/gui/pull/828 can relevant to this code.

💬 hebasto commented on pull request "Migrate legacy wallets that are not loaded":
(https://github.com/bitcoin-core/gui/pull/824#discussion_r1677109570)
Mind following the Doxygen comment formatting above?