💬 Sjors commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2225041208)
> the framework is nonblocking, so there is no problem with the client making multiple calls at the same time, and the client can also decide what threads in the server the calls run on. So any interface you would like to implement should be possible to implement.

I'm not sure if that helps. I was also a bit confused, so let me rephrase it:

The current interface `createNewBlock` returns a template, which contains 4 MB of serialized transaction data. Ideally I would _not_ include those tran
...

💬 maflcko commented on pull request "assumeutxo: Add dumptxoutset height param, remove shell scripts":
(https://github.com/bitcoin/bitcoin/pull/29553#discussion_r1675479974)
I guess it would still be good to leave a comment about the race in the source code (or in the docs on how to avoid the race). I guess the user would simply have to avoid calling other `*block` RPCs for the duration of `dumptxoutset`? (The p2p is already stopped, so shouldn't be the cause of a race)

💬 rkrux commented on pull request "Fee Estimation: Ignore all transactions that are CPFP'd":
(https://github.com/bitcoin/bitcoin/pull/30079#discussion_r1675498531)
Great, thank you!

👍 alfonsoromanz approved a pull request: "assumeutxo: Don't load a snapshot if it's not in the best header chain"
(https://github.com/bitcoin/bitcoin/pull/30320#pullrequestreview-2174193471)
Re ACK 55b6d7be68a6f6c3882588ffd5b9349d885ed953

🚀 fanquake merged a pull request: "depends: update doc in Qt pwd patch"
(https://github.com/bitcoin/bitcoin/pull/30336)

💬 maflcko commented on pull request "rpc: Avoid getchaintxstats invalid results":
(https://github.com/bitcoin/bitcoin/pull/29720#issuecomment-2225104347)
See https://github.com/bitcoin/bitcoin/issues/29359

📝 hodlinator opened a pull request: "fix: Make TxidFromString() respect string_view length"
(https://github.com/bitcoin/bitcoin/pull/30436)
Prompted by comment in https://github.com/bitcoin/bitcoin/pull/30377#issuecomment-2208857200 (referring to https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1404437378).

💬 hodlinator commented on pull request "refactor: Make uint256S(const char*) consteval":
(https://github.com/bitcoin/bitcoin/pull/30377#issuecomment-2225154172)
> > **transaction_identifier.h** - Fixed dormant bug in `TxidFromString()` where the `string_view` length wasn't respected(!).
>
> This is known, see [#28922 (comment)](https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1404437378). Thanks for picking it up!
>
> Maybe submit the fix first?

PR up now: #30436

💬 maflcko commented on pull request "depends: bump boost to 1.85.0 and use new CMake buildsystem":
(https://github.com/bitcoin/bitcoin/pull/30434#issuecomment-2225163931)
The CI failure https://cirrus-ci.com/task/4950868422819840:

```
Extracting boost...
/ci_container_base/depends/sources/boost-1.85.0-cmake.tar.gz: OK
Preprocessing boost...
Configuring boost...
-- The CXX compiler identification is Clang 18.1.3
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/env - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Boost: using system layout: i
...

💬 fjahr commented on pull request "assumeutxo: Add dumptxoutset height param, remove shell scripts":
(https://github.com/bitcoin/bitcoin/pull/29553#discussion_r1675572668)
I added a small comment and also mention it now in the usage guide as well as the rpc help text.

🚀 fanquake merged a pull request: "util: Use SteadyClock in RandAddSeedPerfmon"
(https://github.com/bitcoin/bitcoin/pull/30372)

💬 maflcko commented on issue "ci: failure in `p2p_unrequested_blocks.py`":
(https://github.com/bitcoin/bitcoin/issues/30430#issuecomment-2225189511)
Dupe of https://github.com/bitcoin/bitcoin/issues/29897 ?

✅ fanquake closed an issue: "ci: failure in `p2p_unrequested_blocks.py`"
(https://github.com/bitcoin/bitcoin/issues/30430)

💬 fanquake commented on issue "ci: failure in `p2p_unrequested_blocks.py`":
(https://github.com/bitcoin/bitcoin/issues/30430#issuecomment-2225193937)
Yea looks like it. I grepped for p2p_unrequested_blocks but somehow did not find that.

💬 maflcko commented on issue "ci: failure in `p2p_unrequested_blocks.py`":
(https://github.com/bitcoin/bitcoin/issues/30430#issuecomment-2225196887)
Yeah, it is a github search bug. You'll have to search for `test.py` (with the `.py` suffix)

💬 m3dwards commented on pull request "net: Allow -proxy=[::1] on nodes with IPV6 lo only":
(https://github.com/bitcoin/bitcoin/pull/30245#discussion_r1675595527)
I think it's overkill. In all the examples and documentation I've read, `freeaddrinfo()` is only called when `getaddrinfo()` succeeds.

👍 hebasto approved a pull request: "init: change shutdown order of load block thread and scheduler"
(https://github.com/bitcoin/bitcoin/pull/30435#pullrequestreview-2174334468)
ACK e427fed82f7931ae6f09a4939e0fcd6cb235ef0d, the change looks correct and it indeed [fixes](https://github.com/bitcoin/bitcoin/issues/30424#issuecomment-2223971606) the issue.

💬 delta1 commented on pull request "refactor: Allow CScript construction from any std::input_iterator":
(https://github.com/bitcoin/bitcoin/pull/29369#issuecomment-2225223670)
reACK fa7b9b9

💬 glozow commented on pull request "MiniMiner: use FeeFrac in AncestorFeerateComparator":
(https://github.com/bitcoin/bitcoin/pull/30412#discussion_r1675637623)
I'll add an update to the comment if I retouch

💬 fjahr commented on pull request "assumeutxo: Add dumptxoutset height param, remove shell scripts":
(https://github.com/bitcoin/bitcoin/pull/29553#issuecomment-2225269474)
Rebased and addressed feedback from @ryanofsky and @maflcko, thank you! This now includes the check for undo data since this was made possible by merge of https://github.com/bitcoin/bitcoin/pull/29668.