⚠️ rishkwal opened an issue: "utils: add support for `bitcoin-wallet` tool configuration file"
(https://github.com/bitcoin/bitcoin/issues/30421)
### Please describe the feature you'd like to see added.

I would like to propose the addition of support for a configuration file specifically for the `bitcoin-wallet` tool. This feature would allow users to specify command-line options in a configuration file (e.g., `wallet.conf`), similar to how `bitcoin.conf` works for `bitcoind`. The configuration file should be automatically loaded by `bitcoin-wallet` if present in the default data directory or specified via a command-line option.

### Is
...

💬 andrewtoth commented on pull request "rpc, rest: Improve getblock error when only header is available":
(https://github.com/bitcoin/bitcoin/pull/30410#discussion_r1672277667)
```suggestion
if (!(blockindex.nStatus & BLOCK_HAVE_UNDO)) {
```

💬 andrewtoth commented on pull request "Don't empty dbcache on prune flushes: >30% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/28280#discussion_r1672281518)
Ahh yes (this comment)[https://github.com/bitcoin/bitcoin/pull/28280/files#diff-f0ed73d62dae6ca28ebd3045e5fc0d5d02eaaacadb4c2a292985a3fbd7e1c77cL269-L270] is removed in this patch, and should actually probably go right here. Perhaps I do this in a follow-up to not invalidate your ACK?

💬 hebasto commented on pull request "refactor: modernize-use-equals-default":
(https://github.com/bitcoin/bitcoin/pull/30406#issuecomment-2220528557)
Concept ACK.

💬 stratospher commented on pull request "test: Fix intermittent failure in p2p_v2_misbehaving.py":
(https://github.com/bitcoin/bitcoin/pull/30420#issuecomment-2220588439)
> I could verify that the issue I see with sleep(3) is fixed with the change here. However, when I increase the number from 3 to 5 or 10 I still see other errors, so there may be more potential for race conditions here.

@fjahr good find! both the errors which you shared are because of disconnections due to [`InactivityCheck` triggers](https://github.com/bitcoin/bitcoin/blob/9adebe145557ef410964dd48a02f3d239f488cd0/src/net.cpp#L1987) from setting `peertimeout=3` in the test. I've increased it
...

👍 ryanofsky approved a pull request: "util: Catch translation string errors at compile time"
(https://github.com/bitcoin/bitcoin/pull/30383#pullrequestreview-2169220669)
Code review ACK fa601ab9f7142cdb18c18c1128fc893cdffb3463

💬 fjahr commented on pull request "test: Fix intermittent failure in p2p_v2_misbehaving.py":
(https://github.com/bitcoin/bitcoin/pull/30420#issuecomment-2220616409)
tACK 53f43293875de086cd0bd424fd582bc232bec3a3

💬 maflcko commented on pull request "test: Fix intermittent failure in p2p_v2_misbehaving.py":
(https://github.com/bitcoin/bitcoin/pull/30420#discussion_r1672347562)
This means the test is idle for this time in wall clock time. You can use mocktime to fix this and also avoid intermittent issues on slow hardware. See for example `test/functional/p2p_timeouts.py`

🤔 maflcko reviewed a pull request: "test: Fix intermittent failure in p2p_v2_misbehaving.py"
(https://github.com/bitcoin/bitcoin/pull/30420#pullrequestreview-2169242866)
left two nits

💬 maflcko commented on pull request "test: Fix intermittent failure in p2p_v2_misbehaving.py":
(https://github.com/bitcoin/bitcoin/pull/30420#discussion_r1672350393)
Why is it required to set a timeout here at all? The log message should happen before the disconnect, which is waited on, no?

💬 ryanofsky commented on issue "utils: add support for `bitcoin-wallet` tool configuration file":
(https://github.com/bitcoin/bitcoin/issues/30421#issuecomment-2220623751)
I tend to think it would be better if the wallet-tool just loaded the `bitcoin.conf` file and used applicable settings from it instead of having its own config file. I actually implemented this in ae5fc323b2441bc45c38737f1ffb40d777b134d8 from #27409 (for an unrelated reason, mentioned in the commit message).

The advantage of having one config file instead of two is it might avoid the need to specify the same settings twice, and avoid the possibility of inconsistent settings being specified. B
...

💬 fjahr commented on pull request "test, assumeutxo: Remove resolved todo comments and add new test":
(https://github.com/bitcoin/bitcoin/pull/30403#discussion_r1672417787)
fixed, thanks!

💬 maflcko commented on pull request "test: Fix intermittent failure in p2p_v2_misbehaving.py":
(https://github.com/bitcoin/bitcoin/pull/30420#discussion_r1672452850)
Ok, I see, the `peer.wait_for_disconnect()` immediately returns and doesn't do anything.

💬 kevkevinpal commented on pull request "test: Fix intermittent failure in p2p_v2_misbehaving.py":
(https://github.com/bitcoin/bitcoin/pull/30420#issuecomment-2220744320)
ACK [53f4329](https://github.com/bitcoin/bitcoin/pull/30420/commits/53f43293875de086cd0bd424fd582bc232bec3a3)

I tried increasing the time out to 6 seconds and that is when I started getting the error `OSError: Not connected`

💬 maflcko commented on pull request "test: Fix intermittent failure in p2p_v2_misbehaving.py":
(https://github.com/bitcoin/bitcoin/pull/30420#discussion_r1672462819)
My recommendation would be to remove `peer.wait_for_disconnect()`, since it doesn't do anything, and instead add an assert after the `assert_debug_log` scope to check the peer is disconnected.

💬 dergoegge commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2220756509)
> Niklas, everything you're saying may be true but it doesn't seem self evident.

Certainly! I think most of what I (and Matt) said are opinions and not ground truths. It does look like most of the actual discussion is philosophical in nature (software maintenance, willingness of users to run more than one piece of software, ...) and the eventual route we go will depend on a judgement call, which is why I find it important that more contributors with opinions chime in.

> I could imagine the
...

⚠️ Vero7979 opened an issue: "npm install json-payment-protocol"
(https://github.com/bitcoin/bitcoin/issues/30422)
Pay with BitPay at INFINITI of San Jose Dealership Info

Phone Numbers:
Main Line:
(408) 531-3000
Sales Direct:
(408) 531-3033
Service Direct:
(408) 531-3035
Parts Direct:
(408) 531-3032
INFINITI Roadside Assistance:
(800) 662-6200
Main:
4085313000
Sales Hours:
Mon - Sat
9:00 AM - 8:00 PM
Sun
10:00 AM - 7:00 PM
Service Hours:
Mon - Fri
7:30 AM - 6:00 PM
Sat
7:30 AM - 5:00 PM

✅ pinheadmz closed an issue: "npm install json-payment-protocol"
(https://github.com/bitcoin/bitcoin/issues/30422)

:lock: fanquake locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/30422)

👍 hebasto approved a pull request: "contrib: fix check-deps.sh to check for weak symbols"
(https://github.com/bitcoin/bitcoin/pull/30415#pullrequestreview-2169500423)
ACK 5a8b9432cde11f6140855717af195d8b7e798d75, tested on Ubuntu 24.04/