💬 instagibbs commented on pull request "#28984 package rbf followups":
(https://github.com/bitcoin/bitcoin/pull/30295#discussion_r1670908419)
removed

💬 instagibbs commented on pull request "#28984 package rbf followups":
(https://github.com/bitcoin/bitcoin/pull/30295#discussion_r1670908464)
done

💬 instagibbs commented on pull request "#28984 package rbf followups":
(https://github.com/bitcoin/bitcoin/pull/30295#discussion_r1670908480)
done

💬 theStack commented on pull request "net: fix race condition in self-connect detection":
(https://github.com/bitcoin/bitcoin/pull/30394#issuecomment-2218275587)
@mzumsande: Good catch! With that in my mind, I see the following paths forward:
1. Queue outbound VERSION message immediately in `CConnman::OpenNetworkConnection` (as done in a previous version of this PR: https://github.com/theStack/bitcoin/tree/202407-p2p-fix_selfdetection_racecond_oldversion, extending the `NetEventsInterface` with a new `SendInitialMessages` method, called at the end)
2. Adapt the current state of this PR to only start processing messages of outbound peers after `m_outbou
...

💬 dergoegge commented on pull request "net: fix race condition in self-connect detection":
(https://github.com/bitcoin/bitcoin/pull/30394#issuecomment-2218287690)
Option 2. seems the best to me.

💬 sipa commented on pull request "net: fix race condition in self-connect detection":
(https://github.com/bitcoin/bitcoin/pull/30394#issuecomment-2218293210)
I think (2) is a 1-line change: return immediately from `ProcessMessages` if no version message has been sent by us to the peer.

👍 ismaelsadeeq approved a pull request: "MiniMiner: use FeeFrac in AncestorFeerateComparator"
(https://github.com/bitcoin/bitcoin/pull/30412#pullrequestreview-2167005183)
Tested ACK 09370529fb9f6d06f6d16bdb1fb336f7a265d8ba

💬 ryanofsky commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2218317900)
re: https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2211245443

> Yet another approach for said sidecar is to use IPC. It offers first class access to the node, e.g. via the newly added mining interface. It can probably automagically find a running Bitcoin Core process or spin one up. This would require more (review) progress in #10102 and additional tooling so external application can easily use IPC.

I don't actually think much in #10102 is needed, because the bulk of #10102 is
...

💬 garlonicon commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2218329966)
Well, I already shared a diff somewhere: https://bitcointalk.org/index.php?topic=5496494.msg64205870#msg64205870

I simply don't know a better way to compete with ASICs on testnets. Because testnet3 and testnet4 are the only networks I know of, where CPUs and ASICs can co-exist.

For example: if after 20 minutes, any block would be accepted, but at the same time, the real difficulty would be placed in the block header, then that kind of trick would be impossible, because ASICs would triviall
...

💬 theStack commented on pull request "net: fix race condition in self-connect detection":
(https://github.com/bitcoin/bitcoin/pull/30394#issuecomment-2218330911)
> Option 2. seems the best to me.

> I think (2) is a 1-line change: return immediately from `ProcessMessages` if no version message has been sent by us to the peer.

Thanks for the quick feedback, done.

✅ ryanofsky closed a pull request: "assumeutxo: Remove translated strings added in 30267"
(https://github.com/bitcoin/bitcoin/pull/30417)

💬 ryanofsky commented on pull request "assumeutxo: Remove translated strings added in 30267":
(https://github.com/bitcoin/bitcoin/pull/30417#issuecomment-2218345172)
> This is also done in #30395.

Oh, thanks I missed that. Closing.

💬 Christewart commented on pull request "policy: Add PayToAnchor(P2A), `OP_TRUE <0x4e73>` as a standard output script for spending":
(https://github.com/bitcoin/bitcoin/pull/30352#issuecomment-2218349630)
IIUC these txs will not get relayed widely across the network until there is widespread adoption of `bitcoind` versions that adopt these txs as standard?

💬 instagibbs commented on pull request "policy: Add PayToAnchor(P2A), `OP_TRUE <0x4e73>` as a standard output script for spending":
(https://github.com/bitcoin/bitcoin/pull/30352#issuecomment-2218354375)
@Christewart spends of these outputs will not propagate until some 10%+ of the network updates, correct.

💬 Christewart commented on pull request "policy: Add PayToAnchor(P2A), `OP_TRUE <0x4e73>` as a standard output script for spending":
(https://github.com/bitcoin/bitcoin/pull/30352#issuecomment-2218357340)
> @Christewart spends of these outputs will not propagate until some 10%+ of the network updates, correct.

Worth mentioning this in the release notes as this feature is intended for time sensitive protocols. Perhaps putting the cart before the horse, but it is a potential foot gun.

💬 melvincarvalho commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2218357984)
Great analysis, thanks

I have seen two instances where the diff drops to 1. The first is when the mining dries up for 20 minutes, and then someone will mine a block, just to keep the chain going (normally wiz :)).

The other is when people are deliberately propagating blocks with a future timestamp, up to about 6 blocks. Coincidentally 6 * 20 = 2 hours. I do not know what triggers this.

The 20 minute rule when used properly is quite nice as it keeps the chain flowing. The future spoo
...

💬 ryanofsky commented on pull request "rpc: Use untranslated error strings in loadtxoutset":
(https://github.com/bitcoin/bitcoin/pull/30395#discussion_r1670972864)
In commit "rpc: Use untranslated error strings in loadtxoutset" (fa5b8920be041380fbfa4c7b443918637423d7a0)

Not important, but you could change this from `bilingual_str&&` to just `bilingual_str` so it is simpler, and function can be called naturally with both lvalues and rvalues, not just rvalues. Rvalues will be moved in any case.

👍 ryanofsky approved a pull request: "rpc: Use untranslated error strings in loadtxoutset"
(https://github.com/bitcoin/bitcoin/pull/30395#pullrequestreview-2167052588)
Code review ACK fa5b8920be041380fbfa4c7b443918637423d7a0

💬 instagibbs commented on pull request "policy: Add PayToAnchor(P2A), `OP_TRUE <0x4e73>` as a standard output script for spending":
(https://github.com/bitcoin/bitcoin/pull/30352#issuecomment-2218389213)
@Christewart done, since it would need a release note anyways

👍 itornaza approved a pull request: "refactor: add coinbase constraints to BlockAssembler::Options"
(https://github.com/bitcoin/bitcoin/pull/30356#pullrequestreview-2167070268)
Concept ACK d89637eceab0145a64c2d1af1139ace204a3ab3c

Giving the option to assign the values of `coinbase_max_additional_weight` and `coinbase_output_max_additional_sigops` needed by the Stratum V2 protocol is essential for its integration. I understand the risks involved by having two parameters for the same thing:

> 1. The max block weight demanded by the user via -blockmaxweight
> 2. Weight units reserved for the coinbase

but it seems unavoidable at a first glance due to thei
...