🤔 glozow reviewed a pull request: "net: fix race condition in self-connect detection"
(https://github.com/bitcoin/bitcoin/pull/30394#pullrequestreview-2166427591)
lgtm, do you plan to take any of the suggestions?

💬 glozow commented on pull request "net: fix race condition in self-connect detection":
(https://github.com/bitcoin/bitcoin/pull/30394#discussion_r1670590969)
nitty nit: this diff should be in f8594553fab6f865b13be4d5873b4ff55aae62d2, not e1349beed448cbecb276991019e78f0fccf579cd

💬 glozow commented on issue "Mini miner `AncestorFeerateComparator` Signed Integer Overflow":
(https://github.com/bitcoin/bitcoin/issues/30284#issuecomment-2217978085)
Ah, I think #30412 might fix this since `FeeFrac::Mul` handles the overflow? I'm not sure how to get the input from that CI task so I can check.

💬 glozow commented on pull request "Fee Estimation: Ignore all transactions that are CPFP'd":
(https://github.com/bitcoin/bitcoin/pull/30079#discussion_r1670728220)
instead of b1b28a21e185dfbc0c75f92ac55401a9ba8a5b08, I'd recommend rebasing on #30412
I was able to reproduce the ub crash and verify that 6254c253e995e77196b853784cfd0f42619b324d fixes it.

🤔 ismaelsadeeq reviewed a pull request: "MiniMiner: use FeeFrac in AncestorFeerateComparator"
(https://github.com/bitcoin/bitcoin/pull/30412#pullrequestreview-2166670402)
Concept ACK 271469b8bcb84af8f7a64c530e9cee7e0bf96352

💬 ismaelsadeeq commented on pull request "Fee Estimation: Ignore all transactions that are CPFP'd":
(https://github.com/bitcoin/bitcoin/pull/30079#discussion_r1670741214)
thanks I will rebase on it.

📝 ryanofsky opened a pull request: "contrib: fix check-deps.sh to check for weak symbols"
(https://github.com/bitcoin/bitcoin/pull/30415)
Fix check-deps.sh to check for weak symbols so it can detect when an exported template function like `TryParseHex` is used from another library.

Also add suppression because consensus library is currently using the `TryParseHex` function from util, when the consensus library is not supposed to depend on the util library.

Problem was reported by hebasto in https://github.com/bitcoin/bitcoin/pull/29015#issuecomment-2209258843

💬 darosior commented on pull request "PoC: fuzz chainstate and block managers":
(https://github.com/bitcoin/bitcoin/pull/29158#discussion_r1670749288)
When debating this with myself my weak argument in favour of it was that the target was very slow and this could help discover interesting paths faster. I also wanted your feedback on this, so thanks.

💬 theStack commented on pull request "net: fix race condition in self-connect detection":
(https://github.com/bitcoin/bitcoin/pull/30394#issuecomment-2218045821)
> lgtm, do you plan to take any of the suggestions?

Tackled all of the ordinary and nitty nits (thanks Marco and Gloria), re-review should be trivial.

💬 ismaelsadeeq commented on pull request "Fee Estimation: Ignore all transactions that are CPFP'd":
(https://github.com/bitcoin/bitcoin/pull/30079#discussion_r1670763260)
done

💬 sipa commented on pull request "net: fix race condition in self-connect detection":
(https://github.com/bitcoin/bitcoin/pull/30394#issuecomment-2218076997)
utACK a3122d38c65577cc13d88f8690da1e8f9d959c74, only reviewed the test change lightly.

🤔 sipa reviewed a pull request: "MiniMiner: use FeeFrac in AncestorFeerateComparator"
(https://github.com/bitcoin/bitcoin/pull/30412#pullrequestreview-2166777545)
utACK 271469b8bcb84af8f7a64c530e9cee7e0bf96352

💬 sipa commented on pull request "MiniMiner: use FeeFrac in AncestorFeerateComparator":
(https://github.com/bitcoin/bitcoin/pull/30412#discussion_r1670783767)
Nit: could be `return std::min(self_feerate, ancestor_feerate);`

🤔 mzumsande reviewed a pull request: "net: fix race condition in self-connect detection"
(https://github.com/bitcoin/bitcoin/pull/30394#pullrequestreview-2166824948)
I wonder if this could this lead to problems with "non-shy" software that would sends VERSION immediately on incoming connection (which bitcoin core doesn't do thanks to Hal Finney's #101, but alternative clients might).

When Bitcoin Core makes an outgoing connection after this patch, it won't send out the version message immediately, so it could receive a version message before sending one. In that case, I think that `ProcessMessage` could send out other messages (WTXIDRELAY etc.) before sen
...

🤔 BrandonOdiwuor reviewed a pull request: "rpc: doc: use "output script" terminology consistently in "asm"/"hex" results"
(https://github.com/bitcoin/bitcoin/pull/30408#pullrequestreview-2166843016)
ACK 29eafd5733d77b3e8f3f3ab6cd65c61ac0e8536b

LGTM

💬 glozow commented on pull request "MiniMiner: use FeeFrac in AncestorFeerateComparator":
(https://github.com/bitcoin/bitcoin/pull/30412#discussion_r1670835969)
done

💬 dergoegge commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2218139440)
> And compared to Bitcoin Core no one runs these things

Because not everyone needs to run these things but if they want to they can. Cramming everything into one software project is not sustainable.

> Indeed, it is absolutely a maintenance burden, but we've seen time and time and time again - nearly every project in Bitcoin outside of Bitcoin Core has not been sustainable and eventually turns into abandonware.

If it would end up unmaintained outside of Bitcoin Core, then it'd also end u
...

⚠️ VojtechMyslivec opened an issue: "Send RPC calls performance"
(https://github.com/bitcoin/bitcoin/issues/30416)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

I want to report performance changes of `sendmany` and `sendtoaddress` RPC calls.

We use fresh-new wallet for more than an year. There are 24 descriptors in the wallet from which 12 were imported from about a month older wallet. We generated circa 300 k addresses from these imported descriptors and hundreds of addresses from the new ones. We had send about 1500 transactions from this wa
...

💬 VojtechMyslivec commented on issue "Send RPC calls performance":
(https://github.com/bitcoin/bitcoin/issues/30416#issuecomment-2218170930)
#26008 may relate? I am not sure if it was included in 27.0 release

📝 ryanofsky opened a pull request: "assumeutxo: Remove translated strings added in 30267"
(https://github.com/bitcoin/bitcoin/pull/30417)
maflcko pointed out in https://github.com/bitcoin/bitcoin/pull/30267#pullrequestreview-2155603386 that some error strings were being translated unneccessarily and incorrectly in #30267.

Switch them to untranslated for now. In the future if we add a GUI feature for loading snapshots, and it seems like it could be possible to trigger some of the errors, they could be translated at that point.

Also remove a newline in a thrown RPC exception.