💬 maflcko commented on pull request "optimization: Speed up Base58 encoding/decoding by 400%/200% via preliminary byte packing":
(https://github.com/bitcoin/bitcoin/pull/29473#issuecomment-2202249394)
I don't think I said that "this is an important usecase". I simply said that the reason for the improvement in https://github.com/bitcoin/bitcoin/pull/7656#issue-139438690 was `listunspent`. That pull request was created before bech32(m) addresses and descriptor wallets existed. Considering that bech32 is the default address type and that descriptor wallets are the default as well, the only remaining use of base58 should be in the bip-32 descriptor string. My guess is that, if it was important t
...

💬 Sjors commented on pull request "doc: external-signer, example 'createwallet' RPC call requires eight argument":
(https://github.com/bitcoin/bitcoin/pull/30354#discussion_r1662079837)
You should be able to drop most of these named arguments, except `wallet_name` and `external_signer`. Most are already defaults, except `avoid_reuse` but that's not relevant to this tutorial.

💬 Sjors commented on pull request "doc: external-signer, example 'createwallet' RPC call requires eight argument":
(https://github.com/bitcoin/bitcoin/pull/30354#issuecomment-2202306333)
Do you happen to know which pull request added a new positional argument in the middle? Or was this instruction always broken? cc @achow101

🚀 fanquake merged a pull request: "Revert "test: p2p: check that connecting to ourself leads to disconnect""
(https://github.com/bitcoin/bitcoin/pull/30374)

📝 glozow opened a pull request: "26.2 final changes"
(https://github.com/bitcoin/bitcoin/pull/30376)
bins were uploaded 2 weeks ago on June 18
website PR: https://github.com/bitcoin-core/bitcoincore.org/pull/1039

💬 willcl-ark commented on pull request "Fix cases of calls to `FillPSBT` errantly returning `complete=true`":
(https://github.com/bitcoin/bitcoin/pull/30357#issuecomment-2202382063)
Rebased to fix CI

💬 glozow commented on pull request "kernel: remove mempool_persist":
(https://github.com/bitcoin/bitcoin/pull/30344#issuecomment-2202387405)
ACK f1478c0545

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1662139846)
`m_by_nodeid` is managed by `PrivateBroadcast::PushedToNode()` and `PrivateBroadcast::FinishBroadcast()`.

🚀 glozow merged a pull request: "kernel: remove mempool_persist"
(https://github.com/bitcoin/bitcoin/pull/30344)

💬 stickies-v commented on pull request "26.2 final changes":
(https://github.com/bitcoin/bitcoin/pull/30376#discussion_r1662135074)
nit (which also affects manpages)
```suggestion
define(_COPYRIGHT_YEAR, 2024)
```

👍 stickies-v approved a pull request: "26.2 final changes"
(https://github.com/bitcoin/bitcoin/pull/30376#pullrequestreview-2153177017)
ACK 41985528b9c7faf19a05b00ecaec9b8f2d1b3895

I rebased this branch on the latest 26.x branch (6bbfdcfb6d6a620216eb8cdb50c238113cd77e6e, includes https://github.com/bitcoin/bitcoin/pull/30319) but manpages are unchanged, so this should be fine.

💬 fjahr commented on pull request "rpc: Avoid getchaintxstats invalid results":
(https://github.com/bitcoin/bitcoin/pull/29720#issuecomment-2202556340)
re-ACK 2342b46c451658a418f8e28e50b2ad0e5abd284d

Confirmed only changes were rebase and typo-fix, per `git range-diff master ef692e52b4121ba3d8de91e45b2d33aff946e8d2 2342b46c451658a418f8e28e50b2ad0e5abd284d`.

✅ willcl-ark closed an issue: ""netinfo" doesn't show IPv6 "Local addresses""
(https://github.com/bitcoin/bitcoin/issues/30165)

💬 willcl-ark commented on issue ""netinfo" doesn't show IPv6 "Local addresses"":
(https://github.com/bitcoin/bitcoin/issues/30165#issuecomment-2202562859)
OK I'm going to close this for now.

Feel free to open a new issue or comment here if you are still experiencing this problem.

💬 glozow commented on pull request "26.2 final changes":
(https://github.com/bitcoin/bitcoin/pull/30376#discussion_r1662211978)
thanks, taken

💬 glozow commented on pull request "26.2 final changes":
(https://github.com/bitcoin/bitcoin/pull/30376#issuecomment-2202578548)
Rebased and made copyright year update, thanks @stickies-v!

👍 stickies-v approved a pull request: "26.2 final changes"
(https://github.com/bitcoin/bitcoin/pull/30376#pullrequestreview-2153323242)
ACK eef5dbc21b3fd52069f2f0855fb76a13234ebbf3

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1662227439)
Yes, moved to a constant and added a comment to it. Placed the constant in the `.cpp` file since it is only used in that `.cpp` file, to limit its scope. It is not part of the "public" `private_broadcast.h/cpp` interface

👍 willcl-ark approved a pull request: "Fix SSE4.1-related issues"
(https://github.com/bitcoin/bitcoin/pull/28893#pullrequestreview-2153336754)
tACK d440f13db02c82c842000abe4fe4d0c721a4ad3b

These changes fix the issues correctly in my testing on Ubuntu.

I do slightly prefer how my changeset printed a configure-time [warning message](https://github.com/bitcoin/bitcoin/commit/20b1fe92c87a86c8df4f1c7a0529a7d9e6710571#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810R537) for the user that SHANI support would be disabled if SSE4.1 was not enabled, but overall prefer the approach of this fix.

👍 alfonsoromanz approved a pull request: "test: Added coverage to Block not found error using gettxoutsetinfo"
(https://github.com/bitcoin/bitcoin/pull/30340#pullrequestreview-2153338081)
Re ACK 8ec24bdad89e2a72c394060ba5661a91f374b874