💬 paplorinc commented on pull request "optimization: Moved repeated `-printpriority` fetching out of AddToBlock":
(https://github.com/bitcoin/bitcoin/pull/30324#discussion_r1658676556)
Makes sense, removed

💬 willcl-ark commented on issue "make check errors on big endian OpenBSD 7.2":
(https://github.com/bitcoin/bitcoin/issues/26492#issuecomment-2196820695)
@grubles what's the current status of this issue?

Are you able to test with newer versions of Bitcoin Core, e.g. v27.1 and/or v26.2?

Reading the above, it seems to me like we can probably close this now otherwise.

💬 maflcko commented on pull request "net_processing: make any misbehavior trigger immediate discouragement":
(https://github.com/bitcoin/bitcoin/pull/29575#discussion_r1658695155)
@sr-gi Do you want to follow-up on this?

✅ maflcko closed an issue: "make check errors on big endian OpenBSD 7.2"
(https://github.com/bitcoin/bitcoin/issues/26492)

💬 maflcko commented on issue "make check errors on big endian OpenBSD 7.2":
(https://github.com/bitcoin/bitcoin/issues/26492#issuecomment-2196844812)
Closing for now, due to inactivity

💬 stickies-v commented on pull request "kernel: De-globalize validation caches":
(https://github.com/bitcoin/bitcoin/pull/30141#issuecomment-2196845660)
re-ACK 475c57ba482abd8675d0d3ccde98452808be5536, addressing outstanding review nits / touchups, no fundamental changes.

💬 grubles commented on issue "make check errors on big endian OpenBSD 7.2":
(https://github.com/bitcoin/bitcoin/issues/26492#issuecomment-2196845849)
Hello, I will give it a try this weekend with the latest OpenBSD since 7.2 is EOL now.

💬 willcl-ark commented on issue "make check errors on big endian OpenBSD 7.2":
(https://github.com/bitcoin/bitcoin/issues/26492#issuecomment-2196848131)
Thanks, it would be good to know if it's still a problem.

If it is, we can re-open here (if you comment in here) or open a new issue.

💬 sipa commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#discussion_r1658724899)
That looks very interesting. Going to leave this for a follow-up, as it'll need some benchmarking.

💬 sipa commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#discussion_r1658725627)
Going to leave this as a follow-up (I think making this work with CRTP may mean splitting it up into two concepts).

💬 sipa commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#discussion_r1658726118)
Done.

💬 sipa commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#discussion_r1658726213)
Done.

💬 TheCharlatan commented on pull request "kernel: remove mempool_persist":
(https://github.com/bitcoin/bitcoin/pull/30344#issuecomment-2196906030)
Re-ACK f1478c05458562a9bef5c2ba43959d758e7b4745

> I'll ping you on these in the future to make sure you don't already have them teed up.

No worries, it's nice to see contributions from more developers, and if there is some redundant work every now and then, it just means it was reviewed already :)

🤔 marcofleon reviewed a pull request: "test: Add Compact Block Encoding test `ReceiveWithExtraTransactions` covering non-empty `extra_txn`"
(https://github.com/bitcoin/bitcoin/pull/30237#pullrequestreview-2148020508)
Code review ACK 55eea003af24169c883e1761beb997e151845225. I ran the `blockencodings` unit test and no issues with the new test case.

💬 hodlinator commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#discussion_r1658606208)
`LogPrintf` is deprecated since f7ce5ac08c669ac763e275bb7c82dcfb2b1b6c33 / August 2023. Should use `LogInfo`.

💬 hodlinator commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#discussion_r1658532351)
*node 2

💬 theuni commented on pull request "kernel: De-globalize validation caches":
(https://github.com/bitcoin/bitcoin/pull/30141#discussion_r1658781284)
I believe the idea behind these nonces is to introduce diversity so that everyone has a different cache. That way there's no possibility of poisoning the "global" cache.

👍 stickies-v approved a pull request: "kernel: remove mempool_persist"
(https://github.com/bitcoin/bitcoin/pull/30344#pullrequestreview-2148087355)
ACK f1478c05458562a9bef5c2ba43959d758e7b4745

I think kernel should have an interface that (indirectly) allows users to dump/load mempool to/from disk (or elsewhere), but this `mempool_perist` implementation seems too node opinionated to be included in kernel.

💬 darosior commented on pull request "Wallet: don't underestimate the fees when spending a Taproot output":
(https://github.com/bitcoin/bitcoin/pull/26573#issuecomment-2196984111)
CI is erroring on
```
2024-06-28T11:41:00.1099453Z 5/309 - [1mwallet_fundrawtransaction.py --descriptors [0m failed, Duration: 30 s
2024-06-28T11:41:00.1100206Z
2024-06-28T11:41:00.1100438Z [1mstdout:
2024-06-28T11:41:00.1101244Z [0m2024-06-28T11:40:29.220000Z TestFramework (INFO): PRNG seed is: 3960890322720202555
2024-06-28T11:41:00.1108001Z 2024-06-28T11:40:29.221000Z TestFramework (INFO): Initializing test directory /home/runner/work/_temp/ci/scratch/test_runner/test_runner_₿_🏃_20
...

💬 theuni commented on pull request "kernel: De-globalize validation caches":
(https://github.com/bitcoin/bitcoin/pull/30141#discussion_r1658791383)
Nit: Commit message still says CSignatureCache :)