📝 Sjors converted_to_draft a pull request: "Support self-hosted Cirrus workers on forks"
(https://github.com/bitcoin/bitcoin/pull/29274)
I find myself making pull requests against my fork (mostly on top of #28983), or asking others to do so. Currently only the Github actions are run on forks, because we use self-hosted runners for the Cirrus tasks.

While setting up my own self-hosted runners for my fork, I ran into a number of issues. This PR addresses those.

Some issues are related to me using multiple regular users on the same physical machine, rather than running every worker in a VM. Update: these fixes have been absorb
...

💬 achow101 commented on pull request "net_processing: make any misbehavior trigger immediate discouragement":
(https://github.com/bitcoin/bitcoin/pull/29575#issuecomment-2181181414)
ACK 6eecba475efd025eb011400af58621ad5823994e

💬 achow101 commented on pull request "test: Validate oversized transactions or without inputs":
(https://github.com/bitcoin/bitcoin/pull/29862#issuecomment-2181185669)
ACK 969e047cfbab86e5819a2c9056e8d2dab17513a8

💬 achow101 commented on pull request "netbase: extend CreateSock() to support creating arbitrary sockets":
(https://github.com/bitcoin/bitcoin/pull/30202#issuecomment-2181186879)
ACK 1245d1388b003c46092937def7041917aecec8de

🚀 achow101 merged a pull request: "net_processing: make any misbehavior trigger immediate discouragement"
(https://github.com/bitcoin/bitcoin/pull/29575)

🚀 achow101 merged a pull request: "test: Validate oversized transactions or without inputs"
(https://github.com/bitcoin/bitcoin/pull/29862)

💬 paplorinc commented on pull request "test: Validate oversized transactions or without inputs":
(https://github.com/bitcoin/bitcoin/pull/29862#issuecomment-2181209430)
Thanks for the reviews!

🚀 achow101 merged a pull request: "netbase: extend CreateSock() to support creating arbitrary sockets"
(https://github.com/bitcoin/bitcoin/pull/30202)

💬 fanquake commented on pull request "doc: clarify Cirrus self-hosted workers setup":
(https://github.com/bitcoin/bitcoin/pull/30314#discussion_r1647945840)
> I don't know if it works out of the box for every distro out there

That's fine. Just assume it does until we know otherwise.

👍 theuni approved a pull request: "contrib: add R(UN)PATH check to ELF symbol-check"
(https://github.com/bitcoin/bitcoin/pull/30312#pullrequestreview-2131062085)
utACK 4289dd02cce688a69c596f7cd5e47f831b00aa1b

💬 itornaza commented on pull request "Introduce Mining interface":
(https://github.com/bitcoin/bitcoin/pull/30200#discussion_r1647945526)
non-blocking nit: In case you revise this file for a more serious reason, maybe consider adding an empty line here for more readability and consistence with the rest of this source file.

👍 itornaza approved a pull request: "Introduce Mining interface"
(https://github.com/bitcoin/bitcoin/pull/30200#pullrequestreview-2131043232)
Code review and std-tests ACK a9716c53f05082d6d89ebea51a46d4404efb12d7

Redirected to this PR from https://github.com/bitcoin/bitcoin/pull/29346#issuecomment-2139460402. I really like how clearly the mining interface is layed out after @ryanofsky comment https://github.com/bitcoin/bitcoin/pull/29346#issuecomment-2108528652 to further support @Sjors work on integrating the noise protocol that seems to be needed for stratum v2.

I have closely followed the commit history, built and run all sta
...

💬 itornaza commented on pull request "Introduce Mining interface":
(https://github.com/bitcoin/bitcoin/pull/30200#discussion_r1647947327)
non-blocking nit: For consistency with the rest of the headers in this file, you may want to convert the tabs after params to spaces.

👍 ryanofsky approved a pull request: "build: add `-Wundef`"
(https://github.com/bitcoin/bitcoin/pull/29876#pullrequestreview-2131081733)
Code review ACK 9e5bd977688f28a29806236f0faa55d5272f5b65

💬 sipa commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#issuecomment-2181274931)
Rebased after the merge of #30202.

💬 sr-gi commented on pull request "refactor: move m_is_inbound out of CNodeState":
(https://github.com/bitcoin/bitcoin/pull/30233#discussion_r1647999066)
Rebased

💬 sr-gi commented on pull request "refactor: move m_is_inbound out of CNodeState":
(https://github.com/bitcoin/bitcoin/pull/30233#issuecomment-2181323382)
Rebased on top of master to cover https://github.com/bitcoin/bitcoin/pull/30233#discussion_r1629164166, which was addressed by #29575

🤔 mzumsande reviewed a pull request: "assumeutxo: Check snapshot base block is not in invalid chain"
(https://github.com/bitcoin/bitcoin/pull/30267#pullrequestreview-2131034995)
Code Review ACK 750f8b50a749e577fc11f2f9f79e06cdd29e66f5

💬 mzumsande commented on pull request "assumeutxo: Check snapshot base block is not in invalid chain":
(https://github.com/bitcoin/bitcoin/pull/30267#discussion_r1647940464)
typo: parents

💬 mzumsande commented on pull request "assumeutxo: Check snapshot base block is not in invalid chain":
(https://github.com/bitcoin/bitcoin/pull/30267#discussion_r1648003009)
This changes it such that the path is no longer included in the RPC error. I think that it wasn't really helpful anyway (the user already provided the path when calling the RPC, so why the need to report it back to the user?), but just wanted to mention it because in cases someone would miss that.