💬 maflcko commented on pull request "util: check for errors after close and read in AutoFile":
(https://github.com/bitcoin/bitcoin/pull/29307#discussion_r1647191325)
The code you linked to is primarily checking for unexpected trailing data and only printing a warning. It is not making the program possibly unusable.

💬 fanquake commented on pull request "QA: Expect PACKAGE_NAME rather than constant "Bitcoin Core"":
(https://github.com/bitcoin/bitcoin/pull/30308#issuecomment-2180131521)
> not sure if you want to update here aswell in this PR

@luke-jr can you update this PR to include the additional changes.

💬 fanquake commented on pull request "depends: bump miniupnpc to 2.2.8":
(https://github.com/bitcoin/bitcoin/pull/30301#issuecomment-2180137005)
> Marked as draft until https://github.com/bitcoin/bitcoin/pull/30283 is merged.

Can rebase / undraft this now.

✅ fanquake closed an issue: "fuzz: wallet_bdb_parser: implicit-signed-integer-truncation wallet/migrate.cpp:554:35 "
(https://github.com/bitcoin/bitcoin/issues/30247)

🚀 fanquake merged a pull request: "refactor: Add explicit cast to expected_last_page to silence fuzz ISan"
(https://github.com/bitcoin/bitcoin/pull/30248)

💬 Sjors commented on pull request "Support self-hosted Cirrus workers on forks":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1647210274)
Thanks. I currently use `podman-docker` on Ubuntu 24.04. I created several `cirrus{1,2,3,4,5}` users.

For `cirrus1` I set `type: arm64`. I turned off `NO_ARM=true` for the occasion.

I installed `qemu-user-static` (`bash` and `podman-docker` were already there).

I ran your `podman run ...` incantation as the `cirrus1` user. And then started the worker:

```
RESTART_CI_DOCKER_BEFORE_RUN=1 USER_MODE=true MAKEJOBS=-j10 cirrus worker run -f ~/.cirrus.yaml
```

I then force-pushed an u
...

💬 Sjors commented on pull request "Support self-hosted Cirrus workers on forks":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1647216097)
The CPU is an AMD Ryzen 9 7950X.

💬 maflcko commented on issue "ci: Move more tasks to GHA?":
(https://github.com/bitcoin/bitcoin/issues/30304#issuecomment-2180151859)
Personally I think

* it is cleaner to not offer (and maintain) a bunch of config options for the CI services
* self-hosting is too much overhead for forks (especially for Windows/macOS builds)
* GHA is already required, and if they charged a price, someone would likely pay for it (if it is reasonably priced)
* Anyone really wanting to self-host can already do it today by writing their own CI provider and CI integration (the CI system itself only requires docker/podman)

Happy to close th
...

💬 maflcko commented on pull request "Support self-hosted Cirrus workers on forks":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1647220506)
> exec container process `/usr/bin/bash`: Exec format error

You can reproduce this outside the CI system with:

```
podman run --rm -ti "docker.io/arm64v8/debian:bookworm" uname --machine
```

You should be able to fix it by calling once:

```
podman run --rm --privileged docker.io/multiarch/qemu-user-static --reset -p yes
```

(and then double check with the previous command)

🚀 fanquake merged a pull request: "fuzz: Fix wallet_bdb_parser 32-bit unhandled fseek error"
(https://github.com/bitcoin/bitcoin/pull/30307)

💬 maflcko commented on pull request "QA: Expect PACKAGE_NAME rather than constant "Bitcoin Core"":
(https://github.com/bitcoin/bitcoin/pull/30308#issuecomment-2180168079)
previous releaseas are hardcoded to be Bitcoin Core, so need to change that

I wonder if one CI task should modify the PACKAGE_NAME to be something else, e.g. `Bitcoin Core CI-build`?

💬 fanquake commented on pull request "QA: Expect PACKAGE_NAME rather than constant "Bitcoin Core"":
(https://github.com/bitcoin/bitcoin/pull/30308#issuecomment-2180175255)
> previous releaseas are hardcoded to be Bitcoin Core, so need to change that

It can be changed just for consistency, and to prevent similar issues in future when devs copy-paste code.

💬 Sjors commented on pull request "Support self-hosted Cirrus workers on forks":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1647239779)
That first command:

```
WARNING: image platform (linux/arm64/v8) does not match the expected platform (linux/amd64)
{"msg":"exec container process `/usr/bin/uname`: Exec format error","level":"error","time":"2024-06-20T09:03:31.220776Z"}
```

Running the second command does not change anything.

💬 maflcko commented on pull request "Support self-hosted Cirrus workers on forks":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1647247303)
What is the output of the second command?

Locally, everything works for me:

```
lscpu | grep AMD && cat /etc/os-release | grep Noble && podman --version
Vendor ID: AuthenticAMD
Model name: AMD EPYC Processor
VERSION="24.04 LTS (Noble Numbat)"
podman version 4.9.3

💬 Sjors commented on pull request "Support self-hosted Cirrus workers on forks":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1647249068)
```
Vendor ID: AuthenticAMD
Model name: AMD Ryzen 9 7950X 16-Core Processor
Virtualization: AMD-V
VERSION="24.04 LTS (Noble Numbat)"
podman version 4.9.3
```

💬 maflcko commented on pull request "Support self-hosted Cirrus workers on forks":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1647250884)
What is the output of `podman run --rm --privileged docker.io/multiarch/qemu-user-static --reset -p yes`?

💬 Sjors commented on pull request "Support self-hosted Cirrus workers on forks":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1647252124)
```
podman run --rm --privileged docker.io/multiarch/qemu-user-static --reset -p yes
Setting /usr/bin/qemu-alpha-static as binfmt interpreter for alpha
Setting /usr/bin/qemu-arm-static as binfmt interpreter for arm
Setting /usr/bin/qemu-armeb-static as binfmt interpreter for armeb
Setting /usr/bin/qemu-sparc-static as binfmt interpreter for sparc
Setting /usr/bin/qemu-sparc32plus-static as binfmt interpreter for sparc32plus
Setting /usr/bin/qemu-sparc64-static as binfmt interpreter for sp
...

💬 Sjors commented on pull request "Support self-hosted Cirrus workers on forks":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1647267693)
When I run both commands as root, it does work. But doing so does not change anything for the non-root user. At least that's a clue.

💬 ajtowns commented on pull request "Fee Estimation: change `estimatesmartfee` default mode to `economical`":
(https://github.com/bitcoin/bitcoin/pull/30275#discussion_r1647268489)
Not sure if you understood what I meant, apologies if you did already: I mean if I'm looking at the estimatesmartfee help, trying to figure out if I want to change from the (new) default of "economical", the existing explanation of what "conservative" does seems more helpful than an explanation of what the default option does. So just changing the default without changing the rest of the help text seems slightly better, doesn't it?

💬 Sjors commented on pull request "Support self-hosted Cirrus workers on forks":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1647279777)
Some background information on what this actually does (though not podman specific): https://stackoverflow.com/a/72890225